Skip to content

Commit 264975e

Browse files
committed
Fix conditional expressions in npm-release-reusable workflow
- Correct if condition syntax for string comparisons - Use proper GitHub Actions expression syntax with ${{ }} - Fix conditions for tag creation, release creation, and release update - Should properly skip release creation when it already exists
1 parent 7982bc3 commit 264975e

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

.github/workflows/npm-release-reusable.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ jobs:
147147
docker push ${{ secrets.ACR_URL }}/${{ inputs.docker-image-name }}:latest
148148
149149
- name: Create and push tag
150-
if: '!inputs.dry-run && steps.check_tag.outputs.exists != ''true'''
150+
if: ${{ !inputs.dry-run && steps.check_tag.outputs.exists != 'true' }}
151151
run: |
152152
git config user.name github-actions
153153
git config user.email github-actions@github.com
@@ -169,7 +169,7 @@ jobs:
169169
GH_TOKEN: ${{ secrets.GH_PAT }}
170170

171171
- name: Create GitHub Release
172-
if: '!inputs.dry-run && steps.check_release.outputs.exists != ''true'''
172+
if: ${{ !inputs.dry-run && steps.check_release.outputs.exists != 'true' }}
173173
uses: actions/create-release@v1
174174
env:
175175
GITHUB_TOKEN: ${{ secrets.GH_PAT }}
@@ -188,7 +188,7 @@ jobs:
188188
prerelease: false
189189

190190
- name: Update existing release
191-
if: '!inputs.dry-run && steps.check_release.outputs.exists == ''true'' && inputs.docker-enabled'
191+
if: ${{ !inputs.dry-run && steps.check_release.outputs.exists == 'true' && inputs.docker-enabled }}
192192
run: |
193193
echo "Release already exists, updating with Docker image information"
194194
cat > release-notes.md << EOF

0 commit comments

Comments
 (0)