Skip to content

Commit e44967b

Browse files
committed
test: correct comment on label-filter rationale (#104)
The previous comment claimed the test's setup CREATE PROPERTY GRAPH job did not carry the sdk_feature='ontology-gql' label. That was factually wrong: setup goes through OntologyPropertyGraphCompiler.create_property_graph() (line 387), which does carry the label. The test logic was already correct — the setup job is excluded by the post-setup timestamp captured in step 2, not by the label filter. The label filter excludes user-authored raw SQL DDL jobs (without SDK labels), which is its actual purpose. Only the comment needed to change. No code change.
1 parent 5e53b61 commit e44967b

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

tests/test_integration_ontology_binding.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -449,10 +449,12 @@ def test_skip_property_graph_issues_no_create_graph_job(
449449
# the regression in either dataset.
450450
# 4. sdk_feature='ontology-gql' label — only SDK-issued
451451
# property-graph jobs carry this label
452-
# (ontology_property_graph.py:465), so unrelated user-
453-
# authored CREATE PROPERTY GRAPH DDLs (including the test's
454-
# own setup job in step 1, which was not labeled this way)
455-
# do not trip the assertion.
452+
# (ontology_property_graph.py:465). The setup CREATE PROPERTY
453+
# GRAPH job in step 1 *also* uses this label (it goes through
454+
# OntologyPropertyGraphCompiler.create_property_graph()), but
455+
# it is excluded by the post-setup timestamp captured in
456+
# step 2. User-authored raw SQL DDL jobs without SDK labels
457+
# are excluded by this label filter.
456458
region_qual = f"`region-{_LOCATION.lower()}`"
457459
jobs_query = f"""
458460
SELECT job_id, query, creation_time

0 commit comments

Comments
 (0)