Commit 37dafda
Fix App Engine tests for Windows.
This change addresses several issues that prevented App Engine tests from passing on Windows:
- **Maven Wrapper:** The Maven wrapper executable `mvnw` is now invoked with the `.cmd` extension when running on Windows to ensure it can be executed correctly.
- **Newline Handling:** Test output reading logic has been updated to handle both `\n` and `\r\n` newline representations, which is necessary for Windows compatibility.
These changes ensure that the affected tests pass on both Linux/macOS and Windows environments.
PiperOrigin-RevId: 736207509
Change-Id: I7c11b010689343ccdbf9b29801e17569064bb8671 parent 69e34d9 commit 37dafda
5 files changed
Lines changed: 23 additions & 10 deletions
File tree
- e2etests/stagingtests/src/test/java/com/google/appengine/tools/admin
- lib/tools_api/src/test/java/com/google/appengine/tools/admin
- runtime
- impl/src/test/java/com/google/apphosting/runtime
- test/src/test/java/com/google/apphosting/runtime/jetty9
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
141 | 141 | | |
142 | 142 | | |
143 | 143 | | |
144 | | - | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
145 | 147 | | |
146 | 148 | | |
147 | 149 | | |
| |||
Lines changed: 4 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2775 | 2775 | | |
2776 | 2776 | | |
2777 | 2777 | | |
2778 | | - | |
2779 | | - | |
| 2778 | + | |
| 2779 | + | |
| 2780 | + | |
2780 | 2781 | | |
2781 | 2782 | | |
2782 | 2783 | | |
| |||
2790 | 2791 | | |
2791 | 2792 | | |
2792 | 2793 | | |
2793 | | - | |
| 2794 | + | |
2794 | 2795 | | |
2795 | 2796 | | |
2796 | 2797 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
67 | | - | |
68 | | - | |
| 67 | + | |
| 68 | + | |
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
| |||
Lines changed: 10 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
117 | 117 | | |
118 | 118 | | |
119 | 119 | | |
120 | | - | |
121 | | - | |
122 | | - | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
123 | 130 | | |
124 | 131 | | |
125 | 132 | | |
| |||
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
43 | 46 | | |
44 | 47 | | |
45 | 48 | | |
| |||
0 commit comments