add jstl to JSP library and servlet group (#1548)

Author: elharo

plugins/com.google.cloud.tools.eclipse.appengine.libraries.test/src/com/google/cloud/tools/eclipse/appengine/libraries/AppEngineLibrariesInPluginXmlTest.java

@@ -230,23 +230,37 @@ public void testJspApiLibraryConfig() throws URISyntaxException {
     assertNotNull(jspApiLibrary.getLibraryDependencies());
     assertTrue(jspApiLibrary.getLibraryDependencies().isEmpty());
 
-    assertThat(jspApiLibrary.getLibraryFiles().size(), is(1));
-    LibraryFile libraryFile = jspApiLibrary.getLibraryFiles().get(0);
-    assertThat(libraryFile.getJavadocUri(), is(new URI(
+    assertThat(jspApiLibrary.getLibraryFiles().size(), is(2));
+    LibraryFile jspApi = jspApiLibrary.getLibraryFiles().get(0);
+    assertThat(jspApi.getJavadocUri(), is(new URI(
         "http://docs.oracle.com/cd/E17802_01/products/products/jsp/2.1/docs/jsp-2_1-pfd2/")));
-    assertNull(libraryFile.getSourceUri());
+    assertNull(jspApi.getSourceUri());
 
-    assertNotNull(libraryFile.getMavenCoordinates());
-    MavenCoordinates mavenCoordinates = libraryFile.getMavenCoordinates();
+    assertNotNull(jspApi.getMavenCoordinates());
+    MavenCoordinates mavenCoordinates = jspApi.getMavenCoordinates();
     assertThat(mavenCoordinates.getRepository(), is("central"));
     assertThat(mavenCoordinates.getGroupId(), is("javax.servlet.jsp"));
     assertThat(mavenCoordinates.getArtifactId(), is("jsp-api"));
     assertThat(mavenCoordinates.getVersion(), is("2.1"));
     assertThat(mavenCoordinates.getType(), is("jar"));
     assertNull(mavenCoordinates.getClassifier());
 
-    assertNotNull(libraryFile.getFilters());
-    assertTrue(libraryFile.getFilters().isEmpty());
+    assertTrue(jspApi.getFilters().isEmpty());
+    
+    LibraryFile jstlApi = jspApiLibrary.getLibraryFiles().get(1);
+    assertThat(jstlApi.getJavadocUri(), is(new URI("https://jstl.java.net/")));
+    assertNull(jstlApi.getSourceUri());
+
+    assertNotNull(jstlApi.getMavenCoordinates());
+    MavenCoordinates jstlCoordinates = jstlApi.getMavenCoordinates();
+    assertThat(jstlCoordinates.getRepository(), is("central"));
+    assertThat(jstlCoordinates.getGroupId(), is("javax.servlet"));
+    assertThat(jstlCoordinates.getArtifactId(), is("jstl"));
+    assertThat(jstlCoordinates.getVersion(), is("1.2"));
+    assertThat(jstlCoordinates.getType(), is("jar"));
+    assertNull(jstlCoordinates.getClassifier());
+
+    assertTrue(jstlApi.getFilters().isEmpty());
   }
 
 }

plugins/com.google.cloud.tools.eclipse.appengine.libraries/plugin.xml

@@ -92,6 +92,9 @@
               groupId="javax.servlet.jsp"
               version="2.1" />
       </libraryFile>
+      <libraryFile javadocUri="https://jstl.java.net/">
+        <mavenCoordinates artifactId="jstl" groupId="javax.servlet" version="1.2" />
+      </libraryFile>
     </library>
   </extension>