Skip to content

Commit 0582382

Browse files
committed
Ensure test projects have different names to avoid class; log if project deletion timesout
1 parent 56d4538 commit 0582382

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

plugins/com.google.cloud.tools.eclipse.integration.appengine/src/com/google/cloud/tools/eclipse/integration/appengine/BaseProjectTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ public void tearDown() {
6868
SwtBotProjectActions.deleteProject(bot, project.getName());
6969
} catch (TimeoutException ex) {
7070
// If this fails it shouldn't fail the test, which has already run
71+
new RuntimeException("tearDown() timed out", ex).printStackTrace();
7172
}
7273
project = null;
7374
}

plugins/com.google.cloud.tools.eclipse.integration.appengine/src/com/google/cloud/tools/eclipse/integration/appengine/NewMavenBasedAppEngineProjectWizardTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ public class NewMavenBasedAppEngineProjectWizardTest extends BaseProjectTest {
6565
public void testHelloWorld_java7() throws Exception {
6666
String[] projectFiles =
6767
{"src/main/webapp/WEB-INF/appengine-web.xml", "src/main/webapp/WEB-INF/web.xml", "pom.xml"};
68-
createAndCheck("appWithPackageProject", null, "com.example.baz",
68+
createAndCheck("appWithPackageProjectJava7", null, "com.example.baz",
6969
AppEngineRuntime.STANDARD_JAVA_7, projectFiles);
7070
assertEquals("1.7", getPomProperty(project, "maven.compiler.source"));
7171
assertEquals("1.7", getPomProperty(project, "maven.compiler.target"));
@@ -76,7 +76,7 @@ public void testHelloWorld_java8() throws Exception {
7676
Assume.assumeTrue("Requires a Java 8 JRE", JavaRuntimeUtils.hasJavaSE8());
7777
String[] projectFiles =
7878
{"src/main/webapp/WEB-INF/appengine-web.xml", "src/main/webapp/WEB-INF/web.xml", "pom.xml"};
79-
createAndCheck("appWithPackageProject", null, "com.example.baz",
79+
createAndCheck("appWithPackageProjectJava8", null, "com.example.baz",
8080
AppEngineRuntime.STANDARD_JAVA_8, projectFiles);
8181
assertEquals("1.8", getPomProperty(project, "maven.compiler.source"));
8282
assertEquals("1.8", getPomProperty(project, "maven.compiler.target"));
@@ -90,7 +90,7 @@ public void testHelloWorld_nonDefaultLocation() throws Exception {
9090

9191
String[] projectFiles =
9292
{"src/main/webapp/WEB-INF/appengine-web.xml", "src/main/webapp/WEB-INF/web.xml", "pom.xml"};
93-
createAndCheck("appWithPackageProjectInTemp", location.getAbsolutePath(), "com.example.foo",
93+
createAndCheck("appWithPackageProjectJava7InTemp", location.getAbsolutePath(), "com.example.foo",
9494
AppEngineRuntime.STANDARD_JAVA_7, projectFiles);
9595
}
9696

0 commit comments

Comments
 (0)