Skip to content

Commit 08c2ac4

Browse files
authored
Change project creation URL (#2221)
* Change project creation URL * Update URL to set previous page
1 parent 2630351 commit 08c2ac4

2 files changed

Lines changed: 15 additions & 3 deletions

File tree

plugins/com.google.cloud.tools.eclipse.appengine.deploy.ui.test/src/com/google/cloud/tools/eclipse/appengine/deploy/ui/AppEngineDeployPreferencesPanelTest.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
package com.google.cloud.tools.eclipse.appengine.deploy.ui;
1818

1919
import static org.hamcrest.CoreMatchers.is;
20+
import static org.junit.Assert.assertEquals;
2021
import static org.junit.Assert.assertFalse;
2122
import static org.junit.Assert.assertNotEquals;
2223
import static org.junit.Assert.assertNotNull;
@@ -97,6 +98,12 @@ public void setUp() {
9798
twoAccountSet = new HashSet<>(Arrays.asList(account1, account2));
9899
}
99100

101+
@Test
102+
public void testCreateGcpProjectUrl() {
103+
assertEquals("https://console.cloud.google.com/projectcreate?previousPage=%2Fprojectselector%2Fappengine%2Fcreate%3Flang%3Djava",
104+
AppEngineDeployPreferencesPanel.CREATE_GCP_PROJECT_URL);
105+
}
106+
100107
@Test
101108
public void testAutoSelectSingleAccount() {
102109
when(loginService.getAccounts()).thenReturn(oneAccountSet);

plugins/com.google.cloud.tools.eclipse.appengine.deploy.ui/src/com/google/cloud/tools/eclipse/appengine/deploy/ui/AppEngineDeployPreferencesPanel.java

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@
3838
import com.google.common.base.Preconditions;
3939
import com.google.common.base.Predicate;
4040
import com.google.common.base.Strings;
41+
import com.google.common.net.UrlEscapers;
4142
import java.util.Collection;
4243
import java.util.Collections;
4344
import java.util.Map;
@@ -90,8 +91,12 @@ public abstract class AppEngineDeployPreferencesPanel extends DeployPreferencesP
9091

9192
private static final String APPENGINE_VERSIONS_URL =
9293
"https://console.cloud.google.com/appengine/versions";
93-
private static final String CREATE_GCP_PROJECT_WITH_GAE_URL =
94-
"https://console.cloud.google.com/projectselector/appengine/create?lang=java";
94+
private static final String APP_ENGINE_APPLICATION_CREATE_PATH =
95+
"/projectselector/appengine/create?lang=java";
96+
@VisibleForTesting
97+
static final String CREATE_GCP_PROJECT_URL =
98+
"https://console.cloud.google.com/projectcreate?previousPage="
99+
+ UrlEscapers.urlFormParameterEscaper().escape(APP_ENGINE_APPLICATION_CREATE_PATH);
95100

96101
private static final Logger logger = Logger.getLogger(
97102
AppEngineDeployPreferencesPanel.class.getName());
@@ -335,7 +340,7 @@ private void createProjectIdSection() {
335340
Composite linkComposite = new Composite(this, SWT.NONE);
336341
Link createNewProject = new Link(linkComposite, SWT.WRAP);
337342
createNewProject.setText(Messages.getString("projectselector.createproject",
338-
CREATE_GCP_PROJECT_WITH_GAE_URL));
343+
CREATE_GCP_PROJECT_URL));
339344
createNewProject.setToolTipText(Messages.getString("projectselector.createproject.tooltip"));
340345
FontUtil.convertFontToItalic(createNewProject);
341346
createNewProject.addSelectionListener(

0 commit comments

Comments
 (0)