Don't ignore case in xml validation (#1590)

* Don't ignore case in xml validation

* don't ignore case in WebXmlScanner

* add tests

* change assertion

Author: abbiefarr

plugins/com.google.cloud.tools.eclipse.appengine.validation.test/src/com/google/cloud/tools/eclipse/appengine/validation/PomXmlScannerTest.java

@@ -37,6 +37,13 @@ public void setUp() throws SAXException {
     scanner.startDocument();
   }
 
+  @Test
+  public void testCaseSensitive() throws SAXException {
+    scanner.startElement("", "Plugin", "", new AttributesImpl());
+    assertEquals(0, scanner.getBlacklist().size());
+    assertFalse(scanner.getInsidePlugin());
+  }
+  
   @Test
   public void testStartElement_build() throws SAXException {
     scanner.startElement("", "plugin", "", new AttributesImpl());

plugins/com.google.cloud.tools.eclipse.appengine.validation.test/src/com/google/cloud/tools/eclipse/appengine/validation/WebXmlScannerTest.java

@@ -17,6 +17,7 @@
 package com.google.cloud.tools.eclipse.appengine.validation;
 
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
 
 import org.junit.Before;
 import org.junit.Test;
@@ -34,6 +35,14 @@ public void setUp() throws SAXException {
     scanner.startDocument();
   }
 
+  @Test
+  public void testCaseSensitive() throws SAXException {
+    AttributesImpl attributes = new AttributesImpl();
+    attributes.addAttribute("", "", "version", "", "3.1");
+    scanner.startElement("http://xmlns.jcp.org/xml/ns/javaee", "Web-App", "", attributes);
+    assertTrue(scanner.getBlacklist().isEmpty());
+  }
+  
   @Test
   public void testStartElement_jcpNamespace() throws SAXException {
     AttributesImpl attributes = new AttributesImpl();

plugins/com.google.cloud.tools.eclipse.appengine.validation/src/com/google/cloud/tools/eclipse/appengine/validation/PomXmlScanner.java

@@ -42,12 +42,12 @@ class PomXmlScanner extends AbstractScanner {
   @Override
   public void startElement(String uri, String localName, String qName, Attributes attributes)
       throws SAXException {
-    if ("plugin".equalsIgnoreCase(localName)) {
+    if ("plugin".equals(localName)) {
       insidePlugin = true;
-    } else if (insidePlugin && "artifactId".equalsIgnoreCase(localName)) {
+    } else if (insidePlugin && "artifactId".equals(localName)) {
       saveContents = true;
       elementContents = new StringBuilder();
-    } else if (insidePlugin && "groupId".equalsIgnoreCase(localName)) {
+    } else if (insidePlugin && "groupId".equals(localName)) {
       Locator2 locator = getLocator();
       saveContents = true;
       elementContents = new StringBuilder();
@@ -76,7 +76,7 @@ public void characters (char ch[], int start, int length)
   @Override
   public void endElement (String uri, String localName, String qName)
       throws SAXException {
-    if ("plugin".equalsIgnoreCase(localName)) {
+    if ("plugin".equals(localName)) {
       // Found closing <plugin> tag
       resetFlags();
     } else if (insidePlugin && "groupId".equals(localName)) {
@@ -85,7 +85,7 @@ public void endElement (String uri, String localName, String qName)
       if ("com.google.appengine".equals(elementContents.toString())) {
         foundAppEngineGroupId = true;
       }
-    } else if (insidePlugin && "artifactId".equalsIgnoreCase(localName)) {
+    } else if (insidePlugin && "artifactId".equals(localName)) {
       // Found closing <artifactId> tag with parent <plugin>
       saveContents = false;
       if ("appengine-maven-plugin".equals(elementContents.toString()) || 

plugins/com.google.cloud.tools.eclipse.appengine.validation/src/com/google/cloud/tools/eclipse/appengine/validation/WebXmlScanner.java

@@ -30,7 +30,7 @@ public void startElement(String uri, String localName, String qName, Attributes
       throws SAXException {
     // Checks for expected namespace URI. Assume something else is going on if
     // web.xml has an unexpected root namespace.
-    if ("web-app".equalsIgnoreCase(localName) && ("http://xmlns.jcp.org/xml/ns/javaee".equals(uri)
+    if ("web-app".equals(localName) && ("http://xmlns.jcp.org/xml/ns/javaee".equals(uri)
         || "http://java.sun.com/xml/ns/javaee".equals(uri))) {
       String version = attributes.getValue("version");
       if (!version.equals("2.5")) {