Skip to content

Commit 23a4a66

Browse files
authored
Added option to show the Library selector group in the Create New App Engine wizard. (#1584)
* Added option to show the Library selector group in the Create New App Engine wizard. Standard shows the library selector group and flex does not * Made getSelectedLibraries return ean emply collection when the library selector is not created. * Minor chnage per PR comment
1 parent f2c7220 commit 23a4a66

3 files changed

Lines changed: 17 additions & 4 deletions

File tree

plugins/com.google.cloud.tools.eclipse.appengine.newproject/src/com/google/cloud/tools/eclipse/appengine/newproject/AppEngineWizardPage.java

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import com.google.cloud.tools.eclipse.appengine.ui.AppEngineLibrariesSelectorGroup;
2222
import java.io.File;
2323
import java.util.Collection;
24+
import java.util.HashSet;
2425
import org.eclipse.core.runtime.IStatus;
2526
import org.eclipse.jface.dialogs.Dialog;
2627
import org.eclipse.jface.layout.GridDataFactory;
@@ -42,10 +43,12 @@ public abstract class AppEngineWizardPage extends WizardNewProjectCreationPage {
4243
private Text javaPackageField;
4344
private AppEngineLibrariesSelectorGroup appEngineLibrariesSelectorGroup;
4445
private Text serviceNameField;
46+
private final boolean showLibrariesSelectorGroup;
4547

46-
public AppEngineWizardPage() {
48+
public AppEngineWizardPage(boolean showLibrariesSelectorGroup) {
4749
super("basicNewProjectPage"); //$NON-NLS-1$
4850
setImageDescriptor(AppEngineImages.appEngine(64));
51+
this.showLibrariesSelectorGroup = showLibrariesSelectorGroup;
4952
}
5053

5154
public abstract void sendAnalyticsPing(Shell parentShell);
@@ -64,7 +67,9 @@ public void createControl(Composite parent) {
6467
createCustomFields(container, pageValidator);
6568

6669
// Manage APIs
67-
appEngineLibrariesSelectorGroup = new AppEngineLibrariesSelectorGroup(container);
70+
if (showLibrariesSelectorGroup) {
71+
appEngineLibrariesSelectorGroup = new AppEngineLibrariesSelectorGroup(container);
72+
}
6873

6974
setPageComplete(validatePage());
7075
// Show enter project name on opening
@@ -154,12 +159,18 @@ public String getPackageName() {
154159
}
155160

156161
public Collection<Library> getSelectedLibraries() {
157-
return appEngineLibrariesSelectorGroup.getSelectedLibraries();
162+
if (appEngineLibrariesSelectorGroup == null) {
163+
return new HashSet<Library>();
164+
} else {
165+
return appEngineLibrariesSelectorGroup.getSelectedLibraries();
166+
}
158167
}
159168

160169
@Override
161170
public void dispose() {
162-
appEngineLibrariesSelectorGroup.dispose();
171+
if (appEngineLibrariesSelectorGroup != null) {
172+
appEngineLibrariesSelectorGroup.dispose();
173+
}
163174
super.dispose();
164175
}
165176

plugins/com.google.cloud.tools.eclipse.appengine.newproject/src/com/google/cloud/tools/eclipse/appengine/newproject/flex/AppEngineFlexWizardPage.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424

2525
public class AppEngineFlexWizardPage extends AppEngineWizardPage {
2626
public AppEngineFlexWizardPage() {
27+
super(false);
2728
setTitle(Messages.getString("app.engine.flex.project")); //$NON-NLS-1$
2829
setDescription(Messages.getString("create.app.engine.flex.project")); //$NON-NLS-1$
2930
}

plugins/com.google.cloud.tools.eclipse.appengine.newproject/src/com/google/cloud/tools/eclipse/appengine/newproject/standard/AppEngineStandardWizardPage.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626

2727
public class AppEngineStandardWizardPage extends AppEngineWizardPage {
2828
public AppEngineStandardWizardPage() {
29+
super(true);
2930
setTitle(Messages.getString("app.engine.standard.project")); //$NON-NLS-1$
3031
setDescription(Messages.getString("create.app.engine.standard.project")); //$NON-NLS-1$
3132
}

0 commit comments

Comments
 (0)