unused code (#2127)

Author: elharo

plugins/com.google.cloud.tools.eclipse.util.test/src/com/google/cloud/tools/eclipse/util/MavenUtilsTest.java

@@ -17,9 +17,6 @@
 package com.google.cloud.tools.eclipse.util;
 
 import com.google.cloud.tools.eclipse.test.util.project.TestProjectCreator;
-import java.util.ArrayList;
-import java.util.List;
-import org.apache.maven.model.Dependency;
 import org.eclipse.core.resources.IProject;
 import org.eclipse.core.runtime.CoreException;
 import org.junit.Assert;
@@ -47,74 +44,4 @@ public void testMavenNature_nonMavenProject() {
     Assert.assertFalse(MavenUtils.hasMavenNature(project));
   }
 
-  @Test
-  public void testAreDependenciesEqual_nullDependencies() {
-    Assert.assertFalse(MavenUtils.areDependenciesEqual(null, null));
-    Assert.assertFalse(MavenUtils.areDependenciesEqual(new Dependency(), null));
-    Assert.assertFalse(MavenUtils.areDependenciesEqual(null, new Dependency()));
-  }
-
-  @Test
-  public void testAreDependenciesEqual_equalDependencies() {
-    Dependency dependency1 = new Dependency();
-    Dependency dependency2 = new Dependency();
-    Dependency dependency3 = new Dependency();
-    dependency3.setGroupId("groupId");
-    dependency3.setArtifactId("artifactId");
-    Dependency dependency4 = new Dependency();
-    dependency4.setGroupId("groupId");
-    dependency4.setArtifactId("artifactId");
-
-    Assert.assertTrue(MavenUtils.areDependenciesEqual(dependency1, dependency2));
-    Assert.assertTrue(MavenUtils.areDependenciesEqual(dependency3, dependency4));
-  }
-
-  @Test
-  public void testAreDependenciesEqual_unEqualDependencies() {
-    Dependency dependency1 = new Dependency();
-    Dependency dependency2 = new Dependency();
-    dependency2.setGroupId("groupId1");
-    dependency2.setArtifactId("artifactId1");
-    Dependency dependency3 = new Dependency();
-    dependency3.setGroupId("groupId2");
-    dependency3.setArtifactId("artifactId2");
-
-    Assert.assertFalse(MavenUtils.areDependenciesEqual(dependency1, dependency2));
-    Assert.assertFalse(MavenUtils.areDependenciesEqual(dependency2, dependency3));
-  }
-
-  @Test
-  public void testDoesListContainDependency_existingDependency() {
-    Dependency dependency1 = new Dependency();
-    dependency1.setGroupId("groupId");
-    dependency1.setArtifactId("artifactId");
-    List<Dependency> dependencies = new ArrayList<>();
-    dependencies.add(dependency1);
-
-    Dependency dependency2 = new Dependency();
-    dependency2.setGroupId("groupId");
-    dependency2.setArtifactId("artifactId");
-
-    Assert.assertTrue(MavenUtils.doesListContainDependency(dependencies, dependency2));
-  }
-
-  @Test
-  public void testDoesListContainDependency_nonExistingDependency() {
-    List<Dependency> dependencies1 = new ArrayList<>();
-    List<Dependency> dependencies2 = new ArrayList<>();
-    Dependency dependency1 = new Dependency();
-    Dependency dependency2 = new Dependency();
-    dependency2.setGroupId("groupId2");
-    dependency2.setArtifactId("artifactId2");
-    Dependency dependency3 = new Dependency();
-    dependency3.setGroupId("groupId3");
-    dependency3.setArtifactId("artifactId3");
-    dependencies2.add(dependency2);
-
-    Assert.assertFalse(MavenUtils.doesListContainDependency(null, null));
-    Assert.assertFalse(MavenUtils.doesListContainDependency(dependencies1, null));
-    Assert.assertFalse(MavenUtils.doesListContainDependency(dependencies1, dependency1));
-    Assert.assertFalse(MavenUtils.doesListContainDependency(dependencies1, dependency2));
-    Assert.assertFalse(MavenUtils.doesListContainDependency(dependencies2, dependency3));
-  }
 }

plugins/com.google.cloud.tools.eclipse.util/src/com/google/cloud/tools/eclipse/util/MavenUtils.java

@@ -17,7 +17,6 @@
 package com.google.cloud.tools.eclipse.util;
 
 import com.google.cloud.tools.eclipse.util.status.StatusUtil;
-import com.google.common.base.Objects;
 import com.google.common.base.Preconditions;
 import java.io.File;
 import java.io.IOException;
@@ -32,7 +31,6 @@
 import org.apache.maven.artifact.DefaultArtifact;
 import org.apache.maven.artifact.handler.DefaultArtifactHandler;
 import org.apache.maven.artifact.repository.ArtifactRepository;
-import org.apache.maven.model.Dependency;
 import org.eclipse.core.resources.IProject;
 import org.eclipse.core.runtime.CoreException;
 import org.eclipse.core.runtime.IProgressMonitor;
@@ -66,38 +64,6 @@ public static boolean hasMavenNature(IProject project) {
     }
   }
 
-  /**
-   * Returns true if the group IDs and artifact IDs of <code>dependency1</code> and
-   * <@code>dependency2</@code> are equal. Returns false otherwise.
-   */
-  public static boolean areDependenciesEqual(Dependency dependency1, Dependency dependency2) {
-    if (dependency1 == null || dependency2 == null) {
-      return false;
-    }
-
-    return Objects.equal(dependency1.getGroupId(), dependency2.getGroupId())
-        && Objects.equal(dependency1.getArtifactId(), dependency2.getArtifactId());
-  }
-
-  /**
-   * Returns true if a dependency with the same group ID and artifact ID as
-   * <code>targetDependency</code> exists in <code>dependencies</code>. Returns false otherwise.
-   */
-  public static boolean doesListContainDependency(List<Dependency> dependencies,
-      Dependency targetDependency) {
-    if (dependencies == null || targetDependency == null) {
-      return false;
-    }
-
-    for (Dependency dependency : dependencies) {
-      if (areDependenciesEqual(dependency, targetDependency)) {
-        return true;
-      }
-    }
-
-    return false;
-  }
-
   /**
    * Returns the latest version of the maven artifact specified via <code>groupId</code> and
    * <code>artifactId</code> or the <code>defaultVersion</code> if an error occurs while fetching