Skip to content

Commit 5b26128

Browse files
authored
reduce public visibility (#1495)
* reduce public visibility * a couple of methods must be public * a couple of methods must be public
1 parent 8aae460 commit 5b26128

3 files changed

Lines changed: 9 additions & 8 deletions

File tree

plugins/com.google.cloud.tools.eclipse.appengine.libraries/src/com/google/cloud/tools/eclipse/appengine/libraries/model/LibraryFile.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public List<Filter> getFilters() {
4848
return new ArrayList<>(filters);
4949
}
5050

51-
public void setFilters(List<Filter> filters) {
51+
void setFilters(List<Filter> filters) {
5252
if (filters != null) {
5353
this.filters = new ArrayList<>(filters);
5454
}

plugins/com.google.cloud.tools.eclipse.appengine.libraries/src/com/google/cloud/tools/eclipse/appengine/libraries/model/MavenCoordinates.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ public String getVersion() {
7171

7272
/**
7373
* @param version the Maven version of the artifact, defaults to special value
74-
* {@link MavenCoordinates#LATEST_VERSION}, cannot be <code>null</code> or empty string.
74+
* {@link MavenCoordinates#LATEST_VERSION}, cannot be <code>null</code> or empty string.
7575
*/
7676
public void setVersion(String version) {
7777
Preconditions.checkNotNull(version, "version is null");
@@ -88,7 +88,7 @@ public String getType() {
8888

8989
/**
9090
* @param type the Maven packaging type, defaults to <code>jar</code>, cannot be <code>null</code>
91-
* or empty string.
91+
* or empty string.
9292
*/
9393
public void setType(String type) {
9494
Preconditions.checkNotNull(type, "type is null");

plugins/com.google.cloud.tools.eclipse.appengine.libraries/src/com/google/cloud/tools/eclipse/appengine/libraries/repository/M2RepositoryService.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -115,10 +115,11 @@ void setMavenHelper(MavenHelper mavenHelper) {
115115
* Maven.
116116
*/
117117
@Override
118-
public void makeArtifactAvailable(LibraryFile libraryFile, IProgressMonitor monitor) throws CoreException {
119-
if (mavenHelper.isArtifactLocallyAvailable(libraryFile.getMavenCoordinates())) {
120-
return;
121-
}
122-
mavenHelper.resolveArtifact(libraryFile.getMavenCoordinates(), monitor);
118+
public void makeArtifactAvailable(LibraryFile libraryFile, IProgressMonitor monitor)
119+
throws CoreException {
120+
if (mavenHelper.isArtifactLocallyAvailable(libraryFile.getMavenCoordinates())) {
121+
return;
122+
}
123+
mavenHelper.resolveArtifact(libraryFile.getMavenCoordinates(), monitor);
123124
}
124125
}

0 commit comments

Comments
 (0)