Skip to content

Commit 6b53237

Browse files
authored
Add HttpUtil test (#1535)
* Add HttpUtil test * Do static initializtion of static map
1 parent 78772ab commit 6b53237

1 file changed

Lines changed: 24 additions & 7 deletions

File tree

plugins/com.google.cloud.tools.eclipse.usagetracker.test/src/com/google/cloud/tools/eclipse/usagetracker/HttpUtilWithServerTest.java

Lines changed: 24 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -33,19 +33,36 @@ public class HttpUtilWithServerTest {
3333
private static final String LONG_PARAMETER = "Exception in thread \"main\""
3434
+ " java.lang.IllegalArgumentException: Wrong argument!\n\tat B.main(B.java:73)";
3535

36+
private static final Map<String, String> testParameters;
37+
static {
38+
testParameters = new HashMap<>();
39+
testParameters.put("dp", "/virtual/some-event-type/some-event-name");
40+
testParameters.put("exception_info", LONG_PARAMETER);
41+
testParameters.put("product", "CT4E");
42+
};
43+
3644
@Test
3745
public void testSendPostMultipart() throws IOException {
38-
Map<String, String> parameters = new HashMap<>();
39-
parameters.put("dp", "/virtual/some-event-type/some-event-name");
40-
parameters.put("exception_info", LONG_PARAMETER);
41-
parameters.put("product", "CT4E");
46+
assertEquals(200, HttpUtil.sendPostMultipart(server.getAddress(), testParameters));
47+
assertTrue(server.getRequestHeaders().get("Content-Type")
48+
.startsWith("multipart/form-data; boundary="));
4249

43-
assertEquals(200, HttpUtil.sendPostMultipart(server.getAddress(), parameters));
50+
verifyPostRequest();
51+
}
52+
53+
@Test
54+
public void testSendPost() throws IOException {
55+
assertEquals(200, HttpUtil.sendPost(server.getAddress(), testParameters));
56+
assertEquals("application/x-www-form-urlencoded",
57+
server.getRequestHeaders().get("Content-Type"));
58+
59+
verifyPostRequest();
60+
}
61+
62+
private void verifyPostRequest() {
4463
assertEquals("POST", server.getRequestMethod());
4564
assertTrue(server.getRequestHeaders().get("User-Agent")
4665
.startsWith("gcloud-eclipse-tools/"));
47-
assertTrue(server.getRequestHeaders().get("Content-Type")
48-
.startsWith("multipart/form-data; boundary="));
4966

5067
Map<String, String[]> parsedParameters = server.getRequestParameters();
5168
assertEquals("/virtual/some-event-type/some-event-name", parsedParameters.get("dp")[0]);

0 commit comments

Comments
 (0)