some tests for AppEngineLibrariesPage (#1511)

* some tests for AppEngineLibrariesPage

* some tests for AppEngineLibrariesPage

* copyright

* spacing

* remove unneeded final

* line length

* formatting

Author: elharo

plugins/com.google.cloud.tools.eclipse.appengine.libraries.ui.test/src/com/google/cloud/tools/eclipse/appengine/libraries/ui/AppEngineLibrariesPageTest.java

@@ -0,0 +1,47 @@
+/*
+ * Copyright 2017 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.google.cloud.tools.eclipse.appengine.libraries.ui;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+public class AppEngineLibrariesPageTest {
+
+  private AppEngineLibrariesPage page = new AppEngineLibrariesPage();
+
+  @Test
+  public void testConstructor() {
+    Assert.assertEquals("App Engine Standard Environment Libraries", page.getTitle());
+    Assert.assertNull(page.getMessage());
+    Assert.assertNull(page.getErrorMessage());
+    Assert.assertEquals(
+        "Additional jars commonly used in App Engine Standard Environment applications",
+        page.getDescription());
+    Assert.assertNotNull(page.getImage());
+  }
+  
+  @Test
+  public void testFinish() {
+    Assert.assertTrue(page.finish());
+  }
+  
+  @Test
+  public void testGetSelection() {
+    Assert.assertNull(page.getSelection());
+  }
+
+}

plugins/com.google.cloud.tools.eclipse.appengine.libraries.ui.test/src/com/google/cloud/tools/eclipse/appengine/libraries/ui/MessagesTest.java

@@ -32,5 +32,12 @@ public void testDescription() {
         "Additional jars commonly used in App Engine Standard Environment applications", 
         Messages.getString("description"));
   }
+  
+
+  @Test
+  public void testUnknownMessage() {
+    Assert.assertEquals("!foo.bar!",  Messages.getString("foo.bar"));
+  }
+  
 
 }

plugins/com.google.cloud.tools.eclipse.appengine.libraries.ui/src/com/google/cloud/tools/eclipse/appengine/libraries/ui/AppEngineLibrariesPage.java

@@ -52,8 +52,8 @@ public class AppEngineLibrariesPage extends WizardPage implements IClasspathCont
 
   public AppEngineLibrariesPage() {
     super("appengine-libraries-page"); //$NON-NLS-1$
-    setTitle(Messages.getString("title"));
-    setDescription(Messages.getString("description"));
+    setTitle(Messages.getString("title"));  //$NON-NLS-1$
+    setDescription(Messages.getString("description"));  //$NON-NLS-1$
     setImageDescriptor(AppEngineImages.appEngine(64));
   }
 

plugins/com.google.cloud.tools.eclipse.appengine.libraries/src/com/google/cloud/tools/eclipse/appengine/libraries/repository/LibraryClasspathContainerResolverService.java

@@ -183,17 +183,17 @@ private LibraryClasspathContainer resolveLibraryFiles(IJavaProject javaProject,
 
   private IClasspathEntry resolveLibraryFileAttachSourceAsync(IJavaProject javaProject,
                                                               IPath containerPath,
-                                                              final LibraryFile libraryFile,
+                                                              LibraryFile libraryFile,
                                                               List<Job> sourceAttacherJobs,
-                                                              final IProgressMonitor monitor)
+                                                              IProgressMonitor monitor)
                                                                   throws CoreException {
-    final Artifact artifact = repositoryService.resolveArtifact(libraryFile, monitor);
+    Artifact artifact = repositoryService.resolveArtifact(libraryFile, monitor);
     IPath libraryPath = new Path(artifact.getFile().getAbsolutePath());
     IPath sourceAttachmentPath = null;
     Job job = createSourceAttacherJob(javaProject, containerPath, libraryFile,
                                       monitor, artifact, libraryPath);
     sourceAttacherJobs.add(job);
-    final IClasspathEntry newLibraryEntry =
+    IClasspathEntry newLibraryEntry =
         JavaCore.newLibraryEntry(libraryPath,
                                  sourceAttachmentPath,
                                  null /*  sourceAttachmentRootPath */,

plugins/com.google.cloud.tools.eclipse.appengine.libraries/src/com/google/cloud/tools/eclipse/appengine/libraries/repository/M2RepositoryService.java

@@ -39,8 +39,8 @@
  * artifacts and store them in the local Maven repository pointed to by M2Eclipse's M2_REPO
  * variable.
  * <p>
- * In case <code>libraryfile.getSourceUri()</code> is null, M2Eclipse is used to resolve the source
- * artifact by using the "sources" classifier with the binary artifact's {@link MavenCoordinates}.;
+ * In case <code>libraryfile.getSourceUri()</code> is null, M2Eclipse resolves the source
+ * artifact by using the "sources" classifier with the binary artifact's {@link MavenCoordinates}.
  */
 @Component
 public class M2RepositoryService implements ILibraryRepositoryService {
@@ -92,7 +92,7 @@ private static IPath getDownloadedSourceLocation(MavenCoordinates mavenCoordinat
       IPath downloadFolder = MavenHelper.bundleStateBasedMavenFolder(mavenCoordinates);
       return new FileDownloader(downloadFolder).download(sourceUrl, monitor);
     } catch (IOException e) {
-      // source file is failed to download, this is not an error
+      // source file failed to download; this is not an error
       return null;
     }
   }

plugins/com.google.cloud.tools.eclipse.appengine.libraries/src/com/google/cloud/tools/eclipse/appengine/libraries/repository/MavenHelper.java

@@ -91,7 +91,8 @@ private ArtifactRepository getCustomRepository(String repository) throws CoreExc
    * @return the location of the download folder, may not exist
    */
   public static IPath bundleStateBasedMavenFolder(MavenCoordinates mavenCoordinates) {
-    Preconditions.checkArgument(!mavenCoordinates.getVersion().equals(MavenCoordinates.LATEST_VERSION));
+    Preconditions.checkArgument(
+        !mavenCoordinates.getVersion().equals(MavenCoordinates.LATEST_VERSION));
     File downloadedSources =
         Platform.getStateLocation(FrameworkUtil.getBundle(MavenHelper.class))
         .append("downloads")