test(storage): fix bucket lock system tests

Author: angelcaamal

storage/releaseEventBasedHold.js

@@ -25,7 +25,7 @@
 function main(
   bucketName = 'my-bucket',
   fileName = 'test.txt',
-  metagenerationMatchPrecondition = 0
+  metagenerationMatchPrecondition = null
 ) {
   // [START storage_release_event_based_hold]
   /**

storage/releaseTemporaryHold.js

@@ -25,7 +25,7 @@
 function main(
   bucketName = 'my-bucket',
   fileName = 'test.txt',
-  metagenerationMatchPrecondition = 0
+  metagenerationMatchPrecondition = null
 ) {
   // [START storage_release_temporary_hold]
   /**

storage/setEventBasedHold.js

@@ -25,7 +25,7 @@
 function main(
   bucketName = 'my-bucket',
   fileName = 'test.txt',
-  metagenerationMatchPrecondition = 0
+  metagenerationMatchPrecondition = null
 ) {
   // [START storage_set_event_based_hold]
   /**

storage/setTemporaryHold.js

@@ -25,7 +25,7 @@
 function main(
   bucketName = 'my-bucket',
   fileName = 'test.txt',
-  metagenerationMatchPrecondition = 0
+  metagenerationMatchPrecondition = null
 ) {
   // [START storage_set_temporary_hold]
   /**

storage/system-test/bucketLock.test.js

@@ -37,15 +37,20 @@ before(async () => {
 });
 
 after(async () => {
+  // The last test locks a retention policy. Wait for the retention
+  // period (5s) to pass before attempting to delete objects and the bucket.
+  // A small buffer is added to account for timing inaccuracies.
+  await new Promise(resolve => setTimeout(resolve, 6000));
+
   try {
     await bucket.deleteFiles({force: true});
   } catch (err) {
-    // ignore error
+    console.error('Failed to delete files during cleanup:', err);
   }
   try {
     await bucket.delete();
   } catch (err) {
-    // ignore error
+    console.error('Failed to delete bucket during cleanup:', err);
   }
 });