Skip to content

Commit f48aa10

Browse files
authored
fix(memorystore): Fix outdated nodejs example for Memorystore for Redis. (#4226)
1 parent 455d71e commit f48aa10

1 file changed

Lines changed: 27 additions & 15 deletions

File tree

memorystore/redis/server.js

Lines changed: 27 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -20,22 +20,34 @@ const redis = require('redis');
2020
const REDISHOST = process.env.REDISHOST || 'localhost';
2121
const REDISPORT = process.env.REDISPORT || 6379;
2222

23-
const client = redis.createClient(REDISPORT, REDISHOST);
23+
const client = redis.createClient({
24+
url: `redis://${REDISHOST}:${REDISPORT}`,
25+
});
26+
2427
client.on('error', err => console.error('ERR:REDIS:', err));
2528

26-
// create a server
27-
http
28-
.createServer((req, res) => {
29-
// increment the visit counter
30-
client.incr('visits', (err, reply) => {
31-
if (err) {
32-
console.log(err);
33-
res.status(500).send(err.message);
34-
return;
35-
}
36-
res.writeHead(200, {'Content-Type': 'text/plain'});
37-
res.end(`Visitor number: ${reply}\n`);
38-
});
29+
client
30+
.connect()
31+
.then(() => {
32+
console.log('Connected to Redis');
33+
http
34+
.createServer(async (req, res) => {
35+
try {
36+
const reply = await client.incr('visits');
37+
res.writeHead(200, {'Content-Type': 'text/plain'});
38+
res.end(`Visitor number: ${reply}\n`);
39+
} catch (err) {
40+
console.error(err);
41+
res.statusCode = 500;
42+
res.end(err.message);
43+
}
44+
})
45+
.listen(8080, () => {
46+
console.log('Server listening on port 8080');
47+
});
3948
})
40-
.listen(8080);
49+
.catch(err => {
50+
console.error('Failed to connect to Redis:', err);
51+
throw err;
52+
});
4153
// [END memorystore_server_js]

0 commit comments

Comments
 (0)