Fix stack trace if there are anonymous functions in stack trace (#24)

* Fix stack trace if there are anonymous functions in stack trace

* Add <anonymous> in stack trace if there is no functionName
* Add command using scripts in package.json
* Add tests
* Remove unused code in test.html
* Update version in package lock
* Update readme to include test instructions

* Fixing sugestions from CR

* Update test message
* Use explicite anonymous function in anonymous test case

Author: Jastrzebowski

README.md

@@ -217,10 +217,10 @@ import errorHandler from './errorHandlerUtility';
 
 ## Developing the library
 
-Install developer dependencies with `npm install --dev` and install `gulp` with `npm install -g gulp`
+Install developer dependencies with `npm install --dev`
 
-* Run `gulp` to test your changes.
-* Run `gulp dist` generates the minified version.
+* Run `npm test` or `yarn run test` to test your changes.
+* Run `npm run dist` or `yarn run dist` generates the minified version.
 
 Start a web server at the root of this repo and open `demo/demo.html` to test reporting errors from the local library with your API key and project ID.
 

package-lock.json

@@ -10,6 +10,12 @@
     "type": "git",
     "url": "https://github.com/GoogleCloudPlatform/stackdriver-errors-js"
   },
+  "scripts": {
+    "test": "gulp",
+    "dist": "gulp dist",
+    "lint": "gulp lint",
+    "start": "gulp min-demo"
+  },
   "keywords": [
     "stackdriver",
     "error",

package.json

@@ -112,7 +112,9 @@
         payload.message += '\n';
         // Reconstruct the stackframe to a JS stackframe as expected by Error Reporting parsers.
         // stack[s].source should not be used because not populated when created from source map.
-        payload.message += ['    at ', stack[s].getFunctionName(), ' (', stack[s].getFileName(), ':', stack[s].getLineNumber() ,':', stack[s].getColumnNumber() , ')'].join('');
+        // 
+        // If functionName or methodName isn't available <anonymous> will be used as the name.
+        payload.message += ['    at ', stack[s].getFunctionName() || '<anonymous>', ' (', stack[s].getFileName(), ':', stack[s].getLineNumber() ,':', stack[s].getColumnNumber() , ')'].join('');
       }
       that.sendErrorPayload(payload, callback);
     }, function(reason) {

stackdriver-errors.js

@@ -16,7 +16,6 @@
   <script src="../stackdriver-errors.js"></script>
   <script src="test.js"></script>
   <script>
-    //mocha.allowUncaught()
     mocha.run();
   </script>
 </body>

test/test.html

@@ -18,14 +18,23 @@ var expect = chai.expect;
 var errorHandler;
 var xhr, requests;
 
-/** Helper function testing if a given message has been reported */
+/** 
+ * Helper function testing if a given message has been reported
+ */
 function expectRequestWithMessage(message) {
   expect(requests.length).to.equal(1);
   var sentBody = JSON.parse(requests[0].requestBody);
   expect(sentBody).to.include.keys('message');
   expect(sentBody.message).to.contain(message);
 }
 
+/**
+ * Helper for testing call stack reporting
+ */
+function throwError(message) {
+  throw new TypeError(message);
+}
+
 beforeEach(function() {
   window.onerror= function(){};
 
@@ -119,6 +128,34 @@ describe('Reporting errors', function () {
     }
   });
 
+  it('should extract and send functionName in stack traces', function (done) {
+    var message = 'custom message';
+    // PhantomJS only attaches a stack to thrown errors
+    try {
+      throwError(message)
+    } catch(e) {
+      errorHandler.report(e, function() {
+        expectRequestWithMessage('throwError');
+        done();
+      });
+    }
+  });
+
+  it('should set in stack traces when frame is anonymous', function (done) {
+    var message = 'custom message';
+    // PhantomJS only attaches a stack to thrown errors
+    try {
+      (function () {
+        throw new TypeError(message);
+      })()
+    } catch(e) {
+      errorHandler.report(e, function() {
+        expectRequestWithMessage('<anonymous>');
+        done();
+      });
+    }
+  });
+
 });
 
 describe('Unhandled exceptions', function () {