Skip to content

Commit 9182fdf

Browse files
authored
Merge pull request #28 from GradleUp/duration
Use java.time.Duration
2 parents 349a664 + 5a85e0d commit 9182fdf

3 files changed

Lines changed: 11 additions & 5 deletions

File tree

src/main/kotlin/nmcp/NmcpAggregation.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ package nmcp
33
import org.gradle.api.Project
44
import org.gradle.api.artifacts.Configuration
55
import org.gradle.api.provider.Property
6+
import java.time.Duration
67
import javax.inject.Inject
78

89
abstract class NmcpAggregation @Inject constructor(
@@ -53,7 +54,7 @@ abstract class NmcpAggregation @Inject constructor(
5354
*
5455
* Default: 600 (10 minutes).
5556
*/
56-
abstract val verificationTimeout: Property<Int>
57+
abstract val verificationTimeout: Property<Duration>
5758

5859
fun project(path: String) {
5960
project.dependencies.add(configuration.name, project.dependencies.project(mapOf("path" to path)))

src/main/kotlin/nmcp/NmcpPublishTask.kt

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,12 @@ import org.gradle.api.file.RegularFileProperty
1616
import org.gradle.api.provider.Property
1717
import org.gradle.api.tasks.*
1818
import org.gradle.work.DisableCachingByDefault
19+
import java.time.Duration
20+
import kotlin.time.Duration.Companion.minutes
1921
import kotlin.time.Duration.Companion.seconds
2022
import kotlin.time.TimeSource.Monotonic.markNow
23+
import kotlin.time.toJavaDuration
24+
import kotlin.time.toKotlinDuration
2125

2226

2327
@DisableCachingByDefault
@@ -38,7 +42,7 @@ abstract class NmcpPublishTask : DefaultTask() {
3842

3943
@get:Input
4044
@get:Optional
41-
abstract val verificationTimeout: Property<Int>
45+
abstract val verificationTimeout: Property<Duration>
4246

4347
@get:Input
4448
@get:Optional
@@ -98,10 +102,10 @@ abstract class NmcpPublishTask : DefaultTask() {
98102

99103
if (verifyStatus.orElse(true).get()) {
100104
logger.lifecycle("Nmcp: verifying deployment status...")
101-
val timeout = verificationTimeout.orElse(600).get().seconds
105+
val timeout = verificationTimeout.orElse(10.minutes.toJavaDuration()).get()
102106
val mark = markNow()
103107
while (true) {
104-
check (mark.elapsedNow() < timeout) {
108+
check (mark.elapsedNow() < timeout.toKotlinDuration()) {
105109
"Nmcp: timeout while verifying deployment status."
106110
}
107111
when (val status = verifyStatus(

src/main/kotlin/nmcp/NmcpSpec.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package nmcp
22

33
import org.gradle.api.provider.Property
4+
import java.time.Duration
45

56
abstract class NmcpSpec {
67
/**
@@ -47,5 +48,5 @@ abstract class NmcpSpec {
4748
*
4849
* Default: 600 (10 minutes).
4950
*/
50-
abstract val verificationTimeout: Property<Int>
51+
abstract val verificationTimeout: Property<Duration>
5152
}

0 commit comments

Comments
 (0)