Address review comments

Author: TrueDoctor

editor/src/messages/layout/utility_types/widgets/input_widgets.rs

@@ -79,7 +79,7 @@ impl<'a> serde::Deserialize<'a> for CheckboxId {
 		D: serde::Deserializer<'a>,
 	{
 		let optional_id: Option<u64> = Option::deserialize(deserializer)?;
-		// let id = u64::deserialize(deserializer)?;
+		// TODO: This is potentially weird because after deserialization the two labels will be decoupled if the value not existent
 		let id = optional_id.unwrap_or(0);
 		let checkbox_id = CheckboxId(OnceCell::new().into());
 		checkbox_id.0.set(id).map_err(serde::de::Error::custom)?;

node-graph/gapplication-io/src/lib.rs

@@ -49,12 +49,10 @@ impl Size for web_sys::HtmlCanvasElement {
 	}
 }
 
-#[derive(Debug, Clone, serde::Serialize)]
+#[derive(Debug, Clone)]
 pub struct ImageTexture {
-	#[serde(skip)]
 	#[cfg(feature = "wgpu")]
 	pub texture: Arc<wgpu::Texture>,
-	#[serde(skip)]
 	#[cfg(not(feature = "wgpu"))]
 	pub texture: (),
 }

node-graph/graph-craft/src/document/value.rs

@@ -429,8 +429,12 @@ pub struct RenderOutput {
 #[derive(Debug, Clone, Hash, PartialEq, dyn_any::DynAny, serde::Serialize, serde::Deserialize)]
 pub enum RenderOutputType {
 	CanvasFrame(SurfaceFrame),
+	#[serde(skip)]
 	Texture(ImageTexture),
-	Svg { svg: String, image_data: Vec<(u64, Image<Color>)> },
+	Svg {
+		svg: String,
+		image_data: Vec<(u64, Image<Color>)>,
+	},
 	Image(Vec<u8>),
 }
 

node-graph/graph-craft/src/wasm_application_io.rs

@@ -137,7 +137,6 @@ impl WasmApplicationIo {
 		let wgpu_available = executor.is_some();
 		WGPU_AVAILABLE.store(wgpu_available as i8, Ordering::SeqCst);
 
-		// Always enable wgpu when running with Tauri
 		let mut io = Self {
 			#[cfg(target_arch = "wasm32")]
 			ids: AtomicU64::new(0),
@@ -162,11 +161,7 @@ impl WasmApplicationIo {
 		let wgpu_available = executor.is_some();
 		WGPU_AVAILABLE.store(wgpu_available as i8, Ordering::SeqCst);
 
-		// Always enable wgpu when running with Tauri
 		let mut io = Self {
-			#[cfg(target_arch = "wasm32")]
-			ids: AtomicU64::new(0),
-			#[cfg(feature = "wgpu")]
 			gpu_executor: executor,
 			windows: Vec::new(),
 			resources: HashMap::new(),

node-graph/wgpu-executor/src/lib.rs

@@ -238,7 +238,6 @@ impl WgpuExecutor {
 		let vello_renderer = Renderer::new(
 			&context.device,
 			RendererOptions {
-				// surface_format: Some(wgpu::TextureFormat::Rgba8Unorm),
 				pipeline_cache: None,
 				use_cpu: false,
 				antialiasing_support: AaSupport::all(),