Skip to content

Commit 7e3ab78

Browse files
committed
Fix more flaws with 'Transform' node rad-to-deg migration; make 'Tangent on Path' also use degrees by default
1 parent 3fe7c47 commit 7e3ab78

12 files changed

Lines changed: 69 additions & 46 deletions

demo-artwork/changing-seasons.graphite

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

demo-artwork/isometric-fountain.graphite

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

demo-artwork/marbled-mandelbrot.graphite

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

demo-artwork/painted-dreams.graphite

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

demo-artwork/parametric-dunescape.graphite

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

demo-artwork/procedural-string-lights.graphite

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

demo-artwork/red-dress.graphite

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

demo-artwork/valley-of-spires.graphite

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

editor/src/messages/portfolio/document/node_graph/document_node_definitions.rs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1341,6 +1341,13 @@ fn static_nodes() -> Vec<DocumentNodeDefinition> {
13411341
persistent_metadata: DocumentNodePersistentMetadata {
13421342
display_name: "Transform".to_string(),
13431343
node_type_metadata: NodeTypePersistentMetadata::node(IVec2::new(7, 0)),
1344+
input_metadata: vec![
1345+
("Value", "TODO").into(),
1346+
("Translation", "TODO").into(),
1347+
("Rotation", "TODO").into(),
1348+
("Scale", "TODO").into(),
1349+
("Skew", "TODO").into(),
1350+
],
13441351
..Default::default()
13451352
},
13461353
..Default::default()

editor/src/messages/portfolio/document/utility_types/network_interface.rs

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1002,10 +1002,7 @@ impl NodeNetworkInterface {
10021002
.outward_wires(network_path)
10031003
.and_then(|outward_wires| outward_wires.get(output_connector))
10041004
.cloned()
1005-
.unwrap_or_else(|| {
1006-
log::error!("Could not get {output_connector:?} in outward wires");
1007-
Vec::new()
1008-
})
1005+
.unwrap_or_default()
10091006
.iter()
10101007
.map(|input| match input {
10111008
InputConnector::Node { node_id, input_index } => {
@@ -6470,7 +6467,7 @@ pub struct NodeNetworkTransientMetadata {
64706467
pub stack_dependents: TransientMetadata<HashMap<NodeId, LayerOwner>>,
64716468
/// Cache for the bounding box around all nodes in node graph space.
64726469
pub all_nodes_bounding_box: TransientMetadata<[DVec2; 2]>,
6473-
/// Cache bounding box for all "groups of nodes", which will be used to prevent overlapping nodes
6470+
// /// Cache bounding box for all "groups of nodes", which will be used to prevent overlapping nodes
64746471
// node_group_bounding_box: Vec<(Subpath<ManipulatorGroupId>, Vec<Nodes>)>,
64756472
/// Cache for all outward wire connections
64766473
pub outward_wires: TransientMetadata<HashMap<OutputConnector, Vec<InputConnector>>>,

0 commit comments

Comments
 (0)