Skip to content

Commit a5bb7bd

Browse files
review fixup
1 parent c2365d4 commit a5bb7bd

2 files changed

Lines changed: 1 addition & 3 deletions

File tree

frontend/src/utility-functions/viewports.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,9 @@ export function setupViewportResizeObserver(editor: Editor) {
3939
// Get viewport position
4040
const bounds = entry.target.getBoundingClientRect();
4141

42+
// TODO: Consider passing physical sizes as well to eliminate pixel inaccuracies since width and height could be rounded differently
4243
const scale = physicalWidth / logicalWidth;
4344

44-
// Logical dimensions are used for CSS/SVG sizing, physical for GPU textures
45-
// TODO: Consider passing physical sizes as well to eliminate pixel inaccuracies since width and height could be rounded differently
4645
editor.handle.updateViewport(bounds.x, bounds.y, logicalWidth, logicalHeight, scale);
4746
}
4847
});

node-graph/nodes/gstd/src/render_node.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,6 @@ async fn render<'a: 'n>(ctx: impl Ctx + ExtractFootprint + ExtractVarArgs, edito
192192
background = Color::WHITE;
193193
}
194194

195-
// Always render to texture (unified path for both WASM and desktop)
196195
let texture = exec
197196
.render_vello_scene_to_texture(&scene, physical_resolution, context, background)
198197
.await

0 commit comments

Comments
 (0)