Return crash during migration

Author: Keavon

editor/src/messages/portfolio/document_migration.rs

@@ -1634,18 +1634,18 @@ fn migrate_node(node_id: &NodeId, node: &DocumentNode, network_path: &[NodeId],
 
 	// TODO: Also add this for "Animation Time"
 
-	// // Upgrade the "Instance Position" node to add the "Loop Level" input
-	// if reference == DefinitionIdentifier::ProtoNode(graphene_std::vector_nodes::instance::instance_position::IDENTIFIER) && inputs_count < 2 {
-	// 	let mut node_template = resolve_document_node_type(&reference)?.default_node_template();
-	// 	document.network_interface.replace_implementation(node_id, network_path, &mut node_template);
-
-	// 	document
-	// 		.network_interface
-	// 		.set_input(&InputConnector::node(*node_id, 0), NodeInput::value(TaggedValue::None, false), network_path);
-	// 	document
-	// 		.network_interface
-	// 		.set_input(&InputConnector::node(*node_id, 1), NodeInput::value(TaggedValue::U32(0), false), network_path);
-	// }
+	// Upgrade the "Instance Position" node to add the "Loop Level" input
+	if reference == DefinitionIdentifier::ProtoNode(graphene_std::vector_nodes::instance::instance_position::IDENTIFIER) && inputs_count < 2 {
+		let mut node_template = resolve_document_node_type(&reference)?.default_node_template();
+		document.network_interface.replace_implementation(node_id, network_path, &mut node_template);
+
+		document
+			.network_interface
+			.set_input(&InputConnector::node(*node_id, 0), NodeInput::value(TaggedValue::None, false), network_path);
+		document
+			.network_interface
+			.set_input(&InputConnector::node(*node_id, 1), NodeInput::value(TaggedValue::U32(0), false), network_path);
+	}
 
 	// Migrate from the old source/target "Morph" node to the new vector table based "Morph" node.
 	// This doesn't produce exactly equivalent results in cases involving input vector tables with multiple rows.

node-graph/nodes/vector/src/instance.rs

@@ -84,11 +84,18 @@ async fn instance_repeat<T: Into<Graphic> + Default + Send + Clone + 'static>(
 }
 
 #[node_macro::node(category("Instancing"), path(core_types::vector))]
-async fn instance_position(ctx: impl Ctx + ExtractPosition) -> DVec2 {
+async fn instance_position(
+	ctx: impl Ctx + ExtractPosition,
+	_primary: (),
+	/// The number of nested loops to traverse outwards (from the innermost loop) to get the position from. The most upstream loop is level 0, and downstream loops add levels.
+	///
+	/// In programming terms: inside the double loop `i { j { ... } }`, *Loop Level* 0 = `j` and 1 = `i`. After inserting a third loop `k { ... }`, inside it, levels would be 0 = `k`, 1 = `j`, and 2 = `i`.
+	loop_level: u32,
+) -> DVec2 {
 	let Some(position_iter) = ctx.try_position() else { return DVec2::ZERO };
 	let mut last = DVec2::ZERO;
 	for (i, position) in position_iter.enumerate() {
-		if i == 0 as usize {
+		if i == loop_level as usize {
 			return position;
 		}
 		last = position;