Skip to content

Commit ad46341

Browse files
timon-schellingtimon-schelling
committed
Use copy instead of cloning
1 parent a478d83 commit ad46341

6 files changed

Lines changed: 21 additions & 21 deletions

File tree

‎editor/src/messages/dialog/export_dialog/export_dialog_message_handler.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ impl LayoutHolder for ExportDialogMessageHandler {
147147

148148
let checkbox_id = CheckboxId::new();
149149
let transparent_background = vec![
150-
TextLabel::new("Transparency").table_align(true).min_width(100).for_checkbox(checkbox_id.clone()).widget_holder(),
150+
TextLabel::new("Transparency").table_align(true).min_width(100).for_checkbox(checkbox_id).widget_holder(),
151151
Separator::new(SeparatorType::Unrelated).widget_holder(),
152152
CheckboxInput::new(self.transparent_background)
153153
.disabled(self.file_type == FileType::Jpg)

‎editor/src/messages/dialog/new_document_dialog/new_document_dialog_message_handler.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ impl LayoutHolder for NewDocumentDialogMessageHandler {
8282

8383
let checkbox_id = CheckboxId::new();
8484
let infinite = vec![
85-
TextLabel::new("Infinite Canvas").table_align(true).min_width(90).for_checkbox(checkbox_id.clone()).widget_holder(),
85+
TextLabel::new("Infinite Canvas").table_align(true).min_width(90).for_checkbox(checkbox_id).widget_holder(),
8686
Separator::new(SeparatorType::Unrelated).widget_holder(),
8787
CheckboxInput::new(self.infinite)
8888
.on_update(|checkbox_input: &CheckboxInput| NewDocumentDialogMessage::Infinite(checkbox_input.checked).into())

‎editor/src/messages/dialog/preferences_dialog/preferences_dialog_message_handler.rs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ impl PreferencesDialogMessageHandler {
8181
}
8282
.into()
8383
})
84-
.for_label(checkbox_id.clone())
84+
.for_label(checkbox_id)
8585
.widget_holder(),
8686
TextLabel::new("Zoom with Scroll")
8787
.table_align(true)
@@ -178,7 +178,7 @@ impl PreferencesDialogMessageHandler {
178178
.tooltip(vello_tooltip)
179179
.disabled(!preferences.supports_wgpu())
180180
.on_update(|checkbox_input: &CheckboxInput| PreferencesMessage::UseVello { use_vello: checkbox_input.checked }.into())
181-
.for_label(checkbox_id.clone())
181+
.for_label(checkbox_id)
182182
.widget_holder(),
183183
TextLabel::new("Vello Renderer")
184184
.table_align(true)
@@ -197,7 +197,7 @@ impl PreferencesDialogMessageHandler {
197197
CheckboxInput::new(preferences.vector_meshes)
198198
.tooltip(vector_mesh_tooltip)
199199
.on_update(|checkbox_input: &CheckboxInput| PreferencesMessage::VectorMeshes { enabled: checkbox_input.checked }.into())
200-
.for_label(checkbox_id.clone())
200+
.for_label(checkbox_id)
201201
.widget_holder(),
202202
TextLabel::new("Vector Meshes").table_align(true).tooltip(vector_mesh_tooltip).for_checkbox(checkbox_id).widget_holder(),
203203
];

‎editor/src/messages/layout/utility_types/widgets/input_widgets.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ impl Default for CheckboxInput {
4949
}
5050
}
5151

52-
#[derive(Clone, Debug, Eq, PartialEq, serde::Serialize, serde::Deserialize)]
52+
#[derive(Copy, Clone, Debug, Eq, PartialEq, serde::Serialize, serde::Deserialize)]
5353
pub struct CheckboxId(u64);
5454

5555
impl CheckboxId {

‎editor/src/messages/portfolio/document/document_message_handler.rs‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2171,7 +2171,7 @@ impl DocumentMessageHandler {
21712171
}
21722172
.into()
21732173
})
2174-
.for_label(checkbox_id.clone())
2174+
.for_label(checkbox_id)
21752175
.widget_holder(),
21762176
TextLabel::new("Artboard Name".to_string()).for_checkbox(checkbox_id).widget_holder(),
21772177
]
@@ -2189,7 +2189,7 @@ impl DocumentMessageHandler {
21892189
}
21902190
.into()
21912191
})
2192-
.for_label(checkbox_id.clone())
2192+
.for_label(checkbox_id)
21932193
.widget_holder(),
21942194
TextLabel::new("G/R/S Measurement".to_string()).for_checkbox(checkbox_id).widget_holder(),
21952195
]
@@ -2210,7 +2210,7 @@ impl DocumentMessageHandler {
22102210
}
22112211
.into()
22122212
})
2213-
.for_label(checkbox_id.clone())
2213+
.for_label(checkbox_id)
22142214
.widget_holder(),
22152215
TextLabel::new("Quick Measurement".to_string()).for_checkbox(checkbox_id).widget_holder(),
22162216
]
@@ -2228,7 +2228,7 @@ impl DocumentMessageHandler {
22282228
}
22292229
.into()
22302230
})
2231-
.for_label(checkbox_id.clone())
2231+
.for_label(checkbox_id)
22322232
.widget_holder(),
22332233
TextLabel::new("Transform Cage".to_string()).for_checkbox(checkbox_id).widget_holder(),
22342234
]
@@ -2246,7 +2246,7 @@ impl DocumentMessageHandler {
22462246
}
22472247
.into()
22482248
})
2249-
.for_label(checkbox_id.clone())
2249+
.for_label(checkbox_id)
22502250
.widget_holder(),
22512251
TextLabel::new("Transform Dial".to_string()).for_checkbox(checkbox_id).widget_holder(),
22522252
]
@@ -2264,7 +2264,7 @@ impl DocumentMessageHandler {
22642264
}
22652265
.into()
22662266
})
2267-
.for_label(checkbox_id.clone())
2267+
.for_label(checkbox_id)
22682268
.widget_holder(),
22692269
TextLabel::new("Transform Pivot".to_string()).for_checkbox(checkbox_id).widget_holder(),
22702270
]
@@ -2282,7 +2282,7 @@ impl DocumentMessageHandler {
22822282
}
22832283
.into()
22842284
})
2285-
.for_label(checkbox_id.clone())
2285+
.for_label(checkbox_id)
22862286
.widget_holder(),
22872287
TextLabel::new("Transform Origin".to_string()).for_checkbox(checkbox_id).widget_holder(),
22882288
]
@@ -2300,7 +2300,7 @@ impl DocumentMessageHandler {
23002300
}
23012301
.into()
23022302
})
2303-
.for_label(checkbox_id.clone())
2303+
.for_label(checkbox_id)
23042304
.widget_holder(),
23052305
TextLabel::new("Hover Outline".to_string()).for_checkbox(checkbox_id).widget_holder(),
23062306
]
@@ -2318,7 +2318,7 @@ impl DocumentMessageHandler {
23182318
}
23192319
.into()
23202320
})
2321-
.for_label(checkbox_id.clone())
2321+
.for_label(checkbox_id)
23222322
.widget_holder(),
23232323
TextLabel::new("Selection Outline".to_string()).for_checkbox(checkbox_id).widget_holder(),
23242324
]
@@ -2339,7 +2339,7 @@ impl DocumentMessageHandler {
23392339
}
23402340
.into()
23412341
})
2342-
.for_label(checkbox_id.clone())
2342+
.for_label(checkbox_id)
23432343
.widget_holder(),
23442344
TextLabel::new("Path".to_string()).for_checkbox(checkbox_id).widget_holder(),
23452345
]
@@ -2357,7 +2357,7 @@ impl DocumentMessageHandler {
23572357
}
23582358
.into()
23592359
})
2360-
.for_label(checkbox_id.clone())
2360+
.for_label(checkbox_id)
23612361
.widget_holder(),
23622362
TextLabel::new("Anchors".to_string()).for_checkbox(checkbox_id).widget_holder(),
23632363
]
@@ -2376,7 +2376,7 @@ impl DocumentMessageHandler {
23762376
}
23772377
.into()
23782378
})
2379-
.for_label(checkbox_id.clone())
2379+
.for_label(checkbox_id)
23802380
.widget_holder(),
23812381
TextLabel::new("Handles".to_string())
23822382
.disabled(!self.overlays_visibility_settings.anchors)
@@ -2424,7 +2424,7 @@ impl DocumentMessageHandler {
24242424
.into()
24252425
})
24262426
.tooltip(tooltip)
2427-
.for_label(checkbox_id.clone())
2427+
.for_label(checkbox_id)
24282428
.widget_holder(),
24292429
TextLabel::new(name).tooltip(tooltip).for_checkbox(checkbox_id).widget_holder(),
24302430
]
@@ -2446,7 +2446,7 @@ impl DocumentMessageHandler {
24462446
.into()
24472447
})
24482448
.tooltip(tooltip)
2449-
.for_label(checkbox_id.clone())
2449+
.for_label(checkbox_id)
24502450
.widget_holder(),
24512451
TextLabel::new(name).tooltip(tooltip).for_checkbox(checkbox_id).widget_holder(),
24522452
]

‎editor/src/messages/tool/tool_messages/path_tool.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ impl LayoutHolder for PathTool {
247247
}
248248
})
249249
.tooltip(colinear_handles_tooltip)
250-
.for_label(checkbox_id.clone())
250+
.for_label(checkbox_id)
251251
.widget_holder();
252252
let colinear_handles_label = TextLabel::new("Colinear Handles")
253253
.disabled(!self.tool_data.can_toggle_colinearity)

0 commit comments

Comments
 (0)