More fixes

Author: Keavon

editor/src/messages/portfolio/document_migration.rs

@@ -1632,6 +1632,20 @@ fn migrate_node(node_id: &NodeId, node: &DocumentNode, network_path: &[NodeId],
 		}
 	}
 
+	// TODO: Also add this for "Animation Time"
+	// Upgrade the "Instance Position" node to add the "Loop Level" input
+	if reference == DefinitionIdentifier::ProtoNode(graphene_std::vector_nodes::instance::instance_position::IDENTIFIER) && inputs_count < 2 {
+		let mut node_template = resolve_document_node_type(&reference)?.default_node_template();
+		document.network_interface.replace_implementation(node_id, network_path, &mut node_template);
+
+		document
+			.network_interface
+			.set_input(&InputConnector::node(*node_id, 0), NodeInput::value(TaggedValue::None, false), network_path);
+		document
+			.network_interface
+			.set_input(&InputConnector::node(*node_id, 1), NodeInput::value(TaggedValue::U32(0), false), network_path);
+	}
+
 	// Migrate from the old source/target "Morph" node to the new vector table based "Morph" node.
 	// This doesn't produce exactly equivalent results in cases involving input vector tables with multiple rows.
 	// The old version would zip the source and target table rows, interpoleating each pair together.

frontend/src/state-providers/tooltip.ts

@@ -40,6 +40,9 @@ export function createTooltipState(editor: Editor) {
 		// Before we schedule a new future tooltip appearance, we clear the existing one
 		if (tooltipTimeout) clearTimeout(tooltipTimeout);
 
+		// Don't show tooltips while mouse buttons are pressed
+		if (e.buttons !== 0) return;
+
 		// Schedule the tooltip to appear at this cursor position after a delay
 		tooltipTimeout = setTimeout(() => {
 			update((state) => {

node-graph/nodes/vector/src/instance.rs

@@ -7,17 +7,6 @@ use graphic_types::Vector;
 use graphic_types::raster_types::{CPU, Raster};
 use vector_types::GradientStops;
 
-#[repr(transparent)]
-#[derive(dyn_any::DynAny)]
-struct HashableDVec2(DVec2);
-
-impl std::hash::Hash for HashableDVec2 {
-	fn hash<H: std::hash::Hasher>(&self, state: &mut H) {
-		self.0.x.to_bits().hash(state);
-		self.0.y.to_bits().hash(state);
-	}
-}
-
 #[node_macro::node(name("Instance on Points"), category("Instancing"), path(core_types::vector))]
 async fn instance_on_points<T: Into<Graphic> + Default + Send + Clone + 'static>(
 	ctx: impl ExtractAll + CloneVarArgs + Sync + Ctx + InjectVarArgs,
@@ -38,7 +27,7 @@ async fn instance_on_points<T: Into<Graphic> + Default + Send + Clone + 'static>
 		let mut iteration = async |index, point| {
 			let transformed_point = transform.transform_point2(point);
 
-			let new_ctx = OwnedContextImpl::from(ctx.clone()).with_index(index).with_vararg(Box::new(HashableDVec2(transformed_point)));
+			let new_ctx = OwnedContextImpl::from(ctx.clone()).with_index(index).with_position(transformed_point);
 			let generated_instance = instance.eval(new_ctx.into_context()).await;
 
 			for mut generated_row in generated_instance.into_iter() {
@@ -168,7 +157,7 @@ mod test {
 		let owned = OwnedContextImpl::default().into_context();
 		let rect = RectangleNode::new(
 			FutureWrapperNode(()),
-			ExtractXyNode::new(InstancePositionNode {}, FutureWrapperNode(XY::Y)),
+			ExtractXyNode::new(InstancePositionNode((), 0), FutureWrapperNode(XY::Y)),
 			FutureWrapperNode(2_f64),
 			FutureWrapperNode(false),
 			FutureWrapperNode(0_f64),

node-graph/nodes/vector/src/vector_modification_nodes.rs

@@ -36,6 +36,7 @@ async fn apply_transform(_ctx: impl Ctx, mut vector: Table<Vector>) -> Table<Vec
 		for (_, point) in vector.point_domain.positions_mut() {
 			*point = transform.transform_point2(*point);
 		}
+		vector.segment_domain.transform(transform);
 
 		*row.transform = DAffine2::IDENTITY;
 	}