reworked idle logic

avoid iterating the input slots again.

Author: PrototypeTrousers

src/main/java/gregtech/api/capability/impl/AbstractRecipeLogic.java

@@ -51,6 +51,7 @@ public abstract class AbstractRecipeLogic extends MTETrait implements IWorkable
     protected boolean workingEnabled = true;
     protected boolean hasNotEnoughEnergy;
     protected boolean wasActiveAndNeedsUpdate;
+    protected boolean isInputsEmpty;
 
     public AbstractRecipeLogic(MetaTileEntity tileEntity, RecipeMap<?> recipeMap) {
         super(tileEntity);
@@ -111,10 +112,11 @@ public void update() {
                 if (progressTime == 0) {
                     trySearchNewRecipe();
                     if (currentRecipe == null) {
-                        metaTileEntity.setSituation(NO_MATCHING_RECIPE);
-                    }
-                    if (metaTileEntity.isInputEmpty()) {
-                        metaTileEntity.setSituation(IDLE);
+                        if (isInputsEmpty) {
+                            metaTileEntity.setSituation(IDLE);
+                        } else {
+                            metaTileEntity.setSituation(NO_MATCHING_RECIPE);
+                        }
                     }
                 }
             } else {
@@ -195,6 +197,7 @@ protected Recipe findRecipe(long maxVoltage, IItemHandlerModifiable inputs, IMul
 
     protected boolean checkRecipeInputsDirty(IItemHandler inputs, IMultipleTankHandler fluidInputs) {
         boolean shouldRecheckRecipe = false;
+        this.isInputsEmpty = true;
         if (lastItemInputs == null || lastItemInputs.length != inputs.getSlots()) {
             this.lastItemInputs = new ItemStack[inputs.getSlots()];
             Arrays.fill(lastItemInputs, ItemStack.EMPTY);
@@ -211,6 +214,8 @@ protected boolean checkRecipeInputsDirty(IItemHandler inputs, IMultipleTankHandl
             } else if (currentStack.getCount() != lastStack.getCount()) {
                 lastStack.setCount(currentStack.getCount());
                 shouldRecheckRecipe = true;
+            } else if (!currentStack.isEmpty()) {
+                this.isInputsEmpty = false;
             }
         }
         for (int i = 0; i < lastFluidInputs.length; i++) {
@@ -224,6 +229,8 @@ protected boolean checkRecipeInputsDirty(IItemHandler inputs, IMultipleTankHandl
                 currentStack.amount != lastStack.amount) {
                 lastStack.amount = currentStack.amount;
                 shouldRecheckRecipe = true;
+            } else if (currentStack != null) {
+                this.isInputsEmpty = false;
             }
         }
         return shouldRecheckRecipe;

src/main/java/gregtech/api/metatileentity/MetaTileEntity.java

@@ -992,24 +992,6 @@ public static boolean addFluidsToFluidHandler(IFluidHandler handler, boolean sim
         return filledAll;
     }
 
-    public boolean isInputEmpty() {
-        if (importItems.getSlots() > 0) {
-            for (int i = 0; i < importItems.getSlots(); i++) {
-                if (!importItems.getStackInSlot(i).isEmpty()) {
-                    return false;
-                }
-            }
-        }
-        if (importFluids.getTanks() > 0) {
-            for (int i = 0; i < importFluids.getTanks(); i++) {
-                if (importFluids.getTankAt(i).getFluid() != null) {
-                    return false;
-                }
-            }
-        }
-        return true;
-    }
-
     public final int getOutputRedstoneSignal(@Nullable EnumFacing side) {
         if (side == null) {
             return getHighestOutputRedstoneSignal();