fix: allow type to be omitted when semver is passed

Author: Grohden

README.md

@@ -50,7 +50,7 @@ Just ask for help:
 npx react-native bump-version --help
 
 Options:
-  --type [major|minor|patch]           SemVer release type, optional if --skip-semver-for all is passed
+  --type [major|minor|patch]           SemVer release type, optional if --skip-semver-for all is passed, ignored (and optional) when --semver is passed
   --skip-semver-for [android|ios|all]  Skips bump SemVer for specified platform
   --skip-code-for [android|ios|all]    Skips bump version codes for specified platform
   --semver                             Pass release version if known. Overwrites calculated SemVer. Optional.

react-native.config.js

@@ -7,14 +7,15 @@ module.exports = {
         func: (_, config, args) => {
             const result = versioner(config, args);
 
-            if(result) {
+            if (result) {
                 result.run();
             }
         },
         options: [
             {
                 name: "--type [major|minor|patch]",
-                description: "SemVer release type, optional if --skip-semver-for all is passed, ignored (and optional) when --semver is passed",
+                description:
+                    "SemVer release type, optional if --skip-semver-for all is passed, ignored (and optional) when --semver is passed",
             },
             {
                 name: "--semver [String]",

src/index.ts

@@ -302,8 +302,8 @@ class ProjectFilesManager {
         }
 
         if (!skipSemVerFor.includes("all")) {
-            if (!type) {
-                throw new Error("SemVer type not specified");
+            if (!type && !semver) {
+                throw new Error("bump type and semver value not specified");
             }
 
             this.syncSemver(next);

tests/__snapshots__/android.test.js.snap

@@ -16,6 +16,22 @@ Object {
 }
 `;
 
+exports[`direct set semver string and ignores non defined type 1`] = `
+"android {
+    defaultConfig {
+        versionCode 2
+        versionName \\"1.1.2\\"
+    }
+}
+"
+`;
+
+exports[`direct set semver string and ignores non defined type 2`] = `
+Object {
+  "version": "1.1.2",
+}
+`;
+
 exports[`preserve quotes style 1`] = `
 "android {
     defaultConfig {

tests/android.test.js

@@ -47,3 +47,10 @@ test("direct set semver string", () => {
     expect(manager.buildGradle.content).toMatchSnapshot();
     expect(manager.packageJSON.content).toMatchSnapshot();
 });
+
+test("direct set semver string and ignores non defined type", () => {
+    const manager = makeDefaultManager({ semver: "1.1.2", type: null }).dryRun();
+
+    expect(manager.buildGradle.content).toMatchSnapshot();
+    expect(manager.packageJSON.content).toMatchSnapshot();
+});