lint

Author: GrosSacASac

js/network/socketiyo/package.json

@@ -7,8 +7,8 @@
   "type": "module",
   "main": "./source/socketiyo.js",
   "scripts": {
-    "lint-fix": "eslint --ignore-path .gitignore --fix source",
-    "lint": "eslint --ignore-path .gitignore source"
+    "lint-fix": "eslint --ignore-path ../../../.gitignore --fix source",
+    "lint": "eslint --ignore-path ../../../.gitignore source"
   },
   "dependencies": {
     "event-e3": "^8.0.2",

js/network/socketiyo/source/socketiyo.js

@@ -158,31 +158,31 @@ const attachWebSocketServer = (options) => {
     };
 
     const listen = (socket, message) => {
-        let error = validateLength(message, maxLength);
-        if (error) {
-            facade.emit(VALIDATE_MESSAGE_ERROR, error);
+        const validationError = validateLength(message, maxLength);
+        if (validationError) {
+            facade.emit(VALIDATE_MESSAGE_ERROR, validationError);
             return;
         }
 
         let parsed;
         try {
             parsed = unpackData(message);
-        } catch (error) {
-            facade.emit(MESSAGE_FORMAT_ERROR, { error, message });
+        } catch (parseError) {
+            facade.emit(MESSAGE_FORMAT_ERROR, { error: parseError, message });
             return;
         }
 
-        error = validateFormat(parsed);
-        if (error) {
-            facade.emit(MESSAGE_FORMAT_ERROR, { error, parsed });
+        const formatError = validateFormat(parsed);
+        if (formatError) {
+            facade.emit(MESSAGE_FORMAT_ERROR, { error: formatError, parsed });
             return;
         }
 
         const { channel, data, action } = parsed;
 
-        error = validateChannel(channel, maxChannelLength);
-        if (error) {
-            facade.emit(VALIDATE_CHANNEL_ERROR, error);
+        const validChannelError = validateChannel(channel, maxChannelLength);
+        if (validChannelError) {
+            facade.emit(VALIDATE_CHANNEL_ERROR, validChannelError);
             return;
         }
         if (action === SUBSCRIBE_CHANNEL_ACTION) {

js/network/socketiyo/source/validate.js

@@ -6,14 +6,14 @@ import { bytesLengthFromString } from "utilsac";
 
 const validateFormat = parsedMessage => {
     if (!isObject(parsedMessage)) {
-        return 'message should be an object';
+        return `message should be an object`;
     }
     if (!Object.prototype.hasOwnProperty.call(parsedMessage, `channel`)) {
-        return 'message should have a channel';
+        return `message should have a channel`;
     }
     if (!Object.prototype.hasOwnProperty.call(parsedMessage, `data`) &&
         !Object.prototype.hasOwnProperty.call(parsedMessage, `action`)) {
-        return 'message should have data or action';
+        return `message should have data or action`;
     }
 };