Skip to content

Commit 879f1ac

Browse files
author
Hanseter
committed
Introduce workaround for bug in controlsfx
1 parent 9ef979c commit 879f1ac

2 files changed

Lines changed: 11 additions & 12 deletions

File tree

pom.xml

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<modelVersion>4.0.0</modelVersion>
77
<groupId>com.github.hanseter</groupId>
88
<artifactId>json-properties-fx</artifactId>
9-
<version>2.0.0</version>
9+
<version>1.0.17</version>
1010

1111
<packaging>bundle</packaging>
1212
<name>JSON Properties Editor Fx</name>
@@ -35,12 +35,12 @@
3535

3636

3737
<properties>
38-
<maven.compiler.source>21</maven.compiler.source>
39-
<maven.compiler.target>21</maven.compiler.target>
40-
<kotlin.compiler.jvmTarget>21</kotlin.compiler.jvmTarget>
38+
<maven.compiler.source>17</maven.compiler.source>
39+
<maven.compiler.target>17</maven.compiler.target>
40+
<kotlin.compiler.jvmTarget>17</kotlin.compiler.jvmTarget>
4141
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
42-
<kotlin.version>2.0.10</kotlin.version>
43-
<javafx.version>21.0.4</javafx.version>
42+
<kotlin.version>1.9.20</kotlin.version>
43+
<javafx.version>17.0.12</javafx.version>
4444
<slf4j.version>1.7.32</slf4j.version>
4545
</properties>
4646

@@ -192,12 +192,7 @@
192192
<version>${slf4j.version}</version>
193193
<scope>test</scope>
194194
</dependency>
195-
<dependency>
196-
<groupId>org.testfx</groupId>
197-
<artifactId>openjfx-monocle</artifactId>
198-
<version>21.0.2</version>
199-
<scope>test</scope>
200-
</dependency>
195+
201196
</dependencies>
202197

203198
</project>

src/main/kotlin/com/github/hanseter/json/editor/controls/EnumSetControl.kt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,10 @@ class EnumSetControl(
2121
while (c.next()) {
2222
//mill changes
2323
}
24+
//checkbox model is buggy when there are two selected elements and the first one was deselected.
25+
//even though this looks like a nop, it forces the checkbox model to "reload"
26+
//should be this bug in controlsfx: https://github.com/controlsfx/controlsfx/issues/1550
27+
c.list.forEach { }
2428
controlChanged(c.list)
2529
}
2630

0 commit comments

Comments
 (0)