Skip to content

Commit 14836bb

Browse files
committed
Fix import causing integration failures on Windows
There is limited to no pty support on Windows, so test cases calling it are skipped on Windows. This PR changes test behavior to only import pty on non-NT platforms.
1 parent b3203ca commit 14836bb

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

test/integration/dss/test_dss_cli.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
import filecmp
55
import json
66
import os
7-
import pty
87
import sys
98
import unittest
109
import uuid
@@ -131,6 +130,7 @@ def test_upload_progress_bar(self):
131130
@unittest.skipIf(os.name is 'nt', 'No pty support on Windows')
132131
def test_upload_progress_bar_interactive(self):
133132
"""Tests upload progress bar with a simulated interactive session"""
133+
import pty # Trying to import this on Windows will cause a ModuleNotFoundError
134134
dirpath = os.path.join(TEST_DIR, 'tutorial', 'data') # arbitrary and small
135135
put_args = ['dss', 'upload', '--src-dir', dirpath, '--replica',
136136
'aws', '--staging-bucket', 'org-humancellatlas-dss-cli-test']

0 commit comments

Comments
 (0)