Skip to content

Commit 120ba74

Browse files
committed
fix: change onMessage method visibility from private to protected in several components
Dropped "app-page-header" component from grid-dynamic-chart-data.component.html and replaced it with an h1 tag.
1 parent 84df174 commit 120ba74

4 files changed

Lines changed: 7 additions & 7 deletions

File tree

projects/app-lob/src/app/app.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ export class AppComponent implements OnInit {
4040

4141
// eslint-disable-next-line @typescript-eslint/member-ordering
4242
@HostListener('window:message', ['$event'])
43-
private onMessage(e: MessageEvent) {
43+
protected onMessage(e: MessageEvent) {
4444
if (e.origin === e.data.origin && typeof e.data.themeStyle === 'string') {
4545
this.styleElem.textContent = e.data.themeStyle;
4646

projects/app-lob/src/app/grid-dynamic-chart-data/grid-dynamic-chart-data.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11

2-
<app-page-header title="Data Analysis Grid">
2+
<h1>
33
Excel like data analysis showcase application with Ignite UI Angular components and extras
4-
</app-page-header>
4+
</h1>
55
<div class="grid-chart-contextmenu-wrapper">
66
<igx-grid #grid igxChartIntegration igxConditionalFormatting igxContextMenu primaryKey='id' [data]="data">
77
<igx-column field="id" [hidden]="true"></igx-column>

projects/app-lob/src/app/grid-dynamic-chart-data/grid-dynamic-chart-data.component.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/* eslint-disable max-len */
22
import { AfterViewInit, Component, OnInit, ViewChild } from '@angular/core';
3-
import { IgxChartIntegrationDirective, IgxContextMenuDirective, IgxConditionalFormattingDirective, OPTIONS_TYPE, CHART_TYPE, PageHeaderComponent } from 'igniteui-angular-extras';
3+
import { IgxChartIntegrationDirective, IgxContextMenuDirective, IgxConditionalFormattingDirective, OPTIONS_TYPE, CHART_TYPE } from 'igniteui-angular-extras';
44

55
import { FinancialData } from '../data/financialData';
66
import { IgxGridComponent, IgxColumnComponent, IgxCellTemplateDirective } from 'igniteui-angular';
@@ -10,7 +10,7 @@ import { DecimalPipe, CurrencyPipe } from '@angular/common';
1010
selector: 'app-grid-dynamic-chart-data',
1111
templateUrl: './grid-dynamic-chart-data.component.html',
1212
styleUrls: ['./grid-dynamic-chart-data.component.scss'],
13-
imports: [IgxGridComponent, PageHeaderComponent, IgxChartIntegrationDirective, IgxConditionalFormattingDirective, IgxContextMenuDirective, IgxColumnComponent, IgxCellTemplateDirective, DecimalPipe, CurrencyPipe]
13+
imports: [IgxGridComponent, IgxChartIntegrationDirective, IgxConditionalFormattingDirective, IgxContextMenuDirective, IgxColumnComponent, IgxCellTemplateDirective, DecimalPipe, CurrencyPipe]
1414
})
1515
export class GridDynamicChartDataComponent implements OnInit, AfterViewInit {
1616

@@ -42,4 +42,4 @@ export class GridDynamicChartDataComponent implements OnInit, AfterViewInit {
4242
public formatCurrency(value: number) {
4343
return '$' + value.toFixed(3);
4444
}
45-
}
45+
}

projects/app-lob/src/app/index/docs-layout.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ export class DocsLayoutComponent implements OnInit {
1818
private typefaceUrl = 'https://fonts.googleapis.com/css?family=';
1919

2020
@HostListener('window:message', ['$event'])
21-
private onMessage(e: MessageEvent) {
21+
protected onMessage(e: MessageEvent) {
2222
if (e.origin === e.data.origin && typeof e.data.themeStyle === 'string') {
2323
this.styleElem.textContent = e.data.themeStyle;
2424

0 commit comments

Comments
 (0)