Skip to content

Commit 3e5326a

Browse files
author
kdinev
committed
Merge branch 'vnext' of https://github.com/IgniteUI/igniteui-angular-samples into vnext
2 parents aa6086a + fa3a736 commit 3e5326a

130 files changed

Lines changed: 1327 additions & 726 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/CONTRIBUTING.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -48,23 +48,23 @@ Open both repositories ([DocFX Site Builder](https://github.com/IgniteUI/igniteu
4848
# <a name='#fixing'> Fixing bugs and adding new samples</a>
4949
## <a name='#bug'> Bug fixing guidelines</a>
5050

51-
1. Depending on where the bug was found `the current version` or the `ongoing release version`, checkout a development branches from `vNext` or/and `master` branch. `vNext` is the version that is going to be used upon release (next version), and `master` is the branch with the current state (current version available on production). If the change/fix is applicable only to the ongoing release branch (`vNext`) there is no need to cherry-pick to `master` branch as the change/fix/feature will be pushed to `master` branch upon release.
51+
1. Depending on where the bug was found `the current version` or the `ongoing release version`, checkout a development branches from `vnext` or/and `master` branch. `vnext` is the version that is going to be used upon release (next version), and `master` is the branch with the current state (current version available on production). If the change/fix is applicable only to the ongoing release branch (`vnext`) there is no need to cherry-pick to `master` branch as the change/fix/feature will be pushed to `master` branch upon release.
5252
2. Run lint
5353
3. Pull request your changes and reference the issue. Use the enforced commit message format with applicable type, scope, etc.
5454
4. Don't forget to make the necessary status updates, as described in the workflow section.
5555

56-
> Note: Cherry-pick to `master` branch only changes with **high priority**. There is no need to cherry-pick into `master` every bug fix/change from `vNext`> A regular mass merge PRs are going to be made from `vNext` into `master`.
56+
> Note: Cherry-pick to `master` branch only changes with **high priority**. There is no need to cherry-pick into `master` every bug fix/change from `vnext`> A regular mass merge PRs are going to be made from `vnext` into `master`.
5757
5858
**Example workflow for a bug with high priority**
5959
The process will look like this:
6060

61-
1. Checkout new branch from `vNext`. For code example purposes let's say the new branch is called `fixing-bug-5423-vNext`.
62-
2. Commit your changes to your `fixing-bug-5423-vNext` branch.
63-
3. Push and PR to the `vNext` branch.
61+
1. Checkout new branch from `vnext`. For code example purposes let's say the new branch is called `fixing-bug-5423-vnext`.
62+
2. Commit your changes to your `fixing-bug-5423-vnext` branch.
63+
3. Push and PR to the `vnext` branch.
6464
4. Switch to the `master` branch.
6565
5. Create a new branch from `master`. For code example purposes let's say the new branch is called `fixing-bug-5423-master`.
66-
6. Cherry pick your commit from the `fixing-bug-5423-vNext` branch: `git cherry-pick ..`
66+
6. Cherry pick your commit from the `fixing-bug-5423-vnext` branch: `git cherry-pick ..`
6767
7. Push to your `fixing-bug-5423-master` branch and PR to the `master` branch.
6868

6969
## <a name='#new-sample'> Adding new samples guidelines </a>
70-
Depending on where the the new sample should be added, `the current version` or the `ongoing release version`, checkout a development branches from `vNext` or/and `master` branch. `vNext` is the version that is going to be used upon release (next version), and `master` is the branch with the current state (current version). If the new sample is applicable only to the ongoing release branch (`vNext`) there is no need to cherry-pick to `master` branch as the new sample will be pushed to `master` branch upon release.
70+
Depending on where the the new sample should be added, `the current version` or the `ongoing release version`, checkout a development branches from `vnext` or/and `master` branch. `vnext` is the version that is going to be used upon release (next version), and `master` is the branch with the current state (current version). If the new sample is applicable only to the ongoing release branch (`vnext`) there is no need to cherry-pick to `master` branch as the new sample will be pushed to `master` branch upon release.

.github/workflows/build-app-crm.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,14 @@ name: App CRM CI
66
# events but only for the master branch
77
on:
88
push:
9-
branches: [ master, vNext ]
9+
branches: [ master, vnext ]
1010
paths:
1111
- '**'
1212
- '!src/**'
1313
- '!live-editing/**'
1414
- '!projects/app-lob/**'
1515
pull_request:
16-
branches: [ master, vNext ]
16+
branches: [ master, vnext ]
1717
paths:
1818
- '**'
1919
- '!src/**'

.github/workflows/build-app-lob.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ name: App LOB CI
66
# events but only for the master branch
77
on:
88
push:
9-
branches: [ master, vNext ]
9+
branches: [ master, vnext ]
1010
paths:
1111
- '**'
1212
- '!src/**'
@@ -16,7 +16,7 @@ on:
1616
- 'live-editing/generators/AppDVConfigGenerators.ts'
1717
- '!projects/app-crm/**'
1818
pull_request:
19-
branches: [ master, vNext ]
19+
branches: [ master, vnext ]
2020
paths:
2121
- '**'
2222
- '!src/**'

.github/workflows/codeql.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@ name: "CodeQL"
1313

1414
on:
1515
push:
16-
branches: [ "master", "vNext" ]
16+
branches: [ "master", "vnext" ]
1717
pull_request:
1818
# The branches below must be a subset of the branches above
19-
branches: [ "master", "vNext" ]
19+
branches: [ "master", "vnext" ]
2020
schedule:
2121
- cron: '37 17 * * 1'
2222

live-editing/configs/ExportCsvConfigGenerator.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export class ExportCsvConfigGenerator implements IConfigGenerator {
3131

3232
configs.push(new Config({
3333
component: 'TreeGridCsvExportSample1Component',
34-
additionalFiles: ["/src/app/tree-grid/data/foods.ts"],
34+
additionalFiles: ["/src/app/tree-grid/data/orders.ts"],
3535
appModuleConfig: new AppModuleConfig({
3636
imports: ['IgxTreeGridModule', 'IgxCsvExporterService', 'TreeGridCsvExportSample1Component'],
3737
ngDeclarations: ['TreeGridCsvExportSample1Component'],

live-editing/configs/ExportExcelConfigGenerator.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ import {
1010
import { AppModuleConfig, Config, IConfigGenerator } from 'igniteui-live-editing';
1111
export class ExportExcelConfigGenerator implements IConfigGenerator {
1212
public additionalImports = {
13-
PasteHandler: '../../src/app/grid/grid-paste/paste-handler.directive'
13+
PasteHandler: '../../src/app/grid/grid-paste/paste-handler.directive',
14+
IgxPreventDocumentScrollModule: '../../src/app/directives/prevent-scroll.directive'
1415
};
1516
public generateConfigs(): Config[] {
1617
const configs = new Array<Config>();
@@ -53,12 +54,12 @@ export class ExportExcelConfigGenerator implements IConfigGenerator {
5354

5455
configs.push(new Config({
5556
component: 'TreeGridExcelExportSample1Component',
56-
additionalFiles: ['/src/app/tree-grid/data/foods.ts'],
57+
additionalFiles: ['/src/app/tree-grid/data/orders.ts', '/src/app/directives/prevent-scroll.directive.ts',],
5758
appModuleConfig: new AppModuleConfig({
5859
imports: ['IgxTreeGridModule', 'IgxExcelExporterService', 'TreeGridExcelExportSample1Component',
59-
'IgxButtonModule'],
60+
'IgxButtonModule', 'IgxPreventDocumentScrollModule'],
6061
ngDeclarations: ['TreeGridExcelExportSample1Component'],
61-
ngImports: ['IgxTreeGridModule', 'IgxButtonModule'],
62+
ngImports: ['IgxTreeGridModule', 'IgxButtonModule', 'IgxPreventDocumentScrollModule'],
6263
ngProviders: ['IgxExcelExporterService']
6364
})
6465
}));

live-editing/configs/GridConfigGenerator.ts

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import {
1515
IgxCheckboxModule,
1616
IgxChipsModule,
1717
IgxComboModule,
18+
IgxSimpleComboModule,
1819
IgxCsvExporterService,
1920
IgxDatePickerModule,
2021
IgxDialogModule,
@@ -1433,6 +1434,16 @@ export class GridConfigGenerator implements IConfigGenerator {
14331434
})
14341435
}));
14351436

1437+
configs.push(new Config({
1438+
component: 'GridCascadingCombosComponent',
1439+
additionalFiles: ['/src/app/directives/prevent-scroll.directive.ts', '/src/app/data/cities15000-regions-countries.ts', '/src/app/data/data.ts'],
1440+
appModuleConfig: new AppModuleConfig({
1441+
imports: ['IgxGridModule', 'GridCascadingCombosComponent', 'IgxPreventDocumentScrollModule', 'IgxComboModule', 'IgxSimpleComboModule'],
1442+
ngDeclarations: ['GridCascadingCombosComponent'],
1443+
ngImports: ['IgxPreventDocumentScrollModule', 'IgxGridModule', 'IgxComboModule', 'IgxSimpleComboModule']
1444+
})
1445+
}));
1446+
14361447
return configs;
14371448
}
14381449
}

0 commit comments

Comments
 (0)