Skip to content

Commit 859ce90

Browse files
refactor(sorting samples): prevent from input typing
1 parent 1de675e commit 859ce90

6 files changed

Lines changed: 16 additions & 24 deletions

File tree

src/app/grid/grid-sorting-sample/grid-sorting-sample.component.html

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,14 @@
99
Clear Grouped columns
1010
</button>
1111
<igx-grid-toolbar-actions>
12-
<igx-simple-combo #comboItem class="sorting-values"
12+
<igx-simple-combo #comboItem
1313
[data]="sortingTypes"
1414
[displayKey]="'mode'"
1515
[(ngModel)]="sortingOptions"
16-
(selectionChanging)="handleDropDownSelection($event)">
17-
<ng-template igxComboClearIcon>
18-
<igx-icon></igx-icon>
16+
(keydown)="handleSearchResults($event)">
17+
<ng-template igxComboClearIcon></ng-template>
18+
<ng-template igxComboItem let-item>
19+
<div>{{ item.mode | uppercase }}</div>
1920
</ng-template>
2021
</igx-simple-combo>
2122
</igx-grid-toolbar-actions>

src/app/grid/grid-sorting-sample/grid-sorting-sample.component.scss

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,3 @@
1010
justify-content: flex-start;
1111
}
1212
}
13-
14-
.sorting-values ::ng-deep .igx-input-group__input,
15-
::ng-deep .igx-drop-down__item .igx-drop-down__inner {
16-
text-transform: uppercase;
17-
}

src/app/grid/grid-sorting-sample/grid-sorting-sample.component.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/* eslint-disable @typescript-eslint/naming-convention */
22
import { Component, OnInit, ViewChild } from '@angular/core';
3-
import { DefaultSortingStrategy, IgxGridComponent, ISimpleComboSelectionChangingEventArgs, ISortingOptions, SortingDirection } from 'igniteui-angular';
3+
import { DefaultSortingStrategy, IgxGridComponent, ISortingOptions, SortingDirection } from 'igniteui-angular';
44
import { DATA } from '../../data/localData';
55

66
@Component({
@@ -38,7 +38,7 @@ export class SortingSampleComponent implements OnInit {
3838
return new Intl.DateTimeFormat('en-US').format(val);
3939
}
4040

41-
handleDropDownSelection(event: ISimpleComboSelectionChangingEventArgs) {
42-
this.sortingOptions = event.newSelection;
41+
handleSearchResults(event: KeyboardEvent) {
42+
event.preventDefault();
4343
}
4444
}

src/app/tree-grid/tree-grid-sorting-sample/tree-grid-sorting-sample.component.html

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,14 @@
1010
Clear Grouped columns
1111
</button>
1212
<igx-grid-toolbar-actions>
13-
<igx-simple-combo #comboItem class="sorting-values"
13+
<igx-simple-combo #comboItem
1414
[data]="sortingTypes"
1515
[displayKey]="'mode'"
1616
[(ngModel)]="sortingOptions"
17-
(selectionChanging)="handleDropDownSelection($event)">
18-
<ng-template igxComboClearIcon>
19-
<igx-icon></igx-icon>
17+
(keydown)="handleSearchResults($event)">
18+
<ng-template igxComboClearIcon></ng-template>
19+
<ng-template igxComboItem let-item>
20+
<div>{{ item.mode | uppercase }}</div>
2021
</ng-template>
2122
</igx-simple-combo>
2223
</igx-grid-toolbar-actions>

src/app/tree-grid/tree-grid-sorting-sample/tree-grid-sorting-sample.component.scss

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,3 @@
1010
justify-content: flex-start;
1111
}
1212
}
13-
14-
.sorting-values ::ng-deep .igx-input-group__input,
15-
::ng-deep .igx-drop-down__item .igx-drop-down__inner {
16-
text-transform: uppercase;
17-
}

src/app/tree-grid/tree-grid-sorting-sample/tree-grid-sorting-sample.component.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { Component, OnInit, ViewChild } from '@angular/core';
2-
import { DefaultSortingStrategy, IgxTreeGridComponent, ISimpleComboSelectionChangingEventArgs, ISortingOptions, SortingDirection } from 'igniteui-angular';
2+
import { DefaultSortingStrategy, IgxTreeGridComponent, ISortingOptions, SortingDirection } from 'igniteui-angular';
33
import { FOODS_DATA } from '../data/foods';
44

55
@Component({
@@ -51,7 +51,7 @@ export class TreeGridSortingSampleComponent implements OnInit {
5151
this.contextmenu = false;
5252
}
5353

54-
handleDropDownSelection(event: ISimpleComboSelectionChangingEventArgs) {
55-
this.sortingOptions = event.newSelection;
54+
handleSearchResults(event: KeyboardEvent) {
55+
event.preventDefault();
5656
}
5757
}

0 commit comments

Comments
 (0)