Merge pull request #3152 from IgniteUI/kdinev-patch-2

ci(*): create codeql.yml

Author: zdrawku

.github/workflows/build-app-crm.yml

@@ -1,19 +1,19 @@
 # This is a basic workflow to help you get started with Actions
 
-name: CI
+name: App CRM CI
 
 # Controls when the action will run. Triggers the workflow on push or pull request
 # events but only for the master branch
 on:
   push:
-    branches: [ master, vNext]
+    branches: [ master, vNext ]
     paths:
       - '**'
       - '!src/**'
       - '!live-editing/**'
       - '!projects/app-lob/**'
   pull_request:
-    branches: [ master, vNext]
+    branches: [ master, vNext ]
     paths:
       - '**'
       - '!src/**'
@@ -27,11 +27,21 @@ jobs:
     # The type of runner that the job will run on
     runs-on: ubuntu-latest
 
+    strategy:
+      matrix:
+        node-version: [16.x, 18.x]
+
     # Steps represent a sequence of tasks that will be executed as part of the job
     steps:
       # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
       - uses: actions/checkout@v2
 
+      - name: Use Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v2
+        with:
+            node-version: ${{ matrix.node-version }}
+            cache: 'npm'
+
       - name: Install dependencies
         run: npm ci
 

.github/workflows/build-app-lob.yml

@@ -1,12 +1,12 @@
 # This is a basic workflow to help you get started with Actions
 
-name: CI
+name: App LOB CI
 
 # Controls when the action will run. Triggers the workflow on push or pull request
 # events but only for the master branch
 on:
   push:
-    branches: [ master, vNext]
+    branches: [ master, vNext ]
     paths:
       - '**'
       - '!src/**'
@@ -16,7 +16,7 @@ on:
       - 'live-editing/generators/AppDVConfigGenerators.ts'
       - '!projects/app-crm/**'
   pull_request:
-    branches: [ master, vNext]
+    branches: [ master, vNext ]
     paths:
       - '**'
       - '!src/**'
@@ -32,11 +32,21 @@ jobs:
     # The type of runner that the job will run on
     runs-on: ubuntu-latest
 
+    strategy:
+      matrix:
+        node-version: [16.x, 18.x]
+
     # Steps represent a sequence of tasks that will be executed as part of the job
     steps:
       # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
       - uses: actions/checkout@v2
 
+      - name: Use Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v2
+        with:
+            node-version: ${{ matrix.node-version }}
+            cache: 'npm'
+
       - name: Install dependencies
         run: npm ci
 

.github/workflows/codeql.yml

@@ -0,0 +1,74 @@
+# For most projects, this workflow file will not need changing; you simply need
+# to commit it to your repository.
+#
+# You may wish to alter this file to override the set of languages analyzed,
+# or to provide custom queries or build logic.
+#
+# ******** NOTE ********
+# We have attempted to detect the languages in your repository. Please check
+# the `language` matrix defined below to confirm you have the correct set of
+# supported CodeQL languages.
+#
+name: "CodeQL"
+
+on:
+  push:
+    branches: [ "master", "vNext" ]
+  pull_request:
+    # The branches below must be a subset of the branches above
+    branches: [ "master", "vNext" ]
+  schedule:
+    - cron: '37 17 * * 1'
+
+jobs:
+  analyze:
+    name: Analyze
+    runs-on: ubuntu-latest
+    permissions:
+      actions: read
+      contents: read
+      security-events: write
+
+    strategy:
+      fail-fast: false
+      matrix:
+        language: [ 'javascript' ]
+        # CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python', 'ruby' ]
+        # Learn more about CodeQL language support at https://aka.ms/codeql-docs/language-support
+
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@v3
+
+    # Initializes the CodeQL tools for scanning.
+    - name: Initialize CodeQL
+      uses: github/codeql-action/init@v2
+      with:
+        languages: ${{ matrix.language }}
+        # If you wish to specify custom queries, you can do so here or in a config file.
+        # By default, queries listed here will override any specified in a config file.
+        # Prefix the list here with "+" to use these queries and those in the config file.
+        
+        # Details on CodeQL's query packs refer to : https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs
+        # queries: security-extended,security-and-quality
+
+        
+    # Autobuild attempts to build any compiled languages  (C/C++, C#, Go, or Java).
+    # If this step fails, then you should remove it and run the build manually (see below)
+    - name: Autobuild
+      uses: github/codeql-action/autobuild@v2
+
+    # ℹ️ Command-line programs to run using the OS shell.
+    # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
+
+    #   If the Autobuild fails above, remove it and uncomment the following three lines. 
+    #   modify them (or add more) to build your code if your project, please refer to the EXAMPLE below for guidance.
+
+    # - run: |
+    #   echo "Run, Build Application using script"
+    #   ./location_of_script_within_repo/buildscript.sh
+
+    - name: Perform CodeQL Analysis
+      uses: github/codeql-action/analyze@v2
+      with:
+        category: "/language:${{matrix.language}}"

projects/app-lob/src/app/grid-finjs/main.component.html

@@ -29,7 +29,6 @@
         </div>
     </igx-dialog>
 </div>
-
 <ng-template let-series="series" let-item="item" #seriesTooltip>
     <div class="tooltipTable">
         <div class="tooltipRow">

src/app/grid/grid-column-data-types-sample/grid-column-data-types-sample.component.ts

@@ -43,7 +43,7 @@ export class GridColumnDataTypesSampleComponent implements OnInit {
         { format: "longDate", eq: "'MMMM d, y'"},
         { format: "fullDate", eq: "'EEEE, MMMM d, y'"}
     ];
-    
+
     // Time formats
     public timeFormats = [
         { format: "shortTime", eq: "'h:mm a'" },
@@ -208,7 +208,7 @@ export class GridColumnDataTypesSampleComponent implements OnInit {
       }
     ];
 
-    private regEx = new RegExp('^[0-9]+\.[0-9]+\-[0-9]$')
+    private regEx = new RegExp('^[0-9]+.[0-9]+-[0-9]$')
 
     constructor() {
     }
@@ -248,7 +248,7 @@ export class GridColumnDataTypesSampleComponent implements OnInit {
         this.dateOptions.format = event.newSelection.value;
         this.formatDateOptions = Object.assign({}, this.formatDateOptions, this.dateOptions);
     }
-    
+
     public selectionTimeChanging(event) {
         this.timeOptions.format = event.newSelection.value;
         this.formatTimeOptions = Object.assign({}, this.formatTimeOptions, this.timeOptions);

src/app/grid/grid-crud-sample/crud-sample.component.ts

@@ -47,13 +47,13 @@ export class CRUDSampleComponent implements OnInit, OnDestroy {
         });
     }
 
-    public rowAdded(event: IRowDataEventArgs) {
+    public rowAdded(event: IRowDataEventArgs): void {
         this._crudService.add(event.data).subscribe((rec) => {
             // this.snackbar.open(`Row with ID of ${rec.ID} was created.`);
         });
     }
 
-    public rowDeleted(event: IRowDataEventArgs) {
+    public rowDeleted(event: IRowDataEventArgs): void {
         this.grid.isLoading = true;
         this._crudService.delete(event.data).subscribe({
             next: (data: any) => {
@@ -69,7 +69,7 @@ export class CRUDSampleComponent implements OnInit, OnDestroy {
         });
     }
 
-    public rowEditDone(event: IGridEditDoneEventArgs) {
+    public rowEditDone(event: IGridEditDoneEventArgs): void {
         if (!event.isAddRow) {
             this.grid.isLoading = true;
             this._crudService.update(event.newValue).subscribe((rec) => {

src/app/layouts/carousel/carousel-animations-sample/carousel-animations-sample.component.html

@@ -27,7 +27,7 @@ <h4 igxCardHeaderTitle>{{slide.heading}}</h4>
                         </igx-card-media>
 
                         <igx-card-actions>
-                            <a  igxButton href="{{slide.link}}" target="_blank" style="text-decoration: none;">visit page</a>
+                            <a igxButton href="{{slide.link}}" target="_blank" rel="noopener" style="text-decoration: none;">visit page</a>
                         </igx-card-actions>
                     </igx-card>
                 </div>