Skip to content

Commit 2cd9b66

Browse files
TEST: update tests for random, when using dpctl sycl queue (#934)
Co-authored-by: Alexander-Makaryev <alexander.makaryev@gmail.com>
1 parent f9d06d8 commit 2cd9b66

1 file changed

Lines changed: 12 additions & 11 deletions

File tree

tests/test_random.py

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,14 @@ def check_extreme_value(self, dist_name, val, params):
1313
seed = 28041990
1414
size = 10
1515
dpnp.random.seed(seed)
16-
res = numpy.asarray(getattr(dpnp.random, dist_name)(size=size, **params))
16+
res = dpnp.asnumpy(getattr(dpnp.random, dist_name)(size=size, **params))
1717
assert len(numpy.unique(res)) == 1
1818
assert numpy.unique(res)[0] == val
1919

2020
def check_moments(self, dist_name, expected_mean, expected_var, params, size=10**5):
2121
seed = 28041995
2222
dpnp.random.seed(seed)
23-
res = numpy.asarray(getattr(dpnp.random, dist_name)(size=size, **params))
23+
res = dpnp.asnumpy(getattr(dpnp.random, dist_name)(size=size, **params))
2424
var = numpy.var(res)
2525
mean = numpy.mean(res)
2626
assert math.isclose(var, expected_var, abs_tol=0.1)
@@ -35,9 +35,9 @@ def check_seed(self, dist_name, params):
3535
seed = 28041990
3636
size = 10
3737
dpnp.random.seed(seed)
38-
a1 = dpnp.asarray(getattr(dpnp.random, dist_name)(size=size, **params))
38+
a1 = dpnp.asnumpy(getattr(dpnp.random, dist_name)(size=size, **params))
3939
dpnp.random.seed(seed)
40-
a2 = dpnp.asarray(getattr(dpnp.random, dist_name)(size=size, **params))
40+
a2 = dpnp.asnumpy(getattr(dpnp.random, dist_name)(size=size, **params))
4141
assert_allclose(a1, a2, rtol=1e-07, atol=0)
4242

4343

@@ -93,9 +93,10 @@ def test_check_otput(func):
9393
res = func(shape)
9494
# assert numpy.all(res >= 0)
9595
# assert numpy.all(res < 1)
96-
for i in range(res.size):
97-
assert res[i] >= 0.0
98-
assert res[i] < 1.0
96+
res_as_numpy = dpnp.asnumpy(res)
97+
for i in range(res_as_numpy.size):
98+
assert res_as_numpy[i] >= 0.0
99+
assert res_as_numpy[i] < 1.0
99100

100101

101102
@pytest.mark.parametrize("func",
@@ -135,7 +136,7 @@ def test_randn_normal_distribution():
135136
expected_var = 1.0
136137

137138
dpnp.random.seed(seed)
138-
res = dpnp.random.randn(pts)
139+
res = dpnp.asnumpy(dpnp.random.randn(pts))
139140
var = numpy.var(res)
140141
mean = numpy.mean(res)
141142
assert math.isclose(var, expected_var, abs_tol=0.03)
@@ -560,7 +561,7 @@ def test_extreme_value(self):
560561
self.check_extreme_value('negative_binomial', check_val, {'n': n, 'p': p})
561562
n = 5
562563
p = 0.0
563-
res = numpy.asarray(dpnp.random.negative_binomial(n=n, p=p, size=10))
564+
res = dpnp.asnumpy(dpnp.random.negative_binomial(n=n, p=p, size=10))
564565
check_val = numpy.iinfo(res.dtype).min
565566
assert len(numpy.unique(res)) == 1
566567
assert numpy.unique(res)[0] == check_val
@@ -615,7 +616,7 @@ def test_moments(self, df):
615616
size = 10**6
616617
seed = 28041995
617618
dpnp.random.seed(seed)
618-
res = numpy.asarray(dpnp.random.noncentral_chisquare(df, nonc, size=size))
619+
res = dpnp.asnumpy(dpnp.random.noncentral_chisquare(df, nonc, size=size))
619620
var = numpy.var(res)
620621
mean = numpy.mean(res)
621622
assert math.isclose(var, expected_var, abs_tol=0.6)
@@ -858,7 +859,7 @@ def test_moments(self, kappa):
858859
expected_mean = numpy.mean(numpy_res)
859860
expected_var = numpy.var(numpy_res)
860861

861-
res = numpy.asarray(dpnp.random.vonmises(mu, kappa, size=size))
862+
res = dpnp.asnumpy(dpnp.random.vonmises(mu, kappa, size=size))
862863
var = numpy.var(res)
863864
mean = numpy.mean(res)
864865
assert math.isclose(var, expected_var, abs_tol=0.6)

0 commit comments

Comments
 (0)