dpnp_full() to desc (#804)

Author: shssf

dpnp/dpnp_algo/dpnp_algo.pxd

@@ -282,7 +282,7 @@ Array creation routines
 cpdef dpnp_descriptor dpnp_arange(start, stop, step, dtype)
 cpdef dparray dpnp_array(object obj, object dtype=*)
 cpdef dparray dpnp_init_val(shape, dtype, value)
-
+cpdef dpnp_descriptor dpnp_full(result_shape, value_in, result_dtype) # same as dpnp_init_val
 
 """
 Mathematical functions

dpnp/dpnp_algo/dpnp_algo.pyx

@@ -154,6 +154,9 @@ cpdef dparray dpnp_flatten(dparray array_):
 
 
 cpdef dparray dpnp_init_val(shape, dtype, value):
+    """
+    same as dpnp_full(). TODO remove code dumplication
+    """
     cdef DPNPFuncType param1_type = dpnp_dtype_to_DPNPFuncType(dtype)
 
     cdef DPNPFuncData kernel_data = get_dpnp_function_ptr(DPNP_FN_INITVAL, param1_type, param1_type)

dpnp/dpnp_algo/dpnp_algo_arraycreation.pyx

@@ -97,28 +97,29 @@ cpdef utils.dpnp_descriptor dpnp_diag(utils.dpnp_descriptor v, int k):
     return result
 
 
-cpdef dparray dpnp_full(result_shape, value_in, result_dtype):
+cpdef utils.dpnp_descriptor dpnp_full(result_shape, value_in, result_dtype):
     # Convert string type names (dparray.dtype) to C enum DPNPFuncType
     cdef DPNPFuncType dtype_in = dpnp_dtype_to_DPNPFuncType(result_dtype)
 
     # get the FPTR data structure
     cdef DPNPFuncData kernel_data = get_dpnp_function_ptr(DPNP_FN_FULL, dtype_in, DPNP_FT_NONE)
 
-    result_type = dpnp_DPNPFuncType_to_dtype(< size_t > kernel_data.return_type)
-    # Create single-element input array with type given by FPTR data
-    cdef dparray_shape_type shape_in = (1,)
-    cdef dparray array_in = dparray(shape_in, dtype=result_type)
-    array_in[0] = value_in
-    # Create result array with type given by FPTR data
-    cdef dparray result = dparray(result_shape, dtype=result_type)
+    # Create single-element input fill array with type given by FPTR data
+    cdef dparray_shape_type shape_in = (1,) 
+    cdef utils.dpnp_descriptor array_fill = utils.create_output_descriptor(shape_in, kernel_data.return_type, None)
+    array_fill.get_pyobj()[0] = value_in
+
+    # ceate result array with type given by FPTR data
+    cdef dparray_shape_type result_shape_c = utils._object_to_tuple(result_shape) 
+    cdef utils.dpnp_descriptor result = utils.create_output_descriptor(result_shape_c, kernel_data.return_type, None)
 
     cdef fptr_1in_1out_t func = <fptr_1in_1out_t > kernel_data.ptr
     # Call FPTR function
-    func(array_in.get_data(), result.get_data(), result.size)
+    func(array_fill.get_data(), result.get_data(), result.size)
 
     return result
 
-
+# TODO we don't need this function because it is the same as dpnp_full()
 cpdef dparray dpnp_full_like(result_shape, value_in, result_dtype):
     # Convert string type names (dparray.dtype) to C enum DPNPFuncType
     cdef DPNPFuncType dtype_in = dpnp_dtype_to_DPNPFuncType(result_dtype)

dpnp/dpnp_iface_arraycreation.py

@@ -625,7 +625,6 @@ def fromstring(string, **kwargs):
     return call_origin(numpy.fromstring, string, **kwargs)
 
 
-# numpy.full(shape, fill_value, dtype=None, order='C')
 def full(shape, fill_value, dtype=None, order='C'):
     """
     Return a new array of given shape and type, filled with `fill_value`.
@@ -656,9 +655,9 @@ def full(shape, fill_value, dtype=None, order='C'):
             pass
         else:
             if dtype is None:
-                dtype = numpy.array(fill_value).dtype.type
+                dtype = numpy.array(fill_value).dtype.type  #TODO simplify
 
-            return dpnp_full(shape, fill_value, dtype)
+            return dpnp_full(shape, fill_value, dtype).get_pyobj()
 
     return call_origin(numpy.full, shape, fill_value, dtype, order)