Added pygrep-hooks to pre-commit config (#1454)

Author: antonwolfy

.pre-commit-config.yaml

@@ -23,6 +23,25 @@ repos:
     -   id: fix-byte-order-marker
     -   id: mixed-line-ending
     -   id: trailing-whitespace
+-   repo: https://github.com/pre-commit/pygrep-hooks
+    rev: v1.10.0
+    hooks:
+    -   id: python-check-blanket-noqa
+    -   id: python-check-blanket-type-ignore
+    -   id: python-check-mock-methods
+    -   id: python-no-eval
+        exclude: |
+            (?x)^(
+                tests/test_arraycreation.py|
+                tests/test_sycl_queue.py|
+                tests/test_usm_type.py
+            )$
+    -   id: python-no-log-warn
+    -   id: python-use-type-annotations
+    -   id: rst-backticks
+    -   id: rst-directive-colons
+    -   id: rst-inline-touching-normal
+    -   id: text-unicode-replacement-char
 -   repo: https://github.com/psf/black
     rev: 23.3.0
     hooks:

tests/third_party/cupy/creation_tests/test_from_data.py

@@ -558,7 +558,7 @@ def test_fromfile(self, xp):
 # mask = testing.shaped_arange((2, 3, 4), cupy, dtype)
 # a = DummyObjectWithCudaArrayInterface(a, self.ver, self.strides, mask)
 # with pytest.raises(ValueError) as ex:
-# b = cupy.asarray(a)  # noqa
+# b = cupy.asarray(a)
 # assert 'does not support' in str(ex.value)
 
 

tests/third_party/cupy/testing/array.py

@@ -21,7 +21,8 @@ def assert_allclose(
 
     .. seealso:: :func:`numpy.testing.assert_allclose`
 
-    """  # NOQA
+    """
+
     numpy.testing.assert_allclose(
         dpnp.asnumpy(actual),
         dpnp.asnumpy(desired),
@@ -44,7 +45,9 @@ def assert_array_almost_equal(x, y, decimal=6, err_msg="", verbose=True):
              values are appended to the error message.
 
     .. seealso:: :func:`numpy.testing.assert_array_almost_equal`
-    """  # NOQA
+
+    """
+
     numpy.testing.assert_array_almost_equal(
         dpnp.asnumpy(x),
         dpnp.asnumpy(y),
@@ -80,7 +83,9 @@ def assert_array_max_ulp(a, b, maxulp=1, dtype=None):
          dtype(numpy.dtype): Data-type to convert ``a`` and ``b`` to if given.
 
     .. seealso:: :func:`numpy.testing.assert_array_max_ulp`
-    """  # NOQA
+
+    """
+
     numpy.testing.assert_array_max_ulp(
         dpnp.asnumpy(a), dpnp.asnumpy(b), maxulp=maxulp, dtype=dtype
     )
@@ -165,7 +170,9 @@ def assert_array_less(x, y, err_msg="", verbose=True):
              are appended to the error message.
 
     .. seealso:: :func:`numpy.testing.assert_array_less`
-    """  # NOQA
+
+    """
+
     numpy.testing.assert_array_less(
         dpnp.asnumpy(x), dpnp.asnumpy(y), err_msg=err_msg, verbose=verbose
     )

tests/third_party/cupy/testing/helper.py

@@ -522,7 +522,8 @@ def numpy_cupy_array_almost_equal_nulp(
     (except the type of array module) even if ``xp`` is ``numpy`` or ``cupy``.
 
     .. seealso:: :func:`cupy.testing.assert_array_almost_equal_nulp`
-    """  # NOQA
+
+    """
 
     def check_func(x, y):
         array.assert_array_almost_equal_nulp(x, y, nulp)
@@ -570,7 +571,7 @@ def numpy_cupy_array_max_ulp(
 
     .. seealso:: :func:`cupy.testing.assert_array_max_ulp`
 
-    """  # NOQA
+    """
 
     def check_func(x, y):
         array.assert_array_max_ulp(x, y, maxulp, dtype)
@@ -659,7 +660,8 @@ def numpy_cupy_array_list_equal(
     (except the type of array module) even if ``xp`` is ``numpy`` or ``cupy``.
 
     .. seealso:: :func:`cupy.testing.assert_array_list_equal`
-    """  # NOQA
+
+    """
 
     def check_func(x, y):
         array.assert_array_equal(x, y, err_msg, verbose)
@@ -1011,7 +1013,9 @@ def for_int_dtypes(name="dtype", no_bool=False):
 
     .. seealso:: :func:`cupy.testing.for_dtypes`,
         :func:`cupy.testing.for_all_dtypes`
-    """  # NOQA
+
+    """
+
     if no_bool:
         return for_dtypes(_int_dtypes, name=name)
     else:
@@ -1139,7 +1143,9 @@ def for_signed_dtypes_combination(names=("dtype",), full=None):
              (see description in :func:`cupy.testing.for_dtypes_combination`).
 
     .. seealso:: :func:`cupy.testing.for_dtypes_combination`
-    """  # NOQA
+
+    """
+
     return for_dtypes_combination(_signed_dtypes, names=names, full=full)
 
 
@@ -1154,7 +1160,9 @@ def for_unsigned_dtypes_combination(names=("dtype",), full=None):
              (see description in :func:`cupy.testing.for_dtypes_combination`).
 
     .. seealso:: :func:`cupy.testing.for_dtypes_combination`
-    """  # NOQA
+
+    """
+
     return for_dtypes_combination(_unsigned_dtypes, names=names, full=full)
 
 
@@ -1171,7 +1179,9 @@ def for_int_dtypes_combination(names=("dtype",), no_bool=False, full=None):
              (see description in :func:`cupy.testing.for_dtypes_combination`).
 
     .. seealso:: :func:`cupy.testing.for_dtypes_combination`
-    """  # NOQA
+
+    """
+
     if no_bool:
         types = _int_dtypes
     else:

tests/third_party/cupy/testing/parameterized.py

@@ -2,7 +2,6 @@
 import io
 import itertools
 import types
-import typing as tp  # NOQA
 import unittest
 
 from tests.third_party.cupy.testing import _bundle