add pre-commit to the project

Author: ndgrigorian

.flake8

@@ -0,0 +1,38 @@
+[flake8]
+extend-ignore =
+    # whitespace before ':' (currently conflicts with black formatting):
+    E203,
+    # ‘from module import *’ used; unable to detect undefined names:
+    F403,
+    # missing docstring in public module:
+    D100,
+    # missing docstring in public class:
+    D101,
+    # missing docstring in public method:
+    D102,
+    # missing docstring in public function:
+    D103,
+    # missing docstring in __init__:
+    D107,
+    # 1 blank line required between summary line and description:
+    D205,
+    # first line should end with a period:
+    D400,
+    # first line should be in imperative mood:
+    D401,
+
+per-file-ignores =
+    mkl_umath/__init__.py: F401
+    mkl_umath/ufunc_docstrings_numpy1.py: E501
+    mkl_umath/ufunc_docstrings_numpy2.py: E501
+
+exclude = _vendored/conv_template.py
+
+filename = *.py, *.pyx, *.pxi, *.pxd
+max_line_length = 80
+max-doc-length = 80
+show-source = True
+
+# Print detailed statistic if any issue detected
+count = True
+statistics = True

.github/workflows/build-with-clang.yml

@@ -74,7 +74,7 @@ jobs:
         run: |
           source ${{ env.ONEAPI_ROOT }}/setvars.sh
           pip install pytest
-          # mkl_umath cannot be installed in editable mode, we need 
+          # mkl_umath cannot be installed in editable mode, we need
           # to change directory before importing it and running tests
           cd ..
           python -m pytest -sv --pyargs mkl_umath/mkl_umath/tests

.github/workflows/build_pip.yaml

@@ -55,7 +55,7 @@ jobs:
           CC=icx pip install . --no-build-isolation --no-deps --verbose
           pip install --no-cache-dir pytest
           pip list
-          # mkl_umath cannot be installed in editable mode, we need 
+          # mkl_umath cannot be installed in editable mode, we need
           # to change directory before importing it and running tests
           cd ..
           python -m pytest -v mkl_umath/mkl_umath/tests

.github/workflows/conda-package.yml

@@ -319,8 +319,8 @@ jobs:
         shell: cmd /C CALL {0}
         run: |
           conda activate
-          echo "Value of CONDA enviroment variable was: " %CONDA%
-          echo "Value of CONDA_PREFIX enviroment variable was: " %CONDA_PREFIX%
+          echo "Value of CONDA environment variable was: " %CONDA%
+          echo "Value of CONDA_PREFIX environment variable was: " %CONDA_PREFIX%
           conda info && conda list -n mkl_umath_test
 
       - name: Smoke test

.pre-commit-config.yaml

@@ -0,0 +1,104 @@
+repos:
+- repo: https://github.com/pre-commit/pre-commit-hooks
+  rev: v6.0.0
+  hooks:
+    - id: check-ast
+    - id: check-builtin-literals
+    - id: check-case-conflict
+    - id: check-executables-have-shebangs
+    - id: check-merge-conflict
+    - id: check-toml
+    - id: debug-statements
+    - id: destroyed-symlinks
+    - id: end-of-file-fixer
+    - id: fix-byte-order-marker
+    - id: mixed-line-ending
+    - id: trailing-whitespace
+
+-   repo: https://github.com/pre-commit/pygrep-hooks
+    rev: v1.10.0
+    hooks:
+    -   id: python-check-blanket-noqa
+    -   id: python-check-blanket-type-ignore
+    -   id: python-check-mock-methods
+    -   id: python-no-eval
+    -   id: python-no-log-warn
+    -   id: python-use-type-annotations
+    -   id: rst-backticks
+    -   id: rst-directive-colons
+    -   id: rst-inline-touching-normal
+    -   id: text-unicode-replacement-char
+
+- repo: https://github.com/codespell-project/codespell
+  rev: v2.4.1
+  hooks:
+  - id: codespell
+    args: ["-L", "nin,inout"]
+    additional_dependencies:
+    - tomli
+
+- repo: https://github.com/psf/black
+  rev: 26.1.0
+  hooks:
+  - id: black
+    exclude: "_vendored/conv_template.py"
+
+- repo: https://github.com/pocc/pre-commit-hooks
+  rev: v1.3.5
+  hooks:
+  - id: clang-format
+    args: ["-i"]
+
+- repo: https://github.com/MarcoGorelli/cython-lint
+  rev: v0.19.0
+  hooks:
+  - id: cython-lint
+  - id: double-quote-cython-strings
+
+- repo: https://github.com/pycqa/flake8
+  rev: 7.3.0
+  hooks:
+  - id: flake8
+    args: ["--config=.flake8"]
+    additional_dependencies:
+      - flake8-docstrings==1.7.0
+      - flake8-bugbear==25.11.29
+
+- repo: https://github.com/pycqa/isort
+  rev: 8.0.0
+  hooks:
+  - id: isort
+    name: isort (python)
+  - id: isort
+    name: isort (cython)
+    types: [cython]
+  - id: isort
+    name: isort (pyi)
+    types: [pyi]
+
+- repo: https://github.com/macisamuele/language-formatters-pre-commit-hooks
+  rev: v2.16.0
+  hooks:
+  - id: pretty-format-toml
+    args: [--autofix]
+
+- repo: local
+  hooks:
+  - id: pylint
+    name: pylint
+    entry: pylint
+    language: system
+    types: [python]
+    require_serial: true
+    args:
+        [
+        "-rn", # Only display messages
+        "-sn", # Don't display the score
+        "--errors-only",
+        "--disable=import-error",
+        ]
+
+- repo: https://github.com/jumanjihouse/pre-commit-hooks
+  rev: 3.0.0
+  hooks:
+  - id: shellcheck

CHANGELOG.md

@@ -24,7 +24,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 * Enabled support of Python 3.13 [gh-101](https://github.com/IntelPython/mkl_umath/pull/101)
 * Added mkl implementation for complex data-types of `add`, `subtract`, `multiply` and `divide` functions [gh-102](https://github.com/IntelPython/mkl_umath/pull/102)
 
-### Changed 
+### Changed
 * Dropped support for `maximum` and `minimum` [gh-104](https://github.com/IntelPython/mkl_umath/pull/104)
 * Disabled `-fast-math` by default [gh-105](https://github.com/IntelPython/mkl_umath/pull/105)
 * Used a common umath loop for `log2` function to match NumPy [gh-109](https://github.com/IntelPython/mkl_umath/pull/109)
@@ -37,7 +37,7 @@ This release updates `mkl_umath` to be aligned with both numpy-1.26.x and numpy-
 * The definition of `sign` function for complex floating point data types is updated to match numpy-2.x.x [gh-65](https://github.com/IntelPython/mkl_umath/pull/65)
 * `ldexp` function is updated to allow `int64` explicitly similar to numpy-2.x.x behavior [gh-73](https://github.com/IntelPython/mkl_umath/pull/73)
 
-### Changed 
+### Changed
 * Migrated from `setup.py` to `pyproject toml` [gh-63](https://github.com/IntelPython/mkl_umath/pull/63)
 * Changed to dynamic linking and added interface and threading layers [gh-72](https://github.com/IntelPython/mkl_umath/pull/72)
 

README.md

@@ -9,7 +9,7 @@ powered version of loops used in the patched version of [NumPy](https://numpy.or
 
 Patches were factored out per community feedback ([NEP-36](https://numpy.org/neps/nep-0036-fair-play.html)).
 
-`mkl_umath` started as a part of Intel® Distribution for Python* optimizations to NumPy, and is now being released 
+`mkl_umath` started as a part of Intel® Distribution for Python* optimizations to NumPy, and is now being released
 as a stand-alone package. It can be installed into conda environment using:
 
 ```

_vendored/README.md

@@ -2,4 +2,4 @@
 
 File `conv_template.py` is copied from NumPy's numpy/distutils folder, since
 `numpy.distutils` is absent from the installation layout starting with
-Python 3.12
+Python 3.12

conda-recipe-cf/build.sh

@@ -1,9 +1,12 @@
+#!/bin/bash
+
 # This is necessary to help DPC++ find Intel libraries such as SVML, IRNG, etc in build prefix
 export LD_LIBRARY_PATH="$LD_LIBRARY_PATH:${BUILD_PREFIX}/lib"
 
 # Intel LLVM must cooperate with compiler and sysroot from conda
 echo "--gcc-toolchain=${BUILD_PREFIX} --sysroot=${BUILD_PREFIX}/${HOST}/sysroot -target ${HOST}" > icx_for_conda.cfg
-export ICXCFG="$(pwd)/icx_for_conda.cfg"
+ICXCFG="$(pwd)/icx_for_conda.cfg"
+export ICXCFG
 
 read -r GLIBC_MAJOR GLIBC_MINOR <<< "$(conda list '^sysroot_linux-64$' \
     | tail -n 1 | awk '{print $2}' | grep -oP '\d+' | head -n 2 | tr '\n' ' ')"
@@ -14,9 +17,9 @@ SKBUILD_ARGS="-- -DCMAKE_C_COMPILER:PATH=icx -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON"
 if [ -n "${WHEELS_OUTPUT_FOLDER}" ]; then
     # Install packages and assemble wheel package from built bits
     WHEELS_BUILD_ARGS="-p manylinux_${GLIBC_MAJOR}_${GLIBC_MINOR}_x86_64"
-    ${PYTHON} setup.py install bdist_wheel ${WHEELS_BUILD_ARGS} ${SKBUILD_ARGS}
-    cp dist/mkl_umath*.whl ${WHEELS_OUTPUT_FOLDER}
+    ${PYTHON} setup.py install bdist_wheel "${WHEELS_BUILD_ARGS}" "${SKBUILD_ARGS}"
+    cp dist/mkl_umath*.whl "${WHEELS_OUTPUT_FOLDER}"
 else
     # Perform regular install
-    ${PYTHON} setup.py install ${SKBUILD_ARGS}
+    ${PYTHON} setup.py install "${SKBUILD_ARGS}"
 fi

conda-recipe-cf/run_tests.bat

@@ -1 +1 @@
-%PYTHON% tests\test_basic.py
+%PYTHON% tests\test_basic.py