update clang workflow

add workflow using standard clang

Author: ndgrigorian

.github/workflows/build-with-clang.yml

@@ -8,7 +8,7 @@ on:
 permissions: read-all
 
 jobs:
-  build-with-clang:
+  build-with-intel-clang:
     runs-on: ubuntu-latest
 
     strategy:
@@ -56,7 +56,7 @@ jobs:
 
       - name: Install mkl_umath dependencies
         run: |
-          pip install scikit-build cmake ninja cython setuptools">=77"
+          pip install meson-python ninja cython mkl-service
           pip install ${{ matrix.numpy_version }}
 
       - name: List oneAPI folder content
@@ -67,7 +67,6 @@ jobs:
           source ${{ env.ONEAPI_ROOT }}/setvars.sh
           echo $CMPLR_ROOT
           export CC=$CMPLR_ROOT/bin/icx
-          export CFLAGS="${CFLAGS} -fno-fast-math -O2"
           pip install . --no-build-isolation --no-deps --verbose
 
       - name: Run mkl_umath tests

.github/workflows/build-with-standard-clang.yml

@@ -0,0 +1,64 @@
+name: Build project with standard clang compiler
+
+on:
+  pull_request:
+  push:
+    branches: [master]
+
+permissions: read-all
+
+jobs:
+  build-with-standard-clang:
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        python: ["3.10", "3.11", "3.12", "3.13", "3.14"]
+        numpy_version: ["numpy'>=2'"]
+
+    env:
+      COMPILER_ROOT: /usr/bin
+
+    defaults:
+      run:
+        shell: bash -el {0}
+
+    steps:
+      - name: Cancel Previous Runs
+        uses: styfle/cancel-workflow-action@3155a141048f8f89c06b4cdae32e7853e97536bc # 0.13.0
+        with:
+          access_token: ${{ github.token }}
+
+      - name: Install Dependencies
+        run: |
+          sudo apt-get update && sudo apt-get install -y clang
+
+      - name: Setup Python
+        uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
+        with:
+          python-version: ${{ matrix.python }}
+          architecture: x64
+
+      - name: Checkout repo
+        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        with:
+          fetch-depth: 0
+
+      - name: Install mkl_umath dependencies
+        run: |
+          pip install meson-python ninja cython mkl-service
+          pip install mkl-devel tbb-devel
+          pip install ${{ matrix.numpy_version }}
+
+      - name: Build mkl_umath
+        run: |
+          export CC=${{ env.COMPILER_ROOT }}/clang
+          pip install . --no-build-isolation --no-deps --verbose
+
+      - name: Run mkl_umath tests
+        run: |
+          pip install pytest
+          # mkl_umath cannot be installed in editable mode, we need
+          # to change directory before importing it and running tests
+          cd ..
+          python -m pytest -sv --pyargs mkl_umath/mkl_umath/tests

meson.build

@@ -1,6 +1,6 @@
 project(
     'mkl_umath',
-    ['c', 'cython'],
+    ['c', 'cpp', 'cython'],
     version: run_command(
         'python', '-c',
         'import os; exec(open("mkl_umath/_version.py").read()); print(__version__)',
@@ -42,22 +42,27 @@ endif
 
 if cc.get_argument_syntax() == 'msvc'
     c_args += [
-        '/Ox', '/GS', '/DynamicBase',
-        '/fp:precise', 'Qimf-precision=high', '/Qprotect-parens'
+        '/Ox', '/GS', '/DynamicBase', '/fp:precise'
     ]
     link_args = ['/NXCompat', '/DynamicBase']
+
+    if cc.get_id().startswith('intel')
+        c_args += ['Qimf-precision=high', '/Qprotect-parens']
+    endif
 elif cc.get_argument_syntax() == 'gcc'
     c_args += [
         '-O3', '-Wall', '-Wextra', '-Winit-self', '-Wunused-function',
         '-Wuninitialized', '-Wmissing-declarations', '-Wstrict-prototypes',
         '-Wno-unused-parameter', '-fdiagnostics-color=auto',
         '-fstack-protector', '-fstack-protector-all', '-fpic', '-fPIC',
         '-D_FORTIFY_SOURCE=2', '-Wformat', '-Wformat-security',
-        '-fno-delete-null-pointer-checks', '-fwrapv',
-        '-fprotect-parens', '-fimf-precision=high', '-fno-fast-math',
+        '-fno-delete-null-pointer-checks', '-fwrapv', '-fno-fast-math',
         '-Wno-incompatible-function-pointer-types'
     ]
     link_args += ['-Wl,-z,noexecstack', '-Wl,-z,relro', '-Wl,-z,now']
+    if cc.get_id().startswith('intel')
+        c_args += ['-fimf-precision=high', '-fprotect-parens']
+    endif
 else
     error('Unsupported system.')
 endif

mkl_umath/src/mkl_umath_loops.c.src

@@ -151,7 +151,7 @@ static inline npy_double spacing(npy_double x) {
 }
 
 static inline npy_float spacingf(npy_float x) {
-    if (isinff(x))
+    if (isinf(x))
     return ((npy_float) NAN);
 
     return copysignf(nextafterf(fabsf(x), INFINITY), x) - x;