Skip to content

Commit e1244f9

Browse files
authored
Re-enable some tests (#727)
1 parent 6417e98 commit e1244f9

4 files changed

Lines changed: 15 additions & 20 deletions

File tree

Src/IronPythonTest/Cases/AllCPythonCasesManifest.ini

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,14 @@ Ignore=true
1717

1818
[AllCPython.test_abc]
1919
Ignore=true
20-
Reason=Blocked by https://github.com/IronLanguages/ironpython3/issues/451
20+
Reason=TypeError: __subclasscheck__() takes exactly 2 arguments (1 given)
2121

2222
[AllCPython.test_aifc]
2323
Ignore=true
2424
Reason=ImportError: No module named audioop
2525

2626
[AllCPython.test_argparse]
2727
Ignore=true
28-
Reason=Blocked by https://github.com/IronLanguages/ironpython3/issues/451
2928

3029
[AllCPython.test_array]
3130
Ignore=true
@@ -160,7 +159,6 @@ Ignore=true
160159

161160
[AllCPython.test_collections]
162161
Ignore=true
163-
Reason=Blocked by https://github.com/IronLanguages/ironpython3/issues/451
164162

165163
[AllCPython.test_compare]
166164
Ignore=true
@@ -171,7 +169,7 @@ Ignore=true
171169

172170
[AllCPython.test_compileall]
173171
Ignore=true
174-
Reason=Blocked by https://github.com/IronLanguages/ironpython3/issues/484
172+
Reason=AttributeError: 'module' object has no attribute 'symlink'
175173

176174
[AllCPython.test_complex]
177175
Ignore=true
@@ -258,7 +256,7 @@ MaxRecursion=100
258256

259257
[AllCPython.test_dis]
260258
Ignore=true
261-
Reason=Blocked by https://github.com/IronLanguages/ironpython3/issues/485
259+
Reason=IndexError: index out of range: 1
262260

263261
[AllCPython.test_distutils]
264262
Ignore=true
@@ -493,7 +491,6 @@ Ignore=true
493491

494492
[AllCPython.test_mailbox]
495493
Ignore=true
496-
Reason=Blocked by surrogateescape
497494

498495
[AllCPython.test_mailcap]
499496
Ignore=true
@@ -560,7 +557,7 @@ Reason=unittest.case.SkipTest: No module named 'nis'
560557

561558
[AllCPython.test_nntplib]
562559
Ignore=true
563-
Reason=Blocked by surrogateescape
560+
Reason=self.assertTrue(socket_closed)
564561

565562
[AllCPython.test_normalization]
566563
Ignore=true
@@ -578,7 +575,7 @@ Reason=unittest.case.SkipTest: os.openpty() not available.
578575

579576
[AllCPython.test_os]
580577
Ignore=true
581-
Reason=Blocked by https://github.com/IronLanguages/ironpython3/issues/487
578+
Reason=AttributeError: 'module' object has no attribute 'isatty'
582579

583580
[AllCPython.test_ossaudiodev]
584581
Ignore=true
@@ -590,7 +587,7 @@ Reason=ImportError: No module named parser
590587

591588
[AllCPython.test_pathlib]
592589
Ignore=true
593-
Reason=Blocked by https://github.com/IronLanguages/ironpython3/issues/484
590+
Reason=AttributeError: 'module' object has no attribute 'symlink'
594591

595592
[AllCPython.test_pdb]
596593
Ignore=true
@@ -872,7 +869,6 @@ Reason=ImportError: No module named _msi
872869

873870
[AllCPython.test_super]
874871
Ignore=true
875-
Reason=Blocked by https://github.com/IronLanguages/ironpython3/issues/451
876872

877873
[AllCPython.test_symtable]
878874
Ignore=true

Src/IronPythonTest/Cases/IronPythonCasesManifest.ini

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -258,6 +258,9 @@ RetryCount=2
258258
[IronPython.modules.misc.test_future]
259259
Ignore=true
260260

261+
[IronPython.modules.system_related.test__locale]
262+
IsolationLevel=PROCESS # changes the locale which can cause other tests to fail
263+
261264
[IronPython.modules.system_related.test_nt]
262265
RunCondition=NOT $(IS_POSIX)
263266

Tests/test_codecs_stdlib.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,8 @@ def load_tests(loader, standard_tests, pattern):
6666
suite.addTest(test.test_codecs.ExceptionChainingTest('test_init_override_is_not_wrapped'))
6767
suite.addTest(test.test_codecs.ExceptionChainingTest('test_instance_attribute_is_not_wrapped'))
6868
suite.addTest(test.test_codecs.ExceptionChainingTest('test_multiple_args_is_not_wrapped'))
69-
#suite.addTest(test.test_codecs.ExceptionChainingTest('test_new_override_is_not_wrapped')) # unbound variable: $localContext
70-
#suite.addTest(test.test_codecs.ExceptionChainingTest('test_non_str_arg_is_not_wrapped')) # unbound variable: $localContext
69+
suite.addTest(test.test_codecs.ExceptionChainingTest('test_new_override_is_not_wrapped'))
70+
suite.addTest(test.test_codecs.ExceptionChainingTest('test_non_str_arg_is_not_wrapped'))
7171
#suite.addTest(test.test_codecs.ExceptionChainingTest('test_raise_by_type')) # wrong exception
7272
#suite.addTest(test.test_codecs.ExceptionChainingTest('test_raise_by_value')) # wrong exception
7373
#suite.addTest(test.test_codecs.ExceptionChainingTest('test_raise_grandchild_subclass_exact_size')) # wrong exception

Tests/test_excinfo.py

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -390,8 +390,6 @@ def f():
390390
# __exit__ can be invoked by an except block,
391391
# but unlike a normal except, that shouldn't set sys.exc_info().
392392

393-
# https://github.com/IronLanguages/ironpython3/issues/451
394-
@unittest.skip('unbound variable: $localContext')
395393
def test_with_simple(self):
396394
"""Simple case, no exception set."""
397395
class M1(ManBase):
@@ -401,8 +399,8 @@ def __init__(self, s):
401399
with M1(self):
402400
pass
403401

404-
# https://github.com/IronLanguages/ironpython3/issues/451
405-
@unittest.skip('unbound variable: $localContext')
402+
# https://github.com/IronLanguages/ironpython3/issues/726
403+
@unittest.expectedFailure
406404
def test_with_fail(self):
407405
"""with.__exit__ doesn't see exception in exception case."""
408406
class M2(ManBase):
@@ -419,8 +417,6 @@ def __exit__(self, t, v, tb):
419417
with M2(self):
420418
raise ValueError(15)
421419

422-
# https://github.com/IronLanguages/ironpython3/issues/451
423-
@unittest.skip('unbound variable: $localContext')
424420
# call 'with' from an except block
425421
def test_with_except_pass(self):
426422
class M2(ManBase):
@@ -445,8 +441,8 @@ def __exit__(self, t, v, tb):
445441
pass
446442
self.A(15)
447443

448-
# https://github.com/IronLanguages/ironpython3/issues/451
449-
@unittest.skip('unbound variable: $localContext')
444+
# https://github.com/IronLanguages/ironpython3/issues/726
445+
@unittest.expectedFailure
450446
# call 'with' from an except block, do failure case
451447
def test_with_except_fail(self):
452448
class M2(ManBase):

0 commit comments

Comments
 (0)