feat(sonar): fix sonar lint issues

Author: Ismaestro

src/app/app.component.ts

@@ -114,7 +114,7 @@ export class AppComponent implements OnInit, OnDestroy {
       const refreshToken = this.authRepository.getRefreshTokenValue();
       if (refreshToken) {
         const refreshTokenValue = AuthService.decodeToken(refreshToken);
-        const isRefreshTokenExpired = Date.now() >= (refreshTokenValue?.exp || 0) * 1000;
+        const isRefreshTokenExpired = Date.now() >= (refreshTokenValue?.exp ?? 0) * 1000;
         if (isRefreshTokenExpired && !event.url.includes(authRoutes.logout)) {
           this.router.navigate([authRoutes.logout], {
             queryParams: {
@@ -152,9 +152,9 @@ export class AppComponent implements OnInit, OnDestroy {
 
     if (accessToken && refreshToken) {
       const accessTokenValue = AuthService.decodeToken(accessToken);
-      const isAccessTokenExpired = Date.now() >= (accessTokenValue?.exp || 0) * 1000;
+      const isAccessTokenExpired = Date.now() >= (accessTokenValue?.exp ?? 0) * 1000;
       const refreshTokenValue = AuthService.decodeToken(refreshToken);
-      const isRefreshTokenExpired = Date.now() >= (refreshTokenValue?.exp || 0) * 1000;
+      const isRefreshTokenExpired = Date.now() >= (refreshTokenValue?.exp ?? 0) * 1000;
       if (isAccessTokenExpired) {
         if (!isRefreshTokenExpired) {
           this.authService
@@ -163,7 +163,7 @@ export class AppComponent implements OnInit, OnDestroy {
               takeUntil(this.destroy$),
               catchError((error): ObservableInput<HttpEvent<unknown>> => {
                 this.navigateToLogout();
-                return observableThrowError(error);
+                throw new Error(error);
               }),
             )
             .subscribe();

src/app/modules/auth/shared/auth.service.ts

@@ -144,7 +144,7 @@ export class AuthService {
   }
 
   refreshToken(): Observable<UpdateTokenData | null> {
-    const refreshToken = this.authRepository.getRefreshTokenValue() || '';
+    const refreshToken = this.authRepository.getRefreshTokenValue() ?? '';
     return this.apollo
       .mutate({
         mutation: refreshTokenMutation,

src/app/modules/auth/store/auth.repository.ts

@@ -59,7 +59,7 @@ export class AuthRepository {
         return !!AuthService.decodeToken(token);
       }
       return false;
-    } catch (Error) {
+    } catch (error) {
       return false;
     }
   }

src/app/modules/hero/shared/hero.service.ts

@@ -73,7 +73,7 @@ export class HeroService {
       })
       .pipe(
         map((response: unknown) => {
-          return (response as CreateHeroResponse).data?.createHero || null;
+          return (response as CreateHeroResponse).data?.createHero ?? null;
         }),
       );
   }
@@ -86,7 +86,7 @@ export class HeroService {
           heroId,
         },
       })
-      .pipe(map((response: unknown) => (response as DeleteHeroResponse).data?.removeHero || null));
+      .pipe(map((response: unknown) => (response as DeleteHeroResponse).data?.removeHero ?? null));
   }
 
   voteForHero(heroId: string): Observable<Hero | null> {
@@ -99,7 +99,7 @@ export class HeroService {
       })
       .pipe(
         map((response: unknown) => {
-          return (response as VoteForHeroResponse).data?.voteHero || null;
+          return (response as VoteForHeroResponse).data?.voteHero ?? null;
         }),
       );
   }

src/app/modules/shared/components/alert/alert.component.ts

@@ -93,8 +93,8 @@ export class AlertComponent implements OnInit, OnDestroy {
   }
 
   setAlertKeys(alertData: AlertData, newAlert: Alert) {
-    newAlert.code = alertData.options?.code || undefined;
-    newAlert.delay = alertData.options?.delay || 0;
+    newAlert.code = alertData.options?.code ?? undefined;
+    newAlert.delay = alertData.options?.delay ?? 0;
   }
 
   setAlertTimeOut(newAlert: Alert) {

src/app/modules/shared/interceptors/token.interceptor.ts

@@ -54,10 +54,10 @@ export class TokenInterceptor implements HttpInterceptor {
 
   getTokenExpirations(accessToken: string, refreshToken: string) {
     const accessTokenValue = AuthService.decodeToken(accessToken);
-    const isAccessTokenExpired = Date.now() >= (accessTokenValue?.exp || 0) * 1000;
+    const isAccessTokenExpired = Date.now() >= (accessTokenValue?.exp ?? 0) * 1000;
 
     const refreshTokenValue = AuthService.decodeToken(refreshToken);
-    const isRefreshTokenExpired = Date.now() >= (refreshTokenValue?.exp || 0) * 1000;
+    const isRefreshTokenExpired = Date.now() >= (refreshTokenValue?.exp ?? 0) * 1000;
 
     return { isAccessTokenExpired, isRefreshTokenExpired };
   }
@@ -87,7 +87,9 @@ export class TokenInterceptor implements HttpInterceptor {
         this.checkUnAuthorizedError(response);
         return response;
       }),
-      catchError(err => observableThrowError(err)),
+      catchError(error => {
+        throw new Error(error);
+      }),
     );
   }
 
@@ -103,11 +105,15 @@ export class TokenInterceptor implements HttpInterceptor {
         const updateTokenRequest = request.clone({
           setHeaders: headers,
         });
-        return next.handle(updateTokenRequest).pipe(catchError(err => observableThrowError(err)));
+        return next.handle(updateTokenRequest).pipe(
+          catchError(error => {
+            throw new Error(error);
+          }),
+        );
       }),
       catchError((error): ObservableInput<HttpEvent<unknown>> => {
         this.navigateToLogout();
-        return observableThrowError(error);
+        throw new Error(error);
       }),
     );
   }

src/app/modules/user/components/change-language/change-language.component.ts

@@ -5,7 +5,6 @@ import { ApolloError } from '@apollo/client/errors';
 import { AuthService } from '~modules/auth/shared/auth.service';
 import { AlertId, AlertService } from '~modules/shared/services/alert.service';
 import { NetworkHelperService } from '~modules/shared/services/network-helper.service';
-import { AuthRepository } from '~modules/auth/store/auth.repository';
 import { NgIf } from '@angular/common';
 import { User } from '~modules/user/shared/user.model';
 import { environment } from '~environments/environment';
@@ -33,15 +32,14 @@ export class ChangeLanguageComponent implements OnInit, OnDestroy {
     private formBuilder: FormBuilder,
     private authService: AuthService,
     private alertService: AlertService,
-    private authRepository: AuthRepository,
     private utilService: NetworkHelperService,
     private document: Document,
   ) {
     this.window = this.document.defaultView as Window;
   }
 
   ngOnInit() {
-    this.language = new FormControl<string | null>(this.user?.language || AppConfig.defaultLang);
+    this.language = new FormControl<string | null>(this.user?.language ?? AppConfig.defaultLang);
     this.selectLanguageForm = this.formBuilder.group({
       language: this.language,
     });

src/app/modules/user/components/edit-profile/edit-profile.component.ts

@@ -53,11 +53,11 @@ export class EditProfileComponent implements OnInit, OnDestroy {
   }
 
   ngOnInit(): void {
-    this.firstname = new FormControl<string>(this.user?.firstname || '', [
+    this.firstname = new FormControl<string>(this.user?.firstname ?? '', [
       Validators.required,
       Validators.minLength(2),
     ]);
-    this.email = new FormControl<string>({ value: this.user?.email || '', disabled: true });
+    this.email = new FormControl<string>({ value: this.user?.email ?? '', disabled: true });
 
     this.profileForm = this.formBuilder.group({
       firstname: this.firstname,

src/app/modules/user/shared/user.service.ts

@@ -19,7 +19,7 @@ export class UserService {
       })
       .pipe(
         map((response: unknown) => {
-          return (response as GetMeResponse).data?.me || null;
+          return (response as GetMeResponse).data?.me ?? null;
         }),
       );
   }