Optimized Code

-Updated Project Structure
-Refactored naming convention
-Updated code

Author: JARVIS843

Assets/Scenes/SampleScene.unity Assets/Scenes/Test Range.unityAssets/Scenes/SampleScene.unity renamed to Assets/Scenes/Test Range.unity

@@ -123,6 +123,38 @@ NavMeshSettings:
     debug:
       m_Flags: 0
   m_NavMeshData: {fileID: 0}
+--- !u!1 &379131701
+GameObject:
+  m_ObjectHideFlags: 0
+  m_CorrespondingSourceObject: {fileID: 0}
+  m_PrefabInstance: {fileID: 0}
+  m_PrefabAsset: {fileID: 0}
+  serializedVersion: 6
+  m_Component:
+  - component: {fileID: 379131702}
+  m_Layer: 0
+  m_Name: Environment
+  m_TagString: Untagged
+  m_Icon: {fileID: 0}
+  m_NavMeshLayer: 0
+  m_StaticEditorFlags: 0
+  m_IsActive: 1
+--- !u!4 &379131702
+Transform:
+  m_ObjectHideFlags: 0
+  m_CorrespondingSourceObject: {fileID: 0}
+  m_PrefabInstance: {fileID: 0}
+  m_PrefabAsset: {fileID: 0}
+  m_GameObject: {fileID: 379131701}
+  m_LocalRotation: {x: 0, y: 0, z: 0, w: 1}
+  m_LocalPosition: {x: 24.182652, y: -6.827471, z: -9.924749}
+  m_LocalScale: {x: 1, y: 1, z: 1}
+  m_Children:
+  - {fileID: 705507995}
+  - {fileID: 2117160877}
+  m_Father: {fileID: 0}
+  m_RootOrder: 1
+  m_LocalEulerAnglesHint: {x: 0, y: 0, z: 0}
 --- !u!1 &705507993
 GameObject:
   m_ObjectHideFlags: 0
@@ -209,11 +241,11 @@ Transform:
   m_PrefabInstance: {fileID: 0}
   m_PrefabAsset: {fileID: 0}
   m_GameObject: {fileID: 705507993}
-  m_LocalRotation: {x: 0.18121976, y: -0.22497801, z: 0.8798961, w: -0.37726262}
-  m_LocalPosition: {x: 0, y: 3, z: 0}
+  m_LocalRotation: {x: 0.18121977, y: -0.22497803, z: 0.87989616, w: -0.37726265}
+  m_LocalPosition: {x: -24.182652, y: 9.827471, z: 9.924749}
   m_LocalScale: {x: 1, y: 1, z: 1}
   m_Children: []
-  m_Father: {fileID: 0}
+  m_Father: {fileID: 379131702}
   m_RootOrder: 0
   m_LocalEulerAnglesHint: {x: 15.021, y: -329.606, z: -129.483}
 --- !u!1 &963194225
@@ -305,7 +337,7 @@ Mesh:
   m_CorrespondingSourceObject: {fileID: 0}
   m_PrefabInstance: {fileID: 0}
   m_PrefabAsset: {fileID: 0}
-  m_Name: pb_Mesh17438
+  m_Name: pb_Mesh17238
   serializedVersion: 10
   m_SubMeshes:
   - serializedVersion: 2
@@ -793,11 +825,11 @@ Transform:
   m_PrefabInstance: {fileID: 0}
   m_PrefabAsset: {fileID: 0}
   m_GameObject: {fileID: 2117160872}
-  m_LocalRotation: {x: 0, y: 0, z: 0, w: 1}
-  m_LocalPosition: {x: 0, y: 0, z: 0}
+  m_LocalRotation: {x: -0, y: -0, z: -0, w: 1}
+  m_LocalPosition: {x: -24.182652, y: 6.827471, z: 9.924749}
   m_LocalScale: {x: 1, y: 1, z: 1}
   m_Children: []
-  m_Father: {fileID: 0}
+  m_Father: {fileID: 379131702}
   m_RootOrder: 1
   m_LocalEulerAnglesHint: {x: 0, y: 0, z: 0}
 --- !u!4 &117881535607494348
@@ -1670,14 +1702,14 @@ Transform:
   m_PrefabAsset: {fileID: 0}
   m_GameObject: {fileID: 4416926081799734643}
   m_LocalRotation: {x: 0, y: 0.7071068, z: 0, w: 0.7071068}
-  m_LocalPosition: {x: 9.46, y: 0.25, z: -9.42}
+  m_LocalPosition: {x: 9, y: 0.25, z: -9}
   m_LocalScale: {x: 1, y: 1, z: 1}
   m_Children:
   - {fileID: 963194228}
   - {fileID: 8002264680499780379}
   - {fileID: 272993188726808912}
   m_Father: {fileID: 0}
-  m_RootOrder: 2
+  m_RootOrder: 0
   m_LocalEulerAnglesHint: {x: 0, y: 90, z: 0}
 --- !u!4 &3964097221779534387
 Transform:
@@ -1928,10 +1960,10 @@ MonoBehaviour:
   m_EditorClassIdentifier: 
   AnimBlendSpeed: 8.9
   MouseSensitivity: 21.9
-  upperLimit: -40
-  bottomlimit: 70
+  UpperLimit: -40
+  Bottomlimit: 70
   CamHolder: {fileID: 8338988566224911407}
-  FPV: {fileID: 963194228}
+  Camera: {fileID: 963194228}
 --- !u!114 &4416926081799734648
 MonoBehaviour:
   m_ObjectHideFlags: 0

Assets/Scenes/SampleScene.unity.meta Assets/Scenes/Test Range.unity.metaAssets/Scenes/SampleScene.unity.meta renamed to Assets/Scenes/Test Range.unity.meta

@@ -0,0 +1,85 @@
+using UnityEngine;
+using UnityEngine.InputSystem;
+using UnityEngine.InputSystem.Interactions;
+
+namespace UnityTutorial.Manager
+{
+    public class InputManager : MonoBehaviour
+    {
+        [SerializeField] private PlayerInput PlayerInput;
+
+        public Vector2 Move {get; private set;}
+        public Vector2 Look {get; private set;}
+        public bool Run {get; private set;}
+
+
+
+        private InputActionMap _currentMap;
+        private InputAction _moveAction;
+        private InputAction _lookAction;
+        private InputAction _runAction;
+
+
+
+       private void Awake()
+        {
+            HideCursor();
+            AssignReferences();
+            SubscribeKeys();
+        }
+
+        private static void HideCursor()
+        {
+            Cursor.visible = false;
+            Cursor.lockState = CursorLockMode.Locked;
+        }
+
+        private void SubscribeKeys()
+        {
+            _moveAction.performed += onMove;
+            _lookAction.performed += onLook;
+            _runAction.performed += onRun;
+
+
+            _moveAction.canceled += onMove;
+            _lookAction.canceled += onLook;
+            _runAction.canceled += onRun;
+        }
+
+        private void AssignReferences()
+       {
+           _currentMap = PlayerInput.currentActionMap;
+           _moveAction = _currentMap.FindAction("Move");
+           _lookAction = _currentMap.FindAction("Look");
+           _runAction = _currentMap.FindAction("Run");
+       }
+
+       private void onMove(InputAction.CallbackContext context)
+       {
+           Move = context.ReadValue<Vector2>();
+       }
+
+        private void onLook(InputAction.CallbackContext context)
+        {
+           Look = context.ReadValue<Vector2>();
+        }
+
+        private void onRun(InputAction.CallbackContext context)
+        {
+            Run = context.ReadValueAsButton();
+        }
+
+
+
+
+        private void OnEnable() {
+            _currentMap.Enable();
+        }
+
+        private void onDisable()
+        {
+            _currentMap.Disable();
+        }
+        
+    }
+}

Assets/_Scripts/InputManager.cs

@@ -0,0 +1,92 @@
+using System;
+using System.Collections;
+using System.Collections.Generic;
+using UnityEngine;
+using UnityTutorial.Manager;
+
+namespace UnityTutorial.PlayerControl
+{
+    public class PlayerController : MonoBehaviour
+    {
+        [SerializeField] private float AnimBlendSpeed = 0.5f;
+        [SerializeField] private float MouseSensitivity = 10f;
+        [SerializeField] private float UpperLimit = -40f;
+        [SerializeField] private float Bottomlimit = 70f;
+        [SerializeField] private Transform CamHolder;
+        [SerializeField] private Transform Camera;
+
+        //Essential Constants
+        private const float _runSpeed = 6f;
+        private const float _walkSpeed = 2f;
+
+        //Variables
+        private Vector2 _currrentVelocity;
+        private float _xRotation;
+        private float _yRotation;
+        private bool _hasAnimator;
+        private Animator _animator;
+        private int _xVelHash;
+        private int _yVelHash;
+
+        //Components
+        private Rigidbody _playerRigidbody;
+        private InputManager _inputManager;
+
+
+
+        private void Start() {
+            _hasAnimator = TryGetComponent<Animator>(out _animator);
+            _playerRigidbody = GetComponent<Rigidbody>();
+            _inputManager = GetComponent<InputManager>();
+
+
+            _xVelHash = Animator.StringToHash("X_Velocity");
+            _yVelHash = Animator.StringToHash("Y_Velocity");
+        }
+
+
+        private void FixedUpdate() 
+        {
+            Move();
+        }
+
+        private void LateUpdate() 
+        {
+            CamMovements();
+        }
+
+        private void Move()
+        {
+            if(!_hasAnimator) return;
+            
+            float targetSpeed = _inputManager.Run ? _runSpeed : _walkSpeed;
+            if(_inputManager.Move == Vector2.zero) targetSpeed = 0.1f;
+
+            _currrentVelocity.x = Mathf.Lerp(_currrentVelocity.x , _inputManager.Move.x * targetSpeed, AnimBlendSpeed * Time.fixedDeltaTime);
+            _currrentVelocity.y = Mathf.Lerp(_currrentVelocity.y , _inputManager.Move.y * targetSpeed, AnimBlendSpeed * Time.fixedDeltaTime);
+
+            var xVelDifference = _currrentVelocity.x - _playerRigidbody.velocity.x;
+            var zVelDifference = _currrentVelocity.y - _playerRigidbody.velocity.z;
+            _playerRigidbody.AddForce(transform.TransformVector(new Vector3(xVelDifference, 0 , zVelDifference)), ForceMode.VelocityChange);
+            
+            _animator.SetFloat(_xVelHash, _currrentVelocity.x);
+            _animator.SetFloat(_yVelHash, _currrentVelocity.y);
+        }
+
+        private void CamMovements()
+        {
+            if(!_hasAnimator) return;
+
+            var Mouse_X = _inputManager.Look.x;
+            var Mouse_Y = _inputManager.Look.y;
+            Camera.position = CamHolder.position;
+
+            _xRotation -= Mouse_Y * MouseSensitivity * Time.deltaTime;
+            _xRotation = Mathf.Clamp(_xRotation, UpperLimit , Bottomlimit);
+
+            Camera.localRotation = Quaternion.Euler(_xRotation, 0 , 0 );
+            transform.Rotate(Vector3.up, Mouse_X * MouseSensitivity * Time.deltaTime);
+        }
+
+    }
+}