Support diffing uses-permission counts

There might be significant differences in blame attribution for AndroidManifest.xml. We usually pay close attention to changes in versionCode, targetSdk, and the count of uses-permissions. Adding an extra line to display the result.

Author: Goooler

CHANGELOG.md

@@ -5,6 +5,7 @@
 
 **Added**
 - Add `--summary-only` flag.
+- Support diffing uses-permission counts.
 
 **Fixed**
 - Significantly improve `.jar` diff performance.

formats/api/formats.api

@@ -44,8 +44,9 @@ public final class com/jakewharton/diffuse/format/Aar$Companion {
 public final class com/jakewharton/diffuse/format/AndroidManifest {
 	public static final field Companion Lcom/jakewharton/diffuse/format/AndroidManifest$Companion;
 	public static final field NAME Ljava/lang/String;
-	public synthetic fun <init> (Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/Long;Lkotlin/jvm/internal/DefaultConstructorMarker;)V
+	public synthetic fun <init> (Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/Long;ILkotlin/jvm/internal/DefaultConstructorMarker;)V
 	public final fun getPackageName ()Ljava/lang/String;
+	public final fun getUsesPermissionCount ()I
 	public final fun getVersionCode ()Ljava/lang/Long;
 	public final fun getVersionName ()Ljava/lang/String;
 	public final fun getXml ()Ljava/lang/String;

formats/src/main/kotlin/com/jakewharton/diffuse/format/AndroidManifest.kt

@@ -37,6 +37,7 @@ private constructor(
   val packageName: String,
   val versionName: String?,
   val versionCode: Long?,
+  val usesPermissionCount: Int,
 ) {
   companion object {
     const val NAME = "AndroidManifest.xml"
@@ -176,8 +177,15 @@ private constructor(
         } else {
           null
         }
-
-      return AndroidManifest(toFormattedXml(), packageName, versionName, versionCode)
+      val usesPermissionCount = manifestElement.getElementsByTagName("uses-permission").length
+
+      return AndroidManifest(
+        toFormattedXml(),
+        packageName,
+        versionName,
+        versionCode,
+        usesPermissionCount,
+      )
     }
 
     private fun Document.toFormattedXml() = buildString {

reports/src/main/kotlin/com/jakewharton/diffuse/diff/ManifestDiff.kt

@@ -9,7 +9,8 @@ internal class ManifestDiff(val oldManifest: AndroidManifest, val newManifest: A
   internal val parsedPropertiesChanged =
     oldManifest.packageName != newManifest.packageName ||
       oldManifest.versionName != newManifest.versionName ||
-      oldManifest.versionCode != newManifest.versionCode
+      oldManifest.versionCode != newManifest.versionCode ||
+      oldManifest.usesPermissionCount != newManifest.usesPermissionCount
 
   val diff: List<String> = run {
     val oldLines = oldManifest.xml.lines()
@@ -36,6 +37,11 @@ internal fun ManifestDiff.toDetailReport() = buildString {
         row("package", oldManifest.packageName, newManifest.packageName)
         row("version code", oldManifest.versionCode, newManifest.versionCode)
         row("version name", oldManifest.versionName, newManifest.versionName)
+        row(
+          "uses-permission count",
+          oldManifest.usesPermissionCount,
+          newManifest.usesPermissionCount,
+        )
       }
     )
   }