feat: skip the length check if lineLimit not greater than 0

lineLimit has been initialized to 80 at the beginning,
a value no greater than 0 is an intentional user config.
Now it is no longer set to default 80 as an outlier,
but just disabling the check.

Author: JayceChant

validator/validate.go

@@ -69,10 +69,6 @@ func validateMsg(msg string, config *globalConfig) {
 
 	sections := strings.SplitN(msg, "\n", 2)
 
-	if config.LineLimit <= 0 {
-		config.LineLimit = 80
-	}
-
 	checkHeader(sections[0], config)
 
 	if len(sections) == 2 {
@@ -123,7 +119,8 @@ func checkHeader(header string, config *globalConfig) {
 	// subject := groups[5]
 
 	length := len(header)
-	if length > config.LineLimit &&
+	if config.LineLimit > 0 &&
+		length > config.LineLimit &&
 		!(isFixupOrSquash || typ == "revert" || typ == "Revert") {
 		state.LineOverLong.LogAndExit(length, config.LineLimit, header)
 	}
@@ -178,7 +175,8 @@ func checkBody(body string, config *globalConfig) {
 
 	for _, line := range strings.Split(body, "\n") {
 		length := len(line)
-		if length > config.LineLimit {
+		if config.LineLimit > 0 &&
+			length > config.LineLimit {
 			state.LineOverLong.LogAndExit(length, config.LineLimit, line)
 		}
 	}

validator/validate_test.go

@@ -11,6 +11,7 @@ import (
 )
 
 var (
+	zeroCfg         = &globalConfig{}
 	defaultCfg      = &globalConfig{Lang: "en", BodyRequired: true, LineLimit: 80}
 	scopeRequired   = &globalConfig{ScopeRequired: true}
 	scopesSpecified = &globalConfig{Scopes: []string{"model", "view", "controller"}}
@@ -116,6 +117,8 @@ func TestCheckHeader(t *testing.T) {
 		{"test: ", "bad_header_no_title", defaultCfg, int(state.BadHeaderFormat)},
 		{"feat: something changes", "scope_missing", scopeRequired, int(state.ScopeMissing)},
 		{"feat( ): something changes", "empty_scope", scopeRequired, int(state.BadHeaderFormat)},
+		{"feat: header that too lonnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnng", "header_too_long", defaultCfg, int(state.LineOverLong)},
+		{"feat: header that too lonnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnng", "header_length_no_limit", zeroCfg, 0},
 	}
 	for _, tt := range headerCases {
 		assertExitCode(t, func() {
@@ -126,18 +129,20 @@ func TestCheckHeader(t *testing.T) {
 
 func TestCheckBody(t *testing.T) {
 	var bodyCases = []struct {
-		text string
-		name string
-		want int
+		text   string
+		name   string
+		config *globalConfig
+		want   int
 	}{
-		{"", "body_missing", int(state.BodyMissing)},
-		{"body", "no_empty_line", int(state.NoBlankLineBeforeBody)},
-		{"\r\na body with too looooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooong line", "line_over_long", int(state.LineOverLong)},
-		{"\r\nnormal body", "normal", 0},
+		{"", "body_missing", defaultCfg, int(state.BodyMissing)},
+		{"body", "no_blank_line", defaultCfg, int(state.NoBlankLineBeforeBody)},
+		{"\r\na body with too looooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooong line", "body_line_over_long", defaultCfg, int(state.LineOverLong)},
+		{"\r\na body with too looooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooong line", "body_line_no_limit", zeroCfg, 0},
+		{"\r\nnormal body", "normal", defaultCfg, 0},
 	}
 	for _, tt := range bodyCases {
 		assertExitCode(t, func() {
-			checkBody(tt.text, defaultCfg)
+			checkBody(tt.text, tt.config)
 		}, tt.name, tt.want)
 	}
 }