From 462e44573f91890fc0b9e099dfa2b065715e7fa8 Mon Sep 17 00:00:00 2001 From: fuguikz <2514883828@qq.com> Date: Sat, 3 Jan 2026 07:47:26 +0800 Subject: [PATCH] tests: make assertions platform-neutral --- .../CultureInfoAttributeTests.cs | 2 +- .../TypeConverterFactoryTests.cs | 18 ++++++------------ .../MultipleFieldsFromOnePropertyTests.cs | 9 ++++++--- 3 files changed, 13 insertions(+), 16 deletions(-) diff --git a/tests/CsvHelper.Tests/Mappings/ConstructorParameter/CultureInfoAttributeTests.cs b/tests/CsvHelper.Tests/Mappings/ConstructorParameter/CultureInfoAttributeTests.cs index 5766f83e1..0a2cf9a61 100644 --- a/tests/CsvHelper.Tests/Mappings/ConstructorParameter/CultureInfoAttributeTests.cs +++ b/tests/CsvHelper.Tests/Mappings/ConstructorParameter/CultureInfoAttributeTests.cs @@ -190,7 +190,7 @@ private class NoAttribute public decimal Amount { get; set; } } - [CultureInfo("invalid")] + [CultureInfo("invalid!")] private class InvalidAttribute { [CultureInfo("fr-FR")] diff --git a/tests/CsvHelper.Tests/TypeConversion/TypeConverterFactoryTests.cs b/tests/CsvHelper.Tests/TypeConversion/TypeConverterFactoryTests.cs index 8316537dd..c40ab27c6 100644 --- a/tests/CsvHelper.Tests/TypeConversion/TypeConverterFactoryTests.cs +++ b/tests/CsvHelper.Tests/TypeConversion/TypeConverterFactoryTests.cs @@ -34,14 +34,11 @@ public void ReadTypeConverterGenericInt() [Fact] public void WriteTypeConverterGenericInt() { - var expected = """ - MaybeNumber - 42 - - """; - var stringWriter = new StringWriter(); using var cw = new CsvWriter(stringWriter, CultureInfo.InvariantCulture); + var expected = new TestStringBuilder(cw.Configuration.NewLine); + expected.AppendLine("MaybeNumber"); + expected.AppendLine("42"); cw.Context.TypeConverterCache.AddConverter(new MyOptionTypeFactory.OptionConverter()); cw.WriteRecords(new[] { @@ -68,14 +65,11 @@ public void ReadTypeConverterFactory() [Fact] public void WriteTypeConverterFactory() { - var expected = """ - MaybeNumber - 42 - - """; - var stringWriter = new StringWriter(); using var cw = new CsvWriter(stringWriter, CultureInfo.InvariantCulture); + var expected = new TestStringBuilder(cw.Configuration.NewLine); + expected.AppendLine("MaybeNumber"); + expected.AppendLine("42"); cw.Context.TypeConverterCache.AddConverterFactory(new MyOptionTypeFactory()); cw.WriteRecords(new[] { diff --git a/tests/CsvHelper.Tests/Writing/MultipleFieldsFromOnePropertyTests.cs b/tests/CsvHelper.Tests/Writing/MultipleFieldsFromOnePropertyTests.cs index d991af30f..e481bc3b8 100644 --- a/tests/CsvHelper.Tests/Writing/MultipleFieldsFromOnePropertyTests.cs +++ b/tests/CsvHelper.Tests/Writing/MultipleFieldsFromOnePropertyTests.cs @@ -19,23 +19,26 @@ public class MultipleFieldsFromOnePropertyTests [Fact] public void WriteMultipleFieldsFromSinglePropertyTest() { + var culture = new CultureInfo("en-US"); + using (var stream = new MemoryStream()) using (var reader = new StreamReader(stream)) using (var writer = new StreamWriter(stream)) - using (var csv = new CsvWriter(writer, new CultureInfo("en-US"))) + using (var csv = new CsvWriter(writer, culture)) { var records = new List { - new Test { Dob = DateTime.Parse("9/6/2017", new CultureInfo("en-US")) } + new Test { Dob = DateTime.Parse("9/6/2017", culture) } }; csv.Context.RegisterClassMap(); csv.WriteRecords(records); writer.Flush(); stream.Position = 0; + var dobText = records[0].Dob.ToString(culture); var expected = new TestStringBuilder(csv.Configuration.NewLine); expected.AppendLine("A,B,C"); - expected.AppendLine("9/6/2017 12:00:00 AM,9/6/2017 12:00:00 AM,9/6/2017 12:00:00 AM"); + expected.AppendLine($"{dobText},{dobText},{dobText}"); Assert.Equal(expected.ToString(), reader.ReadToEnd()); }