deprecate convert (#397)

Author: mzgubic

Project.toml

@@ -1,6 +1,6 @@
 name = "ChainRulesCore"
 uuid = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"
-version = "0.10.12"
+version = "0.10.13"
 
 [deps]
 Compat = "34da2185-b29b-5c13-b0c7-acf172513d20"

src/deprecated.jl

@@ -1,3 +1,5 @@
+import Base: convert
+
 Base.@deprecate_binding NO_FIELDS NoTangent()
 
 const EXTERN_DEPRECATION = "`extern` is deprecated, use `unthunk` or `backing` instead, " *
@@ -56,4 +58,8 @@ for T in (:Thunk, :InplaceableThunk)
 end
 
 
-Base.@deprecate InplaceableThunk(t::Thunk, add!) InplaceableThunk(add!, t)
+Base.@deprecate InplaceableThunk(t::Thunk, add!) InplaceableThunk(add!, t)
+
+Base.@deprecate convert(::Type{<:Tuple}, t::Tangent{<:Any, <:Tuple}) backing(t)
+Base.@deprecate convert(::Type{<:NamedTuple}, t::Tangent{<:Any, <:NamedTuple}) backing(t)
+Base.@deprecate convert(::Type{<:Dict}, t::Tangent{<:Dict, <:Dict}) backing(t)

src/differentials/composite.jl

@@ -68,10 +68,6 @@ function Base.show(io::IO, comp::Tangent{P}) where P
     end
 end
 
-Base.convert(::Type{<:NamedTuple}, comp::Tangent{<:Any, <:NamedTuple}) = backing(comp)
-Base.convert(::Type{<:Tuple}, comp::Tangent{<:Any, <:Tuple}) = backing(comp)
-Base.convert(::Type{<:Dict}, comp::Tangent{<:Dict, <:Dict}) = backing(comp)
-
 Base.getindex(comp::Tangent, idx) = getindex(backing(comp), idx)
 
 # for Tuple

test/deprecated.jl

@@ -36,4 +36,10 @@ end
 
 @testset "Deprecated: Inplacable Thunk argument order" begin
     @test (@test_deprecated InplaceableThunk(@thunk([1]), x->x.+=1)) isa InplaceableThunk
-end
+end
+
+@testset "Deprecated: convert from Tangent" begin
+    @test (@test_deprecated convert(NamedTuple, Tangent{Foo}(x=2.5))) == (; x=2.5)
+    @test (@test_deprecated convert(Tuple, Tangent{Tuple{Float64,}}(2.0))) == (2.0,)
+    @test (@test_deprecated convert(Dict, Tangent{Dict}(Dict(4 => 3)))) == Dict(4 => 3)
+end

test/differentials/composite.jl

@@ -22,11 +22,6 @@ end
     @testset "empty types" begin
         @test typeof(Tangent{Tuple{}}()) == Tangent{Tuple{}, Tuple{}}
     end
-    @testset "convert" begin
-        @test convert(NamedTuple, Tangent{Foo}(x=2.5)) == (; x=2.5)
-        @test convert(Tuple, Tangent{Tuple{Float64,}}(2.0)) == (2.0,)
-        @test convert(Dict, Tangent{Dict}(Dict(4 => 3))) == Dict(4 => 3)
-    end
 
     @testset "==" begin
         @test Tangent{Foo}(x=0.1, y=2.5) == Tangent{Foo}(x=0.1, y=2.5)