supporting AbstractArray in general instead of Vector only

Author: schlichtanders

Changelog.md

@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## [2.0.0] - ?????
 ### Added
 - `Base.get` and `Base.getindex` are now both implemented for `Const` (like they are implemented already for `Identity`), to simplify working with `Const`.
+- Vector conversions (`convert`) are now more generic and support AbstractArray in general 
 
 ### Fixed
 - `Option(3)` works now

src/convert.jl

@@ -1,14 +1,17 @@
 # conversions among concrete types
 # ================================
 
-# Vector
-# ------
+# AbstractVector
+# --------------
+
+# Because `AbstractVector <: AbstractArray`, and more especially `Base.typename(Vector) == Array`,
+# we are dispatching on AbstractArray instead of AbstractVector
 
-Base.convert(::Type{<:Vector}, x::Identity) = [x.value]
-Base.convert(::Type{<:Vector}, x::Nothing) = []
-Base.convert(::Type{<:Vector}, x::Const) = []
+Base.convert(T::Type{<:AbstractArray}, x::Identity) = convert(T, [x.value])
+Base.convert(T::Type{<:AbstractArray}, x::Const) = convert(T, [])
 # ContextManager is executed if someone asks for a Vector from ContextManager
-Base.convert(::Type{<:Vector}, x::ContextManager) = [x(identity)]
+Base.convert(T::Type{<:AbstractArray}, x::ContextManager) = convert(T, [x(identity)])
+
 
 # Const
 # -----
@@ -18,6 +21,7 @@ function Base.convert(::Type{Const}, x::Vector)
   Const(nothing)  # == Option()
 end
 
+
 # Identity
 # --------
 
@@ -48,7 +52,10 @@ Base.convert(::Type{Either{L, R}}, x::Identity{R}) where {L, R} = x  # nothing t
 Base.convert(::Type{Either{L, R}}, x::Const) where {L, R} = Const(Base.convert(L, x.value))
 Base.convert(::Type{Either{L, R}}, x::Const{L}) where {L, R} = x  # nothing to convert
 
-Base.convert(::Type{Either{<:Any, R}}, x::Identity) where {R} = Identity(Base.convert(R, x.value))
 Base.convert(::Type{Either{<:Any, R}}, x::Identity{R}) where {R} = x  # nothing to convert
-Base.convert(::Type{Either{L, <:Any}}, x::Const) where {L} = Const(Base.convert(L, x.value))
+Base.convert(::Type{Either{<:Any, R}}, x::Identity) where {R} = Identity(Base.convert(R, x.value))
 Base.convert(::Type{Either{L, <:Any}}, x::Const{L}) where {L} = x  # nothing to convert
+Base.convert(::Type{Either{L, <:Any}}, x::Const) where {L} = Const(Base.convert(L, x.value))
+
+Base.convert(::Type{Either}, x::Identity) = x
+Base.convert(::Type{Either}, x::Const) = x