changed animation end time setup > now get end time via pointer

Author: robertdorn83

Editor/Scripts/Interactivity/VisualScriptingExport/UnitExporters/Animations/AnimationPlayNode.cs

@@ -75,8 +75,14 @@ public bool InitializeInteractivityNodes(UnitExporter unitExporter)
             node.ValueInConnection[Animation_StartNode.IdValueSpeed].Value = 1f;
             node.ValueInConnection[Animation_StartNode.IdValueStartTime].Value = 0.0f;
 
-            node.ValueInConnection[Animation_StartNode.IdValueEndtime].Value =
-                (clip != null && !clip.isLooping) ? clip.length : float.PositiveInfinity;
+            if (clip != null && !clip.isLooping)
+            {
+                var animationLength = AnimationHelper.GetAnimationLength(unitExporter, animationId);
+                node.ValueIn(Animation_StartNode.IdValueEndtime).ConnectToSource(animationLength);
+
+            }
+            else
+                node.ValueIn(Animation_StartNode.IdValueEndtime).SetValue(float.PositiveInfinity);
 
             unitExporter.MapInputPortToSocketName(unit.enter, Animation_StartNode.IdFlowIn, node);
             // There should only be one output flow from the Animator.Play node

Editor/Scripts/Interactivity/VisualScriptingExport/UnitExporters/Animations/AnimatorPlayNode.cs

@@ -64,22 +64,37 @@ public bool InitializeInteractivityNodes(UnitExporter unitExporter)
             AnimationClip clip = animationState.motion as AnimationClip;
             bool isReversed = animationState.speed < 0 && !unitExporter.Context.exporter.BakeAnimationSpeed;
 
-            float clipLength = clip.length;
-            
-            float startTime = 0;
-            float endTime = clipLength;
+    
             if (clip != null && clip.isLooping)
             {
-                startTime = isReversed ? clipLength : 0;
-                endTime = isReversed ? float.NegativeInfinity : float.PositiveInfinity;
+                if (isReversed)
+                {
+                    var clipLengthRef = AnimationHelper.GetAnimationLength(unitExporter, animationId);
+                    node.ValueIn(Animation_StartNode.IdValueStartTime).ConnectToSource(clipLengthRef);
+                    node.ValueIn(Animation_StartNode.IdValueEndtime).SetValue(float.NegativeInfinity);
+                    
+                }
+                else
+                {
+                    node.ValueIn(Animation_StartNode.IdValueStartTime).SetValue(0f);
+                    node.ValueIn(Animation_StartNode.IdValueEndtime).SetValue(float.PositiveInfinity);
+        
+                }
             }
             else if (isReversed)
             {
-                startTime = clipLength;
-                endTime = 0;
+                var clipLengthRef = AnimationHelper.GetAnimationLength(unitExporter, animationId);
+                node.ValueIn(Animation_StartNode.IdValueStartTime).ConnectToSource(clipLengthRef);
+                node.ValueIn(Animation_StartNode.IdValueEndtime).SetValue(0f);
+            }
+            else
+            {
+                var clipLengthRef = AnimationHelper.GetAnimationLength(unitExporter, animationId);
+                node.ValueIn(Animation_StartNode.IdValueStartTime).SetValue(0f);
+                node.ValueIn(Animation_StartNode.IdValueEndtime).ConnectToSource(clipLengthRef);
+                
             }
 
-            node.ValueInConnection[Animation_StartNode.IdValueStartTime].Value = startTime;
 
             var otherAnimationStates = AnimatorHelper.GetAllAnimationStates(target);
             var stopSequence = unitExporter.CreateNode<Flow_SequenceNode>();
@@ -109,7 +124,6 @@ public bool InitializeInteractivityNodes(UnitExporter unitExporter)
             var lastSequenceFlow = stopSequence.FlowOut("zzz");
             lastSequenceFlow.ConnectToFlowDestination(node.FlowIn(Animation_StartNode.IdFlowIn));
 
-            node.ValueInConnection[Animation_StartNode.IdValueEndtime].Value = endTime;
 
             // There should only be one output flow from the Animator.Play node
             unitExporter.MapOutFlowConnectionWhenValid(unit.exit, Animation_StartNode.IdFlowOut, node);

Editor/Scripts/Interactivity/VisualScriptingExport/UnitExporters/Helpers/AnimationHelper.cs

@@ -0,0 +1,17 @@
+using UnityGLTF.Interactivity.Export;
+using UnityGLTF.Interactivity.Schema;
+
+namespace UnityGLTF.Interactivity.VisualScripting.Export
+{
+    public static class AnimationHelper
+    {
+        public static ValueOutRef GetAnimationLength(UnitExporter unitExporter, int animationId)
+        {
+            var pointerLength = unitExporter.CreateNode<Pointer_GetNode>();
+            PointersHelper.SetupPointerTemplateAndTargetInput(pointerLength, "index", "/animations/{index}/extensions/KHR_interactivity/maxTime", GltfTypes.Float);
+            pointerLength.ValueIn("index").SetValue(animationId);
+            return pointerLength.FirstValueOut();
+        }
+        
+    }
+}