From e1d48f0c7a5ece6f0394758adbc6db002635c91d Mon Sep 17 00:00:00 2001 From: butchhartman Date: Tue, 12 Aug 2025 12:13:44 -0700 Subject: [PATCH 1/2] Fixed CMake argument omission causing build failure in Shader modules chapter --- .../02_Graphics_pipeline_basics/01_Shader_modules.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/en/03_Drawing_a_triangle/02_Graphics_pipeline_basics/01_Shader_modules.adoc b/en/03_Drawing_a_triangle/02_Graphics_pipeline_basics/01_Shader_modules.adoc index 595e3f8a..fcec2734 100644 --- a/en/03_Drawing_a_triangle/02_Graphics_pipeline_basics/01_Shader_modules.adoc +++ b/en/03_Drawing_a_triangle/02_Graphics_pipeline_basics/01_Shader_modules.adoc @@ -326,7 +326,7 @@ CMake function: [,cmake] ---- function (add_slang_shader_target TARGET) - cmake_parse_arguments ("SHADER" "" "SOURCES" ${ARGN}) + cmake_parse_arguments ("SHADER" "" "SOURCES" "" ${ARGN}) set (SHADERS_DIR ${CMAKE_CURRENT_LIST_DIR}/shaders) set (ENTRY_POINTS -entry vertMain -entry fragMain) add_custom_command ( From 459dafb4e14bfce8ed30b3e78d4707739f458e7f Mon Sep 17 00:00:00 2001 From: butchhartman Date: Tue, 12 Aug 2025 12:34:23 -0700 Subject: [PATCH 2/2] Set SOURCES as a multi value keyword --- .../02_Graphics_pipeline_basics/01_Shader_modules.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/en/03_Drawing_a_triangle/02_Graphics_pipeline_basics/01_Shader_modules.adoc b/en/03_Drawing_a_triangle/02_Graphics_pipeline_basics/01_Shader_modules.adoc index fcec2734..c26edb56 100644 --- a/en/03_Drawing_a_triangle/02_Graphics_pipeline_basics/01_Shader_modules.adoc +++ b/en/03_Drawing_a_triangle/02_Graphics_pipeline_basics/01_Shader_modules.adoc @@ -326,7 +326,7 @@ CMake function: [,cmake] ---- function (add_slang_shader_target TARGET) - cmake_parse_arguments ("SHADER" "" "SOURCES" "" ${ARGN}) + cmake_parse_arguments ("SHADER" "" "" "SOURCES" ${ARGN}) set (SHADERS_DIR ${CMAKE_CURRENT_LIST_DIR}/shaders) set (ENTRY_POINTS -entry vertMain -entry fragMain) add_custom_command (