Rename commands page to "instrumentation" (#3663)

The distinction between the build commands page (which exclusively
displays instrumentation data) and the build targets page (which is
currently only useful if instrumentation data was submitted, but is
intended to be used without instrumentation in the future) is currently
unclear to users. This PR renames the build commands page to build
"instrumentation".

Author: williamjallen

app/Http/Controllers/BuildController.php

@@ -59,13 +59,13 @@ public function build(Request $request, int $build_id): View
         return $this->vue('build-build-page', 'Build', $params);
     }
 
-    public function commands(int $build_id): View
+    public function instrumentation(int $build_id): View
     {
         $this->setBuildById($build_id);
 
         $filters = json_decode(request()->query('filters')) ?? ['all' => []];
 
-        return $this->vue('build-commands-page', 'Commands', [
+        return $this->vue('build-instrumentation-page', 'Instrumentation', [
             'build-id' => $this->build->Id,
             'initial-filters' => $filters,
         ]);

resources/js/vue/app.js

@@ -28,7 +28,7 @@ const app = Vue.createApp({
     UsersPage: Vue.defineAsyncComponent(() => import('./components/UsersPage.vue')),
     BuildFilesPage: Vue.defineAsyncComponent(() => import('./components/BuildFilesPage.vue')),
     BuildTargetsPage: Vue.defineAsyncComponent(() => import('./components/BuildTargetsPage.vue')),
-    BuildCommandsPage: Vue.defineAsyncComponent(() => import('./components/BuildCommandsPage.vue')),
+    BuildInstrumentationPage: Vue.defineAsyncComponent(() => import('./components/BuildInstrumentationPage.vue')),
     BuildBuildPage: Vue.defineAsyncComponent(() => import('./components/BuildBuildPage.vue')),
     CoverageFilePage: Vue.defineAsyncComponent(() => import('./components/CoverageFilePage.vue')),
     BuildCoveragePage: Vue.defineAsyncComponent(() => import('./components/BuildCoveragePage.vue')),

…/js/vue/components/BuildCommandsPage.vue …/components/BuildInstrumentationPage.vueresources/js/vue/components/BuildCommandsPage.vue renamed to resources/js/vue/components/BuildInstrumentationPage.vue resources/js/vue/components/BuildCommandsPage.vue renamed to resources/js/vue/components/BuildInstrumentationPage.vue

@@ -81,11 +81,11 @@
           data-test="sidebar-notes"
         />
         <build-sidebar-item
-          :href="`${$baseURL}/builds/${buildId}/commands`"
+          :href="`${$baseURL}/builds/${buildId}/instrumentation`"
           title="Instrumentation"
           :icon="FA.faGaugeHigh"
           :selected="activeTab === 'instrumentation'"
-          :disabled="commandsDisabled"
+          :disabled="instrumentationDisabled"
           data-test="sidebar-instrumentation"
         />
         <build-sidebar-item
@@ -255,7 +255,7 @@ export default {
     notesDisabled() {
       return !this.build || !this.build.notes || this.build.notes.pageInfo.total === 0;
     },
-    commandsDisabled() {
+    instrumentationDisabled() {
       return !this.build || !this.build.commands || this.build.commands.pageInfo.total === 0;
     },
     targetsDisabled() {

resources/js/vue/components/shared/BuildSidebar.vue

@@ -131,8 +131,9 @@
 Route::get('/builds/{build_id}/targets', 'BuildController@targets')
     ->whereNumber('build_id');
 
-Route::get('/builds/{build_id}/commands', 'BuildController@commands')
+Route::get('/builds/{build_id}/instrumentation', 'BuildController@instrumentation')
     ->whereNumber('build_id');
+Route::permanentRedirect('/build/{build_id}/commands', url('/builds/{build_id}/instrumentation'));
 
 Route::get('/builds/{build_id}/files', 'BuildController@files')
     ->whereNumber('build_id');

routes/web.php

@@ -355,7 +355,7 @@ public function testInstrumentationItem(): void
                 'workingdirectory' => Str::uuid()->toString(),
             ]);
 
-            $this->assertNotDisabled($browser, "/builds/{$build->id}", '@sidebar-instrumentation', "/builds/{$build->id}/commands");
+            $this->assertNotDisabled($browser, "/builds/{$build->id}", '@sidebar-instrumentation', "/builds/{$build->id}/instrumentation");
         });
     }