Skip to content

Commit 85caac8

Browse files
optimization
1 parent 10c181d commit 85caac8

3 files changed

Lines changed: 10 additions & 40 deletions

File tree

kratos.gid/scripts/Controllers/CommonProcs.tcl

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -79,18 +79,18 @@ proc spdAux::ProcGetElementsDict { domNode args } {
7979
proc spdAux::ProcGetSolutionStrategies {domNode args} {
8080
set names [list ]
8181
set pnames [list ]
82-
#W $args
83-
set Sols [::Model::GetSolutionStrategies {*}$args]
84-
#W $Sols
85-
foreach ss $Sols {
82+
# W $args
83+
set sols [::Model::GetSolutionStrategies {*}$args]
84+
# W $Sols
85+
foreach ss $sols {
8686
lappend names [$ss getName]
8787
lappend pnames [$ss getName]
8888
lappend pnames [$ss getPublicName]
8989
}
9090

9191
$domNode setAttribute values [join $names ","]
9292
set dv [lindex $names 0]
93-
#W "dv $dv"
93+
# W "dv $dv"
9494
if {[$domNode getAttribute v] eq ""} {$domNode setAttribute v $dv; spdAux::RequestRefresh}
9595
if {[$domNode getAttribute v] ni $names} {$domNode setAttribute v $dv; spdAux::RequestRefresh}
9696

@@ -99,7 +99,7 @@ proc spdAux::ProcGetSolutionStrategies {domNode args} {
9999

100100
proc spdAux::ProcGetSchemes {domNode args} {
101101
set nodeApp [GetAppIdFromNode $domNode]
102-
#W $nodeApp
102+
# W $nodeApp
103103
set sol_stratUN [apps::getAppUniqueName $nodeApp SolStrat]
104104
set sol_stat_path [spdAux::getRoute $sol_stratUN]
105105

@@ -109,6 +109,7 @@ proc spdAux::ProcGetSchemes {domNode args} {
109109
get_domnode_attribute [$domNode selectNodes $sol_stat_path] values
110110
#}
111111
set solStratName [::write::getValue $sol_stratUN]
112+
if {$solStratName eq "" } {error "No solution strategy"}
112113
#W "Unique name: $sol_stratUN - Nombre $solStratName"
113114
set schemes [::Model::GetAvailableSchemes $solStratName {*}$args]
114115

kratos.gid/scripts/Model/Model.tcl

Lines changed: 1 addition & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,7 @@ proc Model::Init { } {
3030
variable ConstitutiveLaws
3131
variable Solvers
3232
variable Processes
33-
34-
#set dir $::Kratos::kratos_private(Path)
35-
33+
3634
set SolutionStrategies [list ]
3735
set Elements [list ]
3836
set Materials [list ]
@@ -53,70 +51,42 @@ proc Model::InitVariables {varName varValue} {
5351
}
5452

5553
proc Model::getSolutionStrategies { SolutionStrategyFileName } {
56-
#variable SolutionStrategies
5754
variable dir
58-
59-
#set SolutionStrategies [list ]
6055
dom parse [tDOM::xmlReadFile [file join $dir xml $SolutionStrategyFileName]] doc
61-
6256
ParseSolutionStrategies $doc
6357
}
6458

6559
proc Model::getElements { ElementsFileName } {
66-
#variable Elements
6760
variable dir
68-
69-
#set Elements [list ]
7061
dom parse [tDOM::xmlReadFile [file join $dir xml $ElementsFileName]] doc
71-
7262
ParseElements $doc
7363
}
7464
proc Model::getConditions { ConditionsFileName } {
75-
#variable Conditions
7665
variable dir
77-
78-
#set Conditions [list ]
7966
dom parse [tDOM::xmlReadFile [file join $dir xml $ConditionsFileName]] doc
80-
8167
ParseConditions $doc
8268
}
8369
proc Model::getNodalConditions { NodalConditionsFileName } {
84-
#variable NodalConditions
8570
variable dir
86-
87-
#set Conditions [list ]
8871
dom parse [tDOM::xmlReadFile [file join $dir xml $NodalConditionsFileName]] doc
89-
#W [$doc asXML]
9072
ParseNodalConditions $doc
9173
}
9274

9375
proc Model::getConstitutiveLaws { ConstitutiveLawsFileName } {
94-
#variable ConstitutiveLaws
9576
variable dir
96-
97-
#set ConstitutiveLaws [list ]
9877
dom parse [tDOM::xmlReadFile [file join $dir xml $ConstitutiveLawsFileName]] doc
99-
10078
ParseConstitutiveLaws $doc
10179
}
10280

10381
proc Model::getSolvers { SolversFileName } {
104-
#variable Solvers
10582
variable dir
106-
107-
#set Solvers [list ]
10883
dom parse [tDOM::xmlReadFile [file join $dir xml $SolversFileName]] doc
109-
11084
ParseSolvers $doc
11185
}
11286

11387
proc Model::getProcesses { ProcessesFileName } {
114-
#variable Processes
11588
variable dir
116-
117-
#set Processes [list ]
11889
dom parse [tDOM::xmlReadFile [file join $dir xml $ProcessesFileName]] doc
119-
12090
ParseProcesses $doc
12191
}
12292
proc Model::getMaterials { MaterialsFileName } {

kratos.gid/scripts/Model/SolutionStrategy.tcl

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -124,9 +124,10 @@ oo::class create SolStrat {
124124
}
125125
method cumple {args} {
126126
set c [next {*}$args]
127-
127+
# W "[my getName] $c"
128128
if {$c && ![write::isBooleanFalse [my getAttribute "NeedElements"]]} {
129129
set c 0
130+
# W "[my getName] $c"
130131
foreach sc [my getSchemes] {
131132
if [llength [Model::GetAvailableElements [my getName] [$sc getName]]] {
132133
set c 1; break
@@ -361,7 +362,6 @@ proc Model::GetSchemesParams {args} {
361362

362363
proc Model::GetAvailableElements {solutionStrategyId schemeId} {
363364
variable Elements
364-
variable SolutionStrategies
365365
#W "GetAvailableElements ss $solutionStrategyId sch $schemeId"
366366
set cumplen [list ]
367367
set solst [Model::GetSolutionStrategy $solutionStrategyId]
@@ -387,7 +387,6 @@ proc Model::GetAvailableElements {solutionStrategyId schemeId} {
387387

388388
proc Model::GetAvailableConditions {solutionStrategyId schemeId} {
389389
variable Conditions
390-
variable SolutionStrategies
391390

392391
set cumplen [list ]
393392
#W $solutionStrategyId

0 commit comments

Comments
 (0)