Skip to content

Commit 06cac6c

Browse files
Merge pull request #15 from KristofferStrube/feature/remove-obsolete-create-methods
Removed obsoleted `Create` methods.
2 parents 87b6f29 + 67072cf commit 06cac6c

4 files changed

Lines changed: 0 additions & 28 deletions

File tree

src/KristofferStrube.Blazor.FileSystem/FileSystemDirectoryHandle.cs

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,6 @@ public class FileSystemDirectoryHandle : FileSystemHandle, IJSCreatable<FileSyst
2222
return Task.FromResult(new FileSystemDirectoryHandle(jSRuntime, jSReference, options));
2323
}
2424

25-
/// <inheritdoc cref="CreateAsync(IJSRuntime, IJSObjectReference)"/>
26-
[Obsolete("This will be removed in the next major release as all creator methods should be asynchronous for uniformity. Use CreateAsync instead.")]
27-
public static new FileSystemDirectoryHandle Create(IJSRuntime jSRuntime, IJSObjectReference jSReference)
28-
{
29-
return new(jSRuntime, jSReference, new());
30-
}
31-
3225
/// <inheritdoc cref="CreateAsync(IJSRuntime, IJSObjectReference, CreationOptions)"/>
3326
protected FileSystemDirectoryHandle(IJSRuntime jSRuntime, IJSObjectReference jSReference, CreationOptions options) : base(jSRuntime, jSReference, options) { }
3427

src/KristofferStrube.Blazor.FileSystem/FileSystemFileHandle.cs

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,6 @@ public class FileSystemFileHandle : FileSystemHandle, IJSCreatable<FileSystemFil
2323
return Task.FromResult(new FileSystemFileHandle(jSRuntime, jSReference, options));
2424
}
2525

26-
/// <inheritdoc cref="CreateAsync(IJSRuntime, IJSObjectReference)" path="/summary"/>
27-
[Obsolete("This will be removed in the next major release as all creator methods should be asynchronous for uniformity. Use CreateAsync instead.")]
28-
public static new FileSystemFileHandle Create(IJSRuntime jSRuntime, IJSObjectReference jSReference)
29-
{
30-
return new(jSRuntime, jSReference, new());
31-
}
32-
3326
/// <inheritdoc cref="CreateAsync(IJSRuntime, IJSObjectReference, CreationOptions)"/>
3427
protected FileSystemFileHandle(IJSRuntime jSRuntime, IJSObjectReference jSReference, CreationOptions options) : base(jSRuntime, jSReference, options) { }
3528

src/KristofferStrube.Blazor.FileSystem/FileSystemHandle.cs

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,6 @@ public static Task<FileSystemHandle> CreateAsync(IJSRuntime jSRuntime, IJSObject
1919
return Task.FromResult(new FileSystemHandle(jSRuntime, jSReference, options));
2020
}
2121

22-
/// <inheritdoc cref="CreateAsync(IJSRuntime, IJSObjectReference)" path="/summary"/>
23-
[Obsolete("This will be removed in the next major release as all creator methods should be asynchronous for uniformity. Use CreateAsync instead.")]
24-
public static FileSystemHandle Create(IJSRuntime jSRuntime, IJSObjectReference jSReference)
25-
{
26-
return new(jSRuntime, jSReference, new());
27-
}
28-
2922
/// <inheritdoc cref="CreateAsync(IJSRuntime, IJSObjectReference, CreationOptions)"/>
3023
protected FileSystemHandle(IJSRuntime jSRuntime, IJSObjectReference jSReference, CreationOptions options) : base(jSRuntime, jSReference, options) { }
3124

src/KristofferStrube.Blazor.FileSystem/FileSystemWritableFileStream.cs

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,13 +35,6 @@ public class FileSystemWritableFileStream : WritableStream, IJSCreatable<FileSys
3535
return Task.FromResult(new FileSystemWritableFileStream(jSRuntime, jSReference, options));
3636
}
3737

38-
/// <inheritdoc cref="CreateAsync(IJSRuntime, IJSObjectReference)"/>
39-
[Obsolete("This will be removed in the next major release as all creator methods should be asynchronous for uniformity. Use CreateAsync instead.")]
40-
public static new FileSystemWritableFileStream Create(IJSRuntime jSRuntime, IJSObjectReference jSReference)
41-
{
42-
return new FileSystemWritableFileStream(jSRuntime, jSReference, new() { DisposesJSReference = true });
43-
}
44-
4538
/// <inheritdoc cref="CreateAsync(IJSRuntime, IJSObjectReference, CreationOptions)"/>
4639
protected FileSystemWritableFileStream(IJSRuntime jSRuntime, IJSObjectReference jSReference, CreationOptions options) : base(jSRuntime, jSReference, options)
4740
{

0 commit comments

Comments
 (0)