Skip to content

Commit 4318229

Browse files
committed
Move plugins to common configuration.
1 parent d883519 commit 4318229

3 files changed

Lines changed: 13 additions & 15 deletions

File tree

webpack/webpack.common.config.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
const { resolve } = require('path');
2+
const CleanWebpackPlugin = require('clean-webpack-plugin');
23

34
module.exports = ({ outputDir }) => ({
45
mode: 'development',
@@ -21,6 +22,9 @@ module.exports = ({ outputDir }) => ({
2122
},
2223
],
2324
},
25+
plugins: [
26+
new CleanWebpackPlugin([outputDir]),
27+
],
2428
externals: {
2529
'solid-auth-client': ['solid', 'auth'],
2630
},

webpack/webpack.demo.config.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,26 @@
1-
const common = require('./webpack.common.config');
2-
const CleanWebpackPlugin = require('clean-webpack-plugin');
3-
const CopyWebpackPlugin = require('copy-webpack-plugin');
4-
51
const outputDir = './dist/demo/';
2+
const common = require('./webpack.common.config')({ outputDir });
3+
4+
const CopyWebpackPlugin = require('copy-webpack-plugin');
65

76
const localAssets = [
87
'user.html',
98
];
9+
1010
const externalAssets = [
1111
'solid-auth-client/dist-popup/popup.html',
1212
'solid-auth-client/dist-lib/solid-auth-client.bundle.js',
1313
'solid-auth-client/dist-lib/solid-auth-client.bundle.js.map',
1414
];
1515

16-
module.exports = Object.assign({
16+
module.exports = Object.assign({}, common, {
1717
plugins: [
18-
new CleanWebpackPlugin([outputDir]),
18+
...common.plugins,
1919
new CopyWebpackPlugin(localAssets, { context: 'demo' }),
2020
new CopyWebpackPlugin(externalAssets.map(a => require.resolve(a))),
2121
],
2222
devServer: {
2323
index: 'user.html',
2424
contentBase: outputDir,
2525
},
26-
}, common({ outputDir }));
26+
});

webpack/webpack.lib.config.js

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,4 @@
1-
const common = require('./webpack.common.config');
2-
const CleanWebpackPlugin = require('clean-webpack-plugin');
3-
41
const outputDir = './dist/';
2+
const common = require('./webpack.common.config')({ outputDir });
53

6-
module.exports = Object.assign({
7-
plugins: [
8-
new CleanWebpackPlugin([outputDir]),
9-
],
10-
}, common({ outputDir }));
4+
module.exports = Object.assign({}, common);

0 commit comments

Comments
 (0)